GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-143754: Add Tkinter methods pack_content(), place_content() and grid_content() by serhiy-storchaka · Pull Request #143845 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jan 14, 2026 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

They use Tk commands with new name like "pack content instead of old "pack slaves".

Based on top of #143841.

  • Issue: tkinter source and docs use the word 'slave' #143754

📚 Documentation preview 📚: https://cpython-previews--143845.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

terryjreedy reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@serhiy-storchaka
serhiy-storchaka requested a review from terryjreedy January 14, 2026 19:40
@serhiy-storchaka
serhiy-storchaka requested a review from AA-Turner as a code owner January 14, 2026 19:40
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 14, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 14, 2026
tkinter source and docs use the word 'slave' #143754
Closed
@terryjreedy

terryjreedy commented Jan 19, 2026

Copy link
Copy Markdown
Member

The new stuff (on top of what is already in #143841) looks okay without closely examining every detail.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Jan 19, 2026

Copy link
Copy Markdown
Member

I suggest we also:

  • Have the *slaves() synonyms call the *content() functions instead of having separate functions. There's not much duplicate code, but there's some, and it means we won't need to make future fixes in two places. Also we're no longer testing the *slaves() paths so may introduce untested bugs.

  • Deprecates our *slaves() synonyms. TIP 581 didn't deprecate them in Tcl/Tk, but that doesn't mean we need to keep them in our interface. We do not need to set a removal date (we currently support 8.5.12 and upstream added synonyms in 8.6).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka

serhiy-storchaka commented Jan 19, 2026

Copy link
Copy Markdown
Member Author

To be nice, we should deprecate the old methods only when the new methods are available in all maintained Python versions, so the user can simply unconditionally switch to using the new methods.

Since this change is just cosmetic, there is no need to even deprecate them in code. The code written 20 years ago will continue to work.

We still test the *slaves() methods. This is why we need a separate implementation -- to notice when it stopped working on the Tk side.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
pythongh-143754: Add Tkinter methods pack_content(), place_content() …
999b0e6
…and grid_content()

They use Tk commands with new name like "pack content instead of old
"pack slaves".
@serhiy-storchaka
serhiy-storchaka force-pushed the tkinter-pack_content branch from 92374bb to 999b0e6 Compare January 19, 2026 12:11
hugovk
hugovk approved these changes Jan 19, 2026
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could soft deprecate until then?

Anyway, thanks for the PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jan 19, 2026
@serhiy-storchaka

serhiy-storchaka commented Jan 19, 2026

Copy link
Copy Markdown
Member Author

There is no module documentation where the soft deprecation could be written.

The docstrins now say "Synonym for ...". This is an equivalent of soft deprecation. You should not use these methods in new code if you do not support Python 3.14, but you are not forced to make mass renaming. I expect that nobody will use the new methods in the next 3 years.

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
serhiy-storchaka merged commit 71cbffd into python:main Jan 20, 2026
51 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 20, 2026
@serhiy-storchaka
serhiy-storchaka deleted the tkinter-pack_content branch January 20, 2026 07:16
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@serhiy-storchaka @thunder-coding
pythongh-143754: Add Tkinter methods pack_content(), place_content() …
1e71b07
…and grid_content() (pythonGH-143845)

They use Tk commands with new name like "pack content instead of old
"pack slaves".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@terryjreedy terryjreedy Awaiting requested review from terryjreedy
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @terryjreedy @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.