GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-145854: Replace `DELETE_NAME` with `PUSH_NULL; STORE_NAME` by brijkapadia · Pull Request #146006 · python/cpython

Conversation

@brijkapadia

@brijkapadia brijkapadia commented Mar 16, 2026 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Changes

  • Removed DELETE_NAME
  • When STORE_NAME receives a NULL value, it corresponds with deletion
  • Issue: Remove DELETE_NAME instruction #145854

📚 Documentation preview 📚: https://cpython-previews--146006.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@brijkapadia
pythongh-145854: Replace DELETE_NAME with PUSH_NULL; STORE_NAME
1f97a49
Changes
- Removed `DELETE_NAME`
- When `STORE_NAME` receives a `NULL` value, it corresponds with
  deletion
@brijkapadia
brijkapadia requested review from ericsnowcurrently, iritkatriel and markshannon as code owners March 16, 2026 02:21
@bedevere-app bedevere-app Bot mentioned this pull request Mar 16, 2026
Remove DELETE_NAME instruction #145854
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Mar 16, 2026
@blurb-it
📜🤖 Added by blurb_it.
ed1b971
@brijkapadia brijkapadia mentioned this pull request Mar 16, 2026
gh-145749: Optimize named exception blocks #145983
Open
@brijkapadia
brijkapadia marked this pull request as draft March 16, 2026 02:31
@bedevere-app bedevere-app Bot removed the awaiting review label Mar 16, 2026
@brijkapadia
brijkapadia marked this pull request as ready for review March 16, 2026 10:39
@bedevere-app bedevere-app Bot added the awaiting review label Mar 16, 2026
@brijkapadia

brijkapadia commented Mar 16, 2026

Copy link
Copy Markdown
Contributor Author

I am not sure why three of the CIFuzz tests fail. If anyone could help, that would be appreciated.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

picnixz
picnixz reviewed Mar 16, 2026
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

picnixz
picnixz reviewed Mar 16, 2026
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@markshannon

markshannon commented Mar 16, 2026

Copy link
Copy Markdown
Member

This will need a magic number bump (as do all changes that add or remove opcodes)

brijkapadia reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brijkapadia
Updated STORE_FAST; Changed magic number; Added test
93d91b8
@brijkapadia brijkapadia mentioned this pull request Mar 17, 2026
Remove DELETE_GLOBAL bytecode instruction #145857
Closed
markshannon
markshannon approved these changes Mar 17, 2026
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 17, 2026
brijkapadia added 4 commits March 19, 2026 19:27
@brijkapadia
Merge branch 'main' into delete-name
68a9599
@brijkapadia
Update generated files and magic number
68383f5
@brijkapadia
Merge branch 'main' into delete-name
6adc1d0
@brijkapadia
Update generated files/magic number
0bbfa52
@brijkapadia

brijkapadia commented Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

@markshannon A gentle reminder about this PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303

kumaraditya303 commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

A gentle reminder about this PR.

There are merge conflicts.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brijkapadia
Merge branch 'main' into delete-name
6dc57ee
@python-cla-bot

python-cla-bot Bot commented Apr 17, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@brijkapadia
Update generated files; Update magic number
da4dc56
brijkapadia added 2 commits May 29, 2026 12:17
@brijkapadia
Fix merge errors
a72a434
@brijkapadia
create _PyEval_StoreName
2340680
@brijkapadia
brijkapadia requested a review from markshannon May 29, 2026 16:52
brijkapadia added 4 commits May 31, 2026 14:27
@brijkapadia
fix test
cb7ad39
@brijkapadia
Merge remote-tracking branch 'upstream/main' into delete-name
9c1f73c
@brijkapadia
update helper function
6be315b
@brijkapadia
update generated files
22867fc
@brijkapadia

brijkapadia commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

@markshannon A reminder about this PR, whenever you get a chance

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

markshannon
markshannon requested changes Jun 30, 2026
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for doing this.

I mistake in the magic number comment and needs merge conflicts fixing.
Otherwise, good to merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Include/internal/pycore_magic_number.h Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting merge labels Jun 30, 2026
@bedevere-app

bedevere-app Bot commented Jun 30, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brijkapadia and others added 2 commits June 30, 2026 09:35
@brijkapadia @markshannon
Update Include/internal/pycore_magic_number.h
45ce2e5
Co-authored-by: Mark Shannon <[email protected]>
@brijkapadia
Merge remote-tracking branch 'upstream/main' into delete-name
87c2898
@brijkapadia

brijkapadia commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added awaiting change review and removed awaiting changes labels Jun 30, 2026
@bedevere-app

bedevere-app Bot commented Jun 30, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app
bedevere-app Bot requested a review from markshannon June 30, 2026 13:44
markshannon
markshannon approved these changes Jun 30, 2026
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting change review labels Jun 30, 2026
@markshannon
markshannon merged commit c393ab6 into python:main Jun 30, 2026
83 of 86 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 30, 2026
@brijkapadia
brijkapadia deleted the delete-name branch June 30, 2026 16:33
@markshannon markshannon mentioned this pull request Jun 30, 2026
gh-145855: Remove the DELETE_ATTR bytecode #146216
Merged
maurycy added a commit to maurycy/cpython that referenced this pull request Jul 1, 2026
@maurycy
Merge branch 'main' into maurycy/bye-abba
da7d768
* main: (266 commits)
  pythongh-151626: Fix tests that fail when PYTHONPYCACHEPREFIX is set (pythonGH-151952)
  pythongh-152728: IDLE - move 3 toplevel fix_xyz functions to idlelb.util (python#152729)
  pythongh-152711: Add pythoninfo-build command to Platforms/Android (python#152713)
  pythongh-152715: Add pythoninfo-build command to Platforms/Apple (python#152716)
  pythongh-152433: Windows: enable mmapmodule for UWP (python#152473)
  pythongh-152433: Windows: use GetFileSizeEx instead of GetFileSize for memory mapped files (python#152383)
  pythonGH-81881: Raise `SpecialFileError` for sockets and devices in `shutil.copyfile` (python#142693)
  pythongh-152502: Detect the curses mouse interface and is_* methods portably (pythonGH-152705)
  pythongh-145857: Replace `DELETE_GLOBAL` with `PUSH_NULL; STORE_GLOBAL` (pythonGH-146314)
  pythongh-145854: Replace `DELETE_NAME` with `PUSH_NULL; STORE_NAME` (pythonGH-146006)
  pythongh-152680: Detect container/VM in test.pythoninfo (python#152668)
  pythongh-152682: Fix NULL dereference on OOM in `symtable_visit_type_param_bound_or_default` (python#152684)
  pythongh-151881: Skip tk_inactive negativity check on Windows (pythonGH-152683)
  pythongh-152546: Refactor `mappingproxy.__new__` to use `PyDictProxy_New` (python#152547)
  pythongh-151126: Fix a possible crash during the startup with no memory under `Py_STACKREF_DEBUG` (python#152478)
  pythongh-152635: Raise MemoryError when the lock allocation fails in `_interpchannels.create()` (python#152642)
  pythongh-151029: Fix `test_remote_exec_deleted_static_executable` on static installed builds (pythonGH-152653)
  pythongh-121249: Deprecate using F/D type codes in the struct module (python#152309)
  pythongh-152192: Fix JUMP_BACKWARD passing a truncated oparg to the jit tracer (pythonGH-152382)
  Don't require the `_test{internal}capi` modules in `test_monitoring.py` (python#152311)
  ...
rokm added a commit to rokm/pyinstaller that referenced this pull request Oct 17, 2026
@rokm
modulegraph: update _scan_code for python 3.16
ba3c857
In python 3.16.0a1, the `DELETE_NAME` opcode has been replaced
by a combination of `PUSH_NULL` and `STORE_NAME`:
- python/cpython#145854
- python/cpython#146006

Adjust the code in `ModuleGraph._scan_bytecode()` to account for
this, in order to fix the failing `test_scan_code__basic` in
`test_modulegraph_more.py`.

It is worth noting that this has a limited effect on our actual use
of the modulegraph, as we do not particularly care about what
attributes exist in analyzed modules...
rokm added a commit to rokm/pyinstaller that referenced this pull request Nov 4, 2026
@rokm
modulegraph: update _scan_code for python 3.16
7c3a2ff
In python 3.16.0a1, the `DELETE_NAME` opcode has been replaced
by a combination of `PUSH_NULL` and `STORE_NAME`:
- python/cpython#145854
- python/cpython#146006

Adjust the code in `ModuleGraph._scan_bytecode()` to account for
this, in order to fix the failing `test_scan_code__basic` in
`test_modulegraph_more.py`.

It is worth noting that this has a limited effect on our actual use
of the modulegraph, as we do not particularly care about what
attributes exist in analyzed modules...
rokm added a commit to rokm/pyinstaller that referenced this pull request Nov 11, 2026
@rokm
modulegraph: update _scan_code for python 3.16
a67ec91
In python 3.16.0a1, the `DELETE_NAME` opcode has been replaced
by a combination of `PUSH_NULL` and `STORE_NAME`:
- python/cpython#145854
- python/cpython#146006

Adjust the code in `ModuleGraph._scan_bytecode()` to account for
this, in order to fix the failing `test_scan_code__basic` in
`test_modulegraph_more.py`.

It is worth noting that this has a limited effect on our actual use
of the modulegraph, as we do not particularly care about what
attributes exist in analyzed modules...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
@kumaraditya303 kumaraditya303 kumaraditya303 left review comments
@markshannon markshannon markshannon approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@brijkapadia @markshannon @kumaraditya303 @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.