GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-151126: Fix a possible crash during the startup with no memory under `Py_STACKREF_DEBUG` by sobolevn · Pull Request #152478 · python/cpython

Conversation

sobolevn commented Jun 28, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

_Py_hashtable_new_full can return NULL (when no memory is left) and does not set an exception
interp->open_stackrefs_table and interp->closed_stackrefs_table are required to be non-NULL
If they are, we can possibly get a NULL deref from using them

Issue: Many places have missing PyErr_NoMemory() call after failing memory allocation #151126

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-151126: Fix a possible crash during the startup with no memo…

c27d05a

…ry under `Py_STACKREF_DEBUG`

sobolevn requested a review from serhiy-storchaka

June 28, 2026 10:08

sobolevn requested review from FFY00, ZeroIntensity and ericsnowcurrently as code owners

June 28, 2026 10:08

bedevere-app Bot added the awaiting core review label

Jun 28, 2026

bedevere-app Bot mentioned this pull request

Jun 28, 2026

Many places have missing PyErr_NoMemory() call after failing memory allocation #151126

Open

ZeroIntensity reviewed

Jun 28, 2026

View reviewed changes

Comment thread

Misc/NEWS.d/next/Library/2026-06-28-13-05-52.gh-issue-151126.KE2OvV.rst Outdated

Comment on lines +1 to +2

		Fix a possible crash during the interpreter startup under a memory pressure
		with ``Py_STACKREF_DEBUG`` enabled.

ZeroIntensity Jun 28, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really need a news entry? I can't imagine why downstream users would want this build.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

sobolevn Jun 28, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, removed :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Delete Misc/NEWS.d/next/Library/2026-06-28-13-05-52.gh-issue-151126.K…

1e8edf9

…E2OvV.rst

sobolevn added skip news needs backport to 3.13

only security fixes

needs backport to 3.14

bugs and security fixes

needs backport to 3.15 bugs and security fixes labels

Jun 28, 2026

sobolevn requested a review from ZeroIntensity

June 29, 2026 21:29

ZeroIntensity approved these changes

Jun 29, 2026

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Jun 29, 2026

sobolevn merged commit ecdef17 into python:main

Jun 30, 2026

63 checks passed

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Jun 30, 2026

Copy link

Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Jun 30, 2026

bedevere-app Bot commented Jun 30, 2026

Copy link

Copy Markdown

GH-152677 is a backport of this pull request to the 3.15 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Jun 30, 2026

Copy link

Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ecdef1773006529b0fea6639d0effeecbb41679c 3.13

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label

Jun 30, 2026

miss-islington-app Bot assigned sobolevn

Jun 30, 2026

bedevere-app Bot commented Jun 30, 2026

Copy link

Copy Markdown

GH-152678 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Jun 30, 2026

sobolevn commented Jun 30, 2026

Copy link

Copy Markdown

Member Author

3.13 does not have this code, removed the backport label.

ZeroIntensity reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn removed the needs backport to 3.13 only security fixes label

Jun 30, 2026

sobolevn added a commit that referenced this pull request

Jun 30, 2026


          [3.14] gh-151126: Fix a possible crash during the startup with no mem…

fd4965d

…ory under `Py_STACKREF_DEBUG` (GH-152478) (#152678)

gh-151126: Fix a possible crash during the startup with no memory under `Py_STACKREF_DEBUG` (GH-152478)
(cherry picked from commit ecdef17)

Co-authored-by: sobolevn <[email protected]>

sobolevn added a commit that referenced this pull request

Jun 30, 2026


          [3.15] gh-151126: Fix a possible crash during the startup with no mem…

0f3e91b

…ory under `Py_STACKREF_DEBUG` (GH-152478) (#152677)

gh-151126: Fix a possible crash during the startup with no memory under `Py_STACKREF_DEBUG` (GH-152478)
(cherry picked from commit ecdef17)

Co-authored-by: sobolevn <[email protected]>

maurycy added a commit to maurycy/cpython that referenced this pull request

Jul 1, 2026


          Merge branch 'main' into maurycy/bye-abba

da7d768

* main: (266 commits)
  pythongh-151626: Fix tests that fail when PYTHONPYCACHEPREFIX is set (pythonGH-151952)
  pythongh-152728: IDLE - move 3 toplevel fix_xyz functions to idlelb.util (python#152729)
  pythongh-152711: Add pythoninfo-build command to Platforms/Android (python#152713)
  pythongh-152715: Add pythoninfo-build command to Platforms/Apple (python#152716)
  pythongh-152433: Windows: enable mmapmodule for UWP (python#152473)
  pythongh-152433: Windows: use GetFileSizeEx instead of GetFileSize for memory mapped files (python#152383)
  pythonGH-81881: Raise `SpecialFileError` for sockets and devices in `shutil.copyfile` (python#142693)
  pythongh-152502: Detect the curses mouse interface and is_* methods portably (pythonGH-152705)
  pythongh-145857: Replace `DELETE_GLOBAL` with `PUSH_NULL; STORE_GLOBAL` (pythonGH-146314)
  pythongh-145854: Replace `DELETE_NAME` with `PUSH_NULL; STORE_NAME` (pythonGH-146006)
  pythongh-152680: Detect container/VM in test.pythoninfo (python#152668)
  pythongh-152682: Fix NULL dereference on OOM in `symtable_visit_type_param_bound_or_default` (python#152684)
  pythongh-151881: Skip tk_inactive negativity check on Windows (pythonGH-152683)
  pythongh-152546: Refactor `mappingproxy.__new__` to use `PyDictProxy_New` (python#152547)
  pythongh-151126: Fix a possible crash during the startup with no memory under `Py_STACKREF_DEBUG` (python#152478)
  pythongh-152635: Raise MemoryError when the lock allocation fails in `_interpchannels.create()` (python#152642)
  pythongh-151029: Fix `test_remote_exec_deleted_static_executable` on static installed builds (pythonGH-152653)
  pythongh-121249: Deprecate using F/D type codes in the struct module (python#152309)
  pythongh-152192: Fix JUMP_BACKWARD passing a truncated oparg to the jit tracer (pythonGH-152382)
  Don't require the `_test{internal}capi` modules in `test_monitoring.py` (python#152311)
  ...

Reviewers

ZeroIntensity

ZeroIntensity approved these changes

serhiy-storchaka

Awaiting requested review from serhiy-storchaka

ericsnowcurrently

Awaiting requested review from ericsnowcurrently

ericsnowcurrently is a code owner

FFY00

Awaiting requested review from FFY00

FFY00 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

sobolevn

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sobolevn commented Jun 28, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZeroIntensity Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

sobolevn Jun 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app Bot commented Jun 30, 2026

Uh oh!

bedevere-app Bot commented Jun 30, 2026

Uh oh!

miss-islington-app Bot commented Jun 30, 2026

Uh oh!

bedevere-app Bot commented Jun 30, 2026

Uh oh!

sobolevn commented Jun 30, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sobolevn commented Jun 28, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.