GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146199: Fix error handling in `code_richcompare` when `PyObject_RichCompareBool` fails by brijkapadia · Pull Request #146200 · python/cpython

Conversation

@brijkapadia

@brijkapadia brijkapadia commented Mar 20, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: code_richcompare swallows errors #146199

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brijkapadia
pythongh-146199: Fix error handling in code_richcompare when `PyObj…
a388f88 
…ect_RichCompareBool` fails
@brijkapadia
brijkapadia requested a review from markshannon as a code owner March 20, 2026 10:35
@bedevere-app bedevere-app Bot mentioned this pull request Mar 20, 2026
code_richcompare swallows errors #146199
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Mar 20, 2026
@blurb-it
📜🤖 Added by blurb_it.
1d128a6
vstinner
vstinner reviewed Mar 20, 2026
View reviewed changes
Comment thread Lib/test/test_code.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_code.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
brijkapadia and others added 2 commits March 20, 2026 14:19
@brijkapadia @vstinner
Update Lib/test/test_code.py
7f1d736 
Co-authored-by: Victor Stinner <[email protected]>
@brijkapadia
Update __hash__ in test
ef70ca5
vstinner
vstinner approved these changes Mar 21, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2026-03-20-12-26-24.gh-issue-146199.vV8V9s.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 21, 2026
@brijkapadia
Move NEWS to Core_and_Builtins
bc1ecf6
@vstinner
vstinner merged commit e017971 into python:main Mar 23, 2026
50 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 23, 2026
@vstinner

vstinner commented Mar 23, 2026

Copy link
Copy Markdown
Member

Thanks for your fix. I merged your PR.

I don't think that it's worth it to backport the change, it's a corner case which shouldn't occur in practice.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Mar 24, 2026
@CuriousLearner
Merge branch 'fix-pythongh-138577' of github.com:CuriousLearner/cpyth…
78b2c6a 
…on into fix-pythongh-138577

* 'fix-pythongh-138577' of github.com:CuriousLearner/cpython:
  pythongh-146202: Create tmp_dir in regrtest worker (python#146347)
  pythongh-144319: obtain SeLockMemoryPrivilege on Windows (python#144928)
  pythongh-146199: Fix error handling in `code_richcompare` when `PyObject_RichCompareBool` fails (python#146200)
  pythongh-146197: Include a bit more information in sys._emscripten_info.runtime (python#146346)
  pythongh-135871: Reload lock internal state while spinning in `PyMutex_LockTimed` (pythongh-146064)
  pythongh-145719: Add `.efi` file detection in `mimetypes` (python#145720)
@brijkapadia
brijkapadia deleted the codeobject-richcomp branch March 24, 2026 09:00
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@brijkapadia @blurb-it
@vstinner @clin1234
pythongh-146199: Fix error handling in code_richcompare when `PyObj…
ff603dc 
…ect_RichCompareBool` fails (python#146200)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Victor Stinner <[email protected]>
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@brijkapadia @blurb-it
@vstinner @ljfp
pythongh-146199: Fix error handling in code_richcompare when `PyObj…
d24feb2 
…ect_RichCompareBool` fails (python#146200)

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@vstinner vstinner vstinner approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@brijkapadia @vstinner @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.