GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146197: Include a bit more information in sys._emscripten_info.runtime by hoodmane · Pull Request #146346 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Mar 23, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Before: sys._emscripten_info.runtime is Node.js/24, now it says node v24.14.0 (v8 13.6.233.17-node.41). I also added detection for node and bun.

  • Issue: Add CI job for Emscripten #146197

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-146197: Include a bit more information in sys._emscripten_in…
d7d66ed 
…fo.runtime
@hoodmane
hoodmane requested a review from ericsnowcurrently as a code owner March 23, 2026 21:31
@bedevere-app bedevere-app Bot added the awaiting review label Mar 23, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 23, 2026
Add CI job for Emscripten #146197
Closed
@hoodmane hoodmane added skip news needs backport to 3.14 bugs and security fixes OS-emscripten labels Mar 23, 2026
@hoodmane
hoodmane requested a review from vstinner March 23, 2026 21:32
@vstinner

vstinner commented Mar 23, 2026

Copy link
Copy Markdown
Member

pythoninfo of the Emscripten CI job says:

sys._emscripten_info: sys._emscripten_info(emscripten_version=(4, 0, 12), runtime='node v24.14.0 (v8 13.6.233.17-node.41)', pthreads=False, shared_memory=False)

needs backport to 3.14

I'm not sure that it's a good idea to change sys._emscripten_info.runtime in a Python 3.14.x bugfix release. Some projects may rely on the current string format.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Mar 23, 2026
View reviewed changes

@vstinner vstinner left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But it may safer to not backport the change to 3.14.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 23, 2026
@hoodmane

hoodmane commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

Right, I suppose we don't need the backport for anything.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane hoodmane removed the needs backport to 3.14 bugs and security fixes label Mar 23, 2026
@vstinner
vstinner enabled auto-merge (squash) March 23, 2026 21:50
@vstinner
vstinner merged commit 7dc2f52 into python:main Mar 23, 2026
63 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 23, 2026
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Mar 24, 2026
@CuriousLearner
Merge branch 'fix-pythongh-138577' of github.com:CuriousLearner/cpyth…
78b2c6a 
…on into fix-pythongh-138577

* 'fix-pythongh-138577' of github.com:CuriousLearner/cpython:
  pythongh-146202: Create tmp_dir in regrtest worker (python#146347)
  pythongh-144319: obtain SeLockMemoryPrivilege on Windows (python#144928)
  pythongh-146199: Fix error handling in `code_richcompare` when `PyObject_RichCompareBool` fails (python#146200)
  pythongh-146197: Include a bit more information in sys._emscripten_info.runtime (python#146346)
  pythongh-135871: Reload lock internal state while spinning in `PyMutex_LockTimed` (pythongh-146064)
  pythongh-145719: Add `.efi` file detection in `mimetypes` (python#145720)
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@hoodmane @clin1234
pythongh-146197: Include a bit more information in sys._emscripten_in…
0ccedb7 
…fo.runtime (python#146346)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@hoodmane @ljfp
pythongh-146197: Include a bit more information in sys._emscripten_in…
c829bd3 
…fo.runtime (python#146346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hoodmane @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.