GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-146376: Reduce timeout in Emscripten workflow by hoodmane · Pull Request #146378 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Mar 24, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Reduce CI timeouts #146376

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-146376: Reduce timeout in Emscripten workflow
c69499b
@hoodmane
hoodmane requested review from AA-Turner, ezio-melotti, hugovk and webknjaz as code owners March 24, 2026 13:20
@hoodmane hoodmane added skip news OS-emscripten labels Mar 24, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Mar 24, 2026
Reduce CI timeouts #146376
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Mar 24, 2026
@hoodmane hoodmane mentioned this pull request Mar 24, 2026
gh-146197: Add Emscripten to CI #146198
Merged
webknjaz
webknjaz approved these changes Mar 24, 2026
View reviewed changes

@webknjaz webknjaz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Mar 24, 2026
@vstinner

vstinner commented Mar 25, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Does Emscripten supports faulthandler.dump_traceback_later(timeout, exit=True)? If yes, I would prefer to pass a --timeout=seconds option to the python -m test (...) command (which uses dump_traceback_later()), rather than reducing the CI overall timeout.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@webknjaz

webknjaz commented Mar 25, 2026

Copy link
Copy Markdown
Member

@vstinner if that's possible, I'd recommend both timeouts (with different values). Also, this sounds like something to do in other jobs too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk reviewed Mar 29, 2026
View reviewed changes
Comment thread .github/workflows/reusable-emscripten.yml Outdated
Comment on lines +13 to +26
# It seems to take about 20 minutes without the cache, broken down as follows:
# (All times recorded from one run chosen arbitrarily.)
#
# 0.5 install Emscripten (skipped by cache)
# 1.0 configure & build native python
# 0.5 build dependencies (skipped by cache)
# 3.0 configure Emscripten Python
# 1.5 build Emscripten Python
# 0.7 build Emscripten ports (skipped by cache)
# 14.0 Test
#
# So if we add time for a rerun of the entire test suite, we get to 34
# minutes. Adding an extra 5% gets us to 36.
timeout-minutes: 36

@hugovk hugovk Mar 29, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need all the calculations here. It can be in the PR description.

And let's round the number. If the time starts being too short, we'll just bump it up a bit.

Suggested change
# It seems to take about 20 minutes without the cache, broken down as follows:
# (All times recorded from one run chosen arbitrarily.)
#
# 0.5 install Emscripten (skipped by cache)
# 1.0 configure & build native python
# 0.5 build dependencies (skipped by cache)
# 3.0 configure Emscripten Python
# 1.5 build Emscripten Python
# 0.7 build Emscripten ports (skipped by cache)
# 14.0 Test
#
# So if we add time for a rerun of the entire test suite, we get to 34
# minutes. Adding an extra 5% gets us to 36.
timeout-minutes: 36
timeout-minutes: 40

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vstinner

vstinner commented Mar 30, 2026

Copy link
Copy Markdown
Member

@hoodmane: Can you change the timeout to 40 minutes and remove the long comment, as suggested by @hugovk?
hoodmane reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane
Remove long comment and round timeout to 40 minutes
0e77b7e
vstinner
vstinner approved these changes Mar 30, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 30, 2026
@vstinner
vstinner enabled auto-merge (squash) March 30, 2026 20:20
@vstinner
vstinner merged commit 70d1b08 into python:main Mar 30, 2026
31 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 30, 2026
@hugovk hugovk added the needs backport to 3.14 bugs and security fixes label Mar 30, 2026
@miss-islington-app

miss-islington-app Bot commented Mar 30, 2026

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Mar 30, 2026

Copy link
Copy Markdown

GH-146645 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Mar 30, 2026
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 30, 2026
@hoodmane @miss-islington
pythongh-146376: Reduce timeout in Emscripten GHA workflow (pythonGH-…
b5cd4a0 
…146378)

(cherry picked from commit 70d1b08)

Co-authored-by: Hood Chatham <[email protected]>
hugovk pushed a commit that referenced this pull request Mar 30, 2026
@miss-islington @hoodmane
[3.14] gh-146376: Reduce timeout in Emscripten GHA workflow (GH-146378)…
99f333d 
… (#146645)

gh-146376: Reduce timeout in Emscripten GHA workflow (GH-146378)
(cherry picked from commit 70d1b08)

Co-authored-by: Hood Chatham <[email protected]>
maurycy added a commit to maurycy/cpython that referenced this pull request Mar 31, 2026
@maurycy
Merge branch 'main' into tachyon-ndjson-kolektor
9836ffa 
* main:
  pythongh-145458: use `self.skip_idle` consistently in the tachyon profiler (python#145459)
  pythongh-146615: Fix format specifiers in Objects/ directory (pythonGH-146620)
  pythongh-146615: Fix format specifiers in Python/ directory (pythonGH-146619)
  pythongh-146615: Fix format specifiers in test cextensions (pythonGH-146618)
  pythongh-146615: Fix format specifiers in extension modules (pythonGH-146617)
  pythongh-146615: Fix crash in __get__() for METH_METHOD descriptors with invalid type argument (pythonGH-146634)
  pythongh-146376: Reduce timeout in Emscripten GHA workflow (python#146378)
  pythongh-146442: Fix various bugs in compiler pipeline (python#146443)
  pythongh-146238: Support half-floats in the array module (python#146242)
  pythongh-145056: Add support for merging collections.UserDict and frozendict (pythonGH-146465)
  pythongh-145056: Fix merging of collections.OrderedDict and frozendict (pythonGH-146466)
  pythongh-139633: Run netrc file permission check only once per parse (pythonGH-139634)
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
gh-130273: Fix traceback color output with unicode characters #142529
Merged
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Apr 16, 2026
@hoodmane @clin1234
pythongh-146376: Reduce timeout in Emscripten GHA workflow (python#14…
d768991 
…6378)
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@hoodmane @ljfp
pythongh-146376: Reduce timeout in Emscripten GHA workflow (python#14…
0345f33 
…6378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@vstinner vstinner vstinner approved these changes
@webknjaz webknjaz webknjaz approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti
@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hoodmane @vstinner @webknjaz @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.