GeezerVison is showing github.com — gh-146579: _zstd: Fix decompression options dict error message by cuiweixie · Pull Request #146577 · python/cpython
Conversation
cuiweixie
commented
Mar 28, 2026
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Summary
Fix the TypeError string in _zstd_set_d_parameters: it incorrectly said
compression options dictionary when validating decompression option keys.
Test plan
- No behavior change beyond the error text; optional manual check by passing an
invalid key type to decompression options.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The TypeError in _zstd_set_d_parameters incorrectly referred to
compression options; say decompression options instead.
cuiweixie
changed the title
_zstd: Fix decompression options dict error message
gh-146579: _zstd: Fix decompression options dict error message
Mar 28, 2026
|
I am not sure this is a bug. Should not the compression options dictionary be the same for compression and decompression? They are compression options which should be passed to decompressor to inform what options were used during compression.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Should not the compression options dictionary be the same for compression and decompression?
They actually differ:
|
serhiy-storchaka and emmatyping reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
You are right. This check is especially to check that they are not mixed.
|
picnixz reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching this!
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @cuiweixie for the PR, and @emmatyping for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️
Hi! The buildbot iOS ARM64 Simulator 3.14 (tier-3) has failed when building commit de234fc.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1722/builds/1143) and take a look at the build logs.
- Check if the failure is related to this commit (de234fc) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/#/builders/1722/builds/1143
Summary of the results of the build (if available):
Click to see traceback logs
remote: Enumerating objects: 5, done.
remote: Counting objects: 50% (1/2)
remote: Counting objects: 100% (2/2)
remote: Counting objects: 100% (2/2), done.
remote: Compressing objects: 50% (1/2)
remote: Compressing objects: 100% (2/2)
remote: Compressing objects: 100% (2/2), done.
remote: Total 5 (delta 0), reused 0 (delta 0), pack-reused 3 (from 1)
From https://github.com/python/cpython
* branch 3.14 -> FETCH_HEAD
Note: switching to 'de234fc07adfc94518e847abecef02527e0dd130'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at de234fc07ad [3.14] gh-146579: _zstd: Fix decompression options dict error message (GH-146577) (#146611)
Switched to and reset branch '3.14'
Traceback (most recent call last):
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/Users/buildbot/buildarea/3.14.rkm-arm64-ios-simulator.iOS-simulator.arm64/build/Platforms/Apple/__main__.py", line 57, in <module>
ArgsT = Sequence[str | Path]
TypeError: unsupported operand type(s) for |: 'type' and 'type'
Traceback (most recent call last):
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/Users/buildbot/buildarea/3.14.rkm-arm64-ios-simulator.iOS-simulator.arm64/build/Platforms/Apple/__main__.py", line 57, in <module>
ArgsT = Sequence[str | Path]
TypeError: unsupported operand type(s) for |: 'type' and 'type'
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️
Hi! The buildbot s390x Fedora Stable Refleaks 3.14 (tier-3) has failed when building commit de234fc.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1776/builds/1040) and take a look at the build logs.
- Check if the failure is related to this commit (de234fc) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/#/builders/1776/builds/1040
Failed tests:
Failed subtests:
- test_only_active_thread - test.test_external_inspection.TestGetStackTrace.test_only_active_thread
- test_timerfd_poll - test.test_os.TimerfdTests.test_timerfd_poll
Summary of the results of the build (if available):
==
Click to see traceback logs
Traceback (most recent call last):
File "/var/lib/buildbot/worker/cstratak-fedora-stable-s390x/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_os.py", line 4554, in test_timerfd_poll
self.check_timerfd_poll(False)
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^
File "/var/lib/buildbot/worker/cstratak-fedora-stable-s390x/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_os.py", line 4542, in check_timerfd_poll
self.assertEqual(self.read_count_signaled(fd), 1)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 2 != 1
Traceback (most recent call last):
File "/var/lib/buildbot/worker/cstratak-fedora-stable-s390x/3.14.cstratak-fedora-stable-s390x.refleak/build/Lib/test/test_external_inspection.py", line 1289, in test_only_active_thread
self.assertEqual(
~~~~~~~~~~~~~~~~^
len(gil_traces), 1, "Should have exactly one GIL holder"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
AssertionError: 0 != 1 : Should have exactly one GIL holder
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Traceback (most recent call last):
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 197, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/Users/buildbot/buildarea/3.14.rkm-arm64-ios-simulator.iOS-simulator.arm64/build/Platforms/Apple/__main__.py", line 57, in <module>
ArgsT = Sequence[str | Path]
TypeError: unsupported operand type(s) for |: 'type' and 'type'
It looks like we are not running the correct Python version.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
The Python version on the iOS buildbot should now be corrected.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
clin1234
pushed a commit
to clin1234/cpython
that referenced
this pull request
Apr 16, 2026
…ython#146577)
The TypeError in _zstd_set_d_parameters incorrectly referred to
compression options; say decompression options instead.
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…ython#146577)
The TypeError in _zstd_set_d_parameters incorrectly referred to
compression options; say decompression options instead.
Reviewers
picnixz
picnixz approved these changes
AA-Turner
Awaiting requested review from AA-Turner
AA-Turner is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|