GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-126835: Fix _PY_IS_SMALL_INT() macro by vstinner · Pull Request #146631 · python/cpython

Conversation

vstinner commented Mar 30, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Move const folding to the peephole optimizer #126835

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-126835: Fix _PY_IS_SMALL_INT() macro

850832e

vstinner requested review from iritkatriel and markshannon as code owners

March 30, 2026 12:19

vstinner added the skip news label

Mar 30, 2026

bedevere-app Bot mentioned this pull request

Mar 30, 2026

Move const folding to the peephole optimizer #126835

Open

bedevere-app Bot added the awaiting core review label

Mar 30, 2026

skirpichev approved these changes

Mar 30, 2026

View reviewed changes

vstinner mentioned this pull request

Mar 30, 2026

gh-143050: correct PyLong_FromString() to use _PyLong_Negate() #145901

Merged

vstinner enabled auto-merge (squash)

March 30, 2026 12:41

vstinner merged commit adf2c47 into python:main

Mar 30, 2026

53 checks passed

Uh oh!

There was an error while loading. Please reload this page.

vstinner deleted the is_small_int branch

March 30, 2026 12:48

bedevere-app Bot removed the awaiting core review label

Mar 30, 2026

skirpichev reviewed

Mar 30, 2026

View reviewed changes

Comment thread

Objects/longobject.c

		#define medium_value(x) ((stwodigits)_PyLong_CompactValue(x))

		#define IS_SMALL_INT(ival) (-_PY_NSMALLNEGINTS <= (ival) && (ival) < _PY_NSMALLPOSINTS)
		#define IS_SMALL_INT(ival) _PY_IS_SMALL_INT(ival)

skirpichev Mar 30, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now looks redundant.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Mar 30, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, IS_SMALL_INT() is shorter and is used in multiple functions. IMO IS_SMALL_INT() is more readable than _PY_IS_SMALL_INT(), and it avoids changing the code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Python/flowgraph.c

		return -1;
		}
		if (!overflow && _PY_IS_SMALL_INT(val)) {
		if (!overflow && _PY_IS_SMALL_INT(val) && 0 <= val && val <= 255) {

skirpichev Mar 30, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

	if (!overflow && _PY_IS_SMALL_INT(val) && 0 <= val && val <= 255) {
	if (!overflow && _PY_IS_SMALL_INT(val) && 0 <= val && val < 256) {

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vstinner Mar 30, 2026

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that's the same, and I prefer <= 255 :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

maurycy added a commit to maurycy/cpython that referenced this pull request

Mar 30, 2026


          Merge remote-tracking branch 'upstream/main' into tachyon-ndjson-kole…

6a0ea81

…ktor

* upstream/main: (119 commits)
  pythongh-144270: Make SubElement parent and tag positional-only (pythonGH-144845)
  pythongh-146558: JIT optimize dict access for objects with known hash (python#146559)
  pythongh-139922: always run MSVC 64-bit tail-calling CI (pythonGH-146570)
  pythongh-126835: Fix _PY_IS_SMALL_INT() macro (python#146631)
  pythongh-146587: fix type slot assignment incase of multiple slots for same name (python#146593)
  pythongh-138122: Add differential flame graph (python#145785)
  pythongh-146416: Emscripten: Improve standard stream handling in node_entry.mjs (python#146417)
  pythongh-146444: Don't package as part of iOS 'build hosts' target (python#146628)
  pythongh-138850: Add --disable-epoll to configure (pythonGH-145768)
  pythongh-146444: Make Platforms/Apple/ compatible with Python 3.9 (python#146624)
  pythongh-138577: Fix keyboard shortcuts in getpass with echo_char (python#141597)
  pythongh-146556: Fix infinite loop in annotationlib.get_annotations() on circular __wrapped__ (python#146557)
  pythongh-146579: _zstd: Fix decompression options dict error message (python#146577)
  pythongh-146083: Upgrade bundled Expat to 2.7.5 (python#146085)
  pythongh-146080: fix a crash in SNI callbacks when the SSL object is gone (python#146573)
  pythongh-146090: fix memory management of internal `sqlite3` callback contexts (python#146569)
  pythongh-145876: Do not mask KeyErrors raised during dictionary unpacking in call (pythonGH-146472)
  pythongh-146004: fix test_args_from_interpreter_flags on windows (python#146580)
  pythongh-139003: Use frozenset for module level attributes in _pyrepl.utils (python#139004)
  pythonGH-146527: Add more data to GC statistics and add it to PyDebugOffsets (python#146532)
  ...

vstinner added the needs backport to 3.14 bugs and security fixes label

Mar 31, 2026

miss-islington-app Bot commented Mar 31, 2026

Copy link

Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot commented Mar 31, 2026

Copy link

Copy Markdown

GH-147187 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Mar 31, 2026

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Mar 31, 2026


          pythongh-126835: Fix _PY_IS_SMALL_INT() macro (pythonGH-146631)

1fd1eb5

(cherry picked from commit adf2c47)

Co-authored-by: Victor Stinner <[email protected]>

vstinner added a commit that referenced this pull request

Mar 31, 2026


          [3.14] gh-126835: Fix _PY_IS_SMALL_INT() macro (GH-146631) (#147187)

e387bac

gh-126835: Fix _PY_IS_SMALL_INT() macro (GH-146631)
(cherry picked from commit adf2c47)

Co-authored-by: Victor Stinner <[email protected]>

pablogsal mentioned this pull request

Apr 4, 2026

gh-130273: Fix traceback color output with unicode characters #142529

Merged

clin1234 pushed a commit to clin1234/cpython that referenced this pull request

Apr 16, 2026


          pythongh-126835: Fix _PY_IS_SMALL_INT() macro (python#146631)

aa04a23

ljfp pushed a commit to ljfp/cpython that referenced this pull request

Apr 25, 2026


          pythongh-126835: Fix _PY_IS_SMALL_INT() macro (python#146631)

2ccc9bb

Reviewers

skirpichev

skirpichev approved these changes

markshannon

Awaiting requested review from markshannon

markshannon is a code owner

iritkatriel

Awaiting requested review from iritkatriel

iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

vstinner commented Mar 30, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

skirpichev Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

vstinner Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

skirpichev Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

vstinner Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Mar 31, 2026

Uh oh!

bedevere-app Bot commented Mar 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vstinner commented Mar 30, 2026 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.