GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] bpo-29571: Use correct locale encoding in test_re (#149) by ncoghlan · Pull Request #153 · python/cpython

Conversation

@ncoghlan

@ncoghlan ncoghlan commented Feb 18, 2017

Copy link
Copy Markdown
Contributor

local.getlocale(locale.LC_CTYPE) and
locale.getpreferredencoding(False) may give different answers
in some cases (such as the en_IN locale).

re.LOCALE uses the latter, so update the test case to match.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ncoghlan
[3.6] bpo-29571: Use correct locale encoding in test_re (python#149)
0c66eb0 
``local.getlocale(locale.LC_CTYPE)`` and
``locale.getpreferredencoding(False)`` may give different answers
in some cases (such as the ``en_IN`` locale).

``re.LOCALE`` uses the latter, so update the test case to match.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 18, 2017
@ncoghlan ncoghlan mentioned this pull request Feb 18, 2017
Consider using a prefix in the title of backport PRs python/core-workflow#23
Closed
@ncoghlan ncoghlan added the cherry-pick for 3.6 label Feb 18, 2017
@ncoghlan ncoghlan mentioned this pull request Feb 18, 2017
bpo-29571: Use correct locale encoding in test_re #149
Merged
serhiy-storchaka
serhiy-storchaka approved these changes Feb 18, 2017
View reviewed changes
@serhiy-storchaka serhiy-storchaka added the tests Tests in the Lib/test dir label Feb 18, 2017
@ncoghlan
ncoghlan merged commit 0683d68 into python:3.6 Feb 19, 2017
@ncoghlan
ncoghlan deleted the bpo-29571-3.6-backport branch March 30, 2018 07:44
isidentical added a commit to isidentical/cpython that referenced this pull request Oct 25, 2021
@isidentical
Fix python#153
4813207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ncoghlan @serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.