GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29571: Use correct locale encoding in test_re by ncoghlan · Pull Request #149 · python/cpython

Conversation

@ncoghlan

@ncoghlan ncoghlan commented Feb 18, 2017

Copy link
Copy Markdown
Contributor

local.getlocale(locale.LC_CTYPE) and
locale.getpreferredencoding(False) may give different answers
in some cases (such as the en_IN locale).

re.LOCALE uses the latter, so update the test case to match.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka @ncoghlan
bpo-29571: Use correct locale encoding in test_re
617af67
``local.getlocale(locale.LC_CTYPE)`` and
``locale.getpreferredencoding(False)`` may give different answers
in some cases (such as the ``en_IN`` locale).

``re.LOCALE`` uses the latter, so update the test case to match.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 18, 2017
@serhiy-storchaka serhiy-storchaka added needs backport to 3.5 tests Tests in the Lib/test dir labels Feb 18, 2017
serhiy-storchaka
serhiy-storchaka approved these changes Feb 18, 2017
View reviewed changes
@ncoghlan
ncoghlan merged commit ace5c0f into python:master Feb 18, 2017
ncoghlan added a commit to ncoghlan/cpython that referenced this pull request Feb 18, 2017
@ncoghlan
[3.6] bpo-29571: Use correct locale encoding in test_re (python#149)
0c66eb0
``local.getlocale(locale.LC_CTYPE)`` and
``locale.getpreferredencoding(False)`` may give different answers
in some cases (such as the ``en_IN`` locale).

``re.LOCALE`` uses the latter, so update the test case to match.
ncoghlan added a commit to ncoghlan/cpython that referenced this pull request Feb 18, 2017
@ncoghlan
[3.5] bpo-29571: Use correct locale encoding in test_re (python#149)
114637d
``local.getlocale(locale.LC_CTYPE)`` and
``locale.getpreferredencoding(False)`` may give different answers
in some cases (such as the ``en_IN`` locale).

``re.LOCALE`` uses the latter, so update the test case to match.
@ncoghlan

ncoghlan commented Feb 18, 2017

Copy link
Copy Markdown
Contributor Author

Backport PRs:

  • [3.6] bpo-29571: Use correct locale encoding in test_re (#149) #153
  • [3.5] bpo-29571: Use correct locale encoding in test_re (#149) #154
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ncoghlan ncoghlan removed needs backport to 3.5 labels Feb 18, 2017
@ncoghlan ncoghlan mentioned this pull request Feb 18, 2017
Bot to automatically generate cherry-picking PRs python/core-workflow#8
Closed
ncoghlan added a commit that referenced this pull request Feb 19, 2017
@ncoghlan
[3.6] bpo-29571: Use correct locale encoding in test_re (#149) (#153)
0683d68
``local.getlocale(locale.LC_CTYPE)`` and
``locale.getpreferredencoding(False)`` may give different answers
in some cases (such as the ``en_IN`` locale).

``re.LOCALE`` uses the latter, so update the test case to match.
ncoghlan added a commit that referenced this pull request Feb 19, 2017
@ncoghlan
[3.5] bpo-29571: Use correct locale encoding in test_re (#149) (#154)
760f596
``local.getlocale(locale.LC_CTYPE)`` and
``locale.getpreferredencoding(False)`` may give different answers
in some cases (such as the ``en_IN`` locale).

``re.LOCALE`` uses the latter, so update the test case to match.
benjaminp added a commit that referenced this pull request Mar 8, 2017
@benjaminp
Revert "bpo-29571: Use correct locale encoding in test_re (#149)"
270a1e6
This reverts commit ace5c0f.
benjaminp added a commit that referenced this pull request Mar 8, 2017
@benjaminp
Revert "bpo-29571: Use correct locale encoding in test_re (#149)" (#554)
21a7431
This reverts commit ace5c0f.
benjaminp added a commit that referenced this pull request Mar 8, 2017
@benjaminp
Revert "bpo-29571: Use correct locale encoding in test_re (#149)" (#554)
65ad8d5
This reverts commit ace5c0f.
benjaminp added a commit that referenced this pull request Mar 8, 2017
@benjaminp
Revert "bpo-29571: Use correct locale encoding in test_re (#149)" (#554)
604b94d
This reverts commit ace5c0f.
benjaminp added a commit that referenced this pull request Mar 8, 2017
@benjaminp
Revert "bpo-29571: Use correct locale encoding in test_re (#149)" (#554…
312f7df
…) (#556)

This reverts commit ace5c0f.
benjaminp added a commit that referenced this pull request Mar 8, 2017
@benjaminp
Revert "bpo-29571: Use correct locale encoding in test_re (#149)" (#554…
6a4b04c
…) (#555)

This reverts commit ace5c0f.
akruis pushed a commit to akruis/cpython that referenced this pull request Mar 25, 2018
Anselm Kruis
Stackless issue python#149: Remove support for threads-less builds
84d8329
Implement bpo-31370 for Stackless C-source.
akruis pushed a commit to akruis/cpython that referenced this pull request Mar 25, 2018
Anselm Kruis
Stackless issue python#149: Consolidate stateful runtime globals.
1f73cae
bpo-30860 consolidates global variables. This requires minor changes in
Stackless header files. Now Stackless compiles.
We still need to consolidate Stackless specific global variables.
@ncoghlan
ncoghlan deleted the bpo-29571-spurious-test-re-failure branch March 30, 2018 07:44
akruis added a commit to akruis/cpython that referenced this pull request Oct 14, 2018
@akruis
Stackless issue python#149: Move exc state from thread to tasklet
245a802
bpo-25612 (python#1773) moves the exception state information from frame
object to coroutine (generator/thread) object where it belongs.
As a consequence Stackless moves the exception state information for
non-current tasklets from thread-state to the tasklet. This changes the
pickle format of frame, tasklet and generator objects.
The commit adds three test cases.
akruis added a commit to akruis/cpython that referenced this pull request Nov 20, 2018
@akruis
Stackless issue python#149: Bump Stackless version to "3.7"
ff1296d
akruis added a commit to akruis/cpython that referenced this pull request Nov 22, 2018
@akruis
Stackless issue python#149: Add historic release dates to our changelog.
6d32077
akruis added a commit to akruis/cpython that referenced this pull request Dec 29, 2018
@akruis
Stackless issue python#149: Fix exc state handling during tasklet dea…
cb1c4ea
…llocation

Fix a few incorrect assertions introduced by commit 245a802.
A test in the upcoming commit for Stackless issue python#190 triggered an
assertion failure.
akruis added a commit to akruis/cpython that referenced this pull request Jan 5, 2019
@akruis
Stackless issue python#149: update SLP documentation authors.
71b1e9c
Add my name to the list of authors.
@tirkarthi tirkarthi mentioned this pull request Feb 28, 2019
bpo-29571: Fix test_re.test_locale_flag() #12099
Merged
isidentical pushed a commit to isidentical/cpython that referenced this pull request Oct 10, 2021
@FFY00 @pablogsal
pegen: fold f-string constants and fix string concatenation (python#149)
04ec02a
This patch folds the f-string constants like they were previously (1),
and makes string concatenation construct a Constant instead of JoinedStr
(2).

1) `f'hello' f'hello'` will now construct
JoinedStr(values=[Constant(value='hellohello')])

2) `'hello' 'hello'` will now construct Constant(value='hellohello')

Co-authored-by: Pablo Galindo Salgado <[email protected]>
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @Mariatta
Update pytest from 3.7.4 to 3.8.0 (#149)
85c6a4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ncoghlan @serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.