GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-154275: Do not crash on deeply nested `__parameters__` in `GenericAlias` by sobolevn · Pull Request #154277 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Jul 20, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: _Py_make_parameters recurses without a guard: a self-referential/deeply-nested generic-alias arg crashes the interpreter #154275

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-154275: Do not crash on deeply nested __parameters__ in `G…
082b7f6 
…enericAlias`
@sobolevn
sobolevn requested review from AlexWaygood and JelleZijlstra as code owners July 20, 2026 17:17
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 20, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 20, 2026
_Py_make_parameters recurses without a guard: a self-referential/deeply-nested generic-alias arg crashes the interpreter #154275
Closed
@sobolevn sobolevn added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jul 20, 2026
JelleZijlstra
JelleZijlstra approved these changes Jul 20, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 20, 2026
@sobolevn
sobolevn merged commit 1034e07 into python:main Jul 20, 2026
110 of 112 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 20, 2026

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 20, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 20, 2026

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1034e07b7d55642c3a46252e6b0a631c2df588d2 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned sobolevn Jul 20, 2026
@bedevere-app

bedevere-app Bot commented Jul 20, 2026

Copy link
Copy Markdown

GH-154306 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jul 20, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 20, 2026

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1034e07b7d55642c3a46252e6b0a631c2df588d2 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn added a commit that referenced this pull request Jul 20, 2026
@miss-islington @sobolevn
[3.15] gh-154275: Do not crash on deeply nested __parameters__ in `…
d1494f0 
…GenericAlias` (GH-154277) (#154306)

gh-154275: Do not crash on deeply nested `__parameters__` in `GenericAlias` (GH-154277)
(cherry picked from commit 1034e07)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 21, 2026

Copy link
Copy Markdown

GH-154339 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 21, 2026
sobolevn added a commit that referenced this pull request Jul 21, 2026
@sobolevn
[3.14] gh-154275: Do not crash on deeply nested __parameters__ in `…
40657ad 
…GenericAlias` (GH-154277) (#154339)

(cherry picked from commit 1034e07)
@bedevere-app

bedevere-app Bot commented Jul 21, 2026

Copy link
Copy Markdown

GH-154340 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 21, 2026
@sobolevn sobolevn mentioned this pull request Jul 21, 2026
gh-154275: Fix cleanup code in _Py_make_parameters #154341
Merged
sobolevn added a commit that referenced this pull request Jul 21, 2026
@sobolevn
[3.13] gh-154275: Do not crash on deeply nested __parameters__ in `…
0942455 
…GenericAlias` (GH-154277) (#154340)

* [3.13] gh-154275: Do not crash on deeply nested `__parameters__` in `GenericAlias` (GH-154277)
(cherry picked from commit 1034e07)

Co-authored-by: sobolevn <[email protected]>
@kulikjak kulikjak mentioned this pull request Aug 3, 2026
skip_if_huge_c_stack underestimates available C recursion depth #155109
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sobolevn sobolevn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sobolevn @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.