GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-154275: Fix cleanup code in `_Py_make_parameters` by sobolevn · Pull Request #154341 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Jul 21, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a correct version of #154277
I missed two cleanup cases 🙈

  • Issue: _Py_make_parameters recurses without a guard: a self-referential/deeply-nested generic-alias arg crashes the interpreter #154275

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-154275: Fix cleanup code in _Py_make_parameters
d8ded0e
@bedevere-app bedevere-app Bot mentioned this pull request Jul 21, 2026
_Py_make_parameters recurses without a guard: a self-referential/deeply-nested generic-alias arg crashes the interpreter #154275
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 21, 2026
@sobolevn sobolevn added skip news needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Jul 21, 2026
@sobolevn

sobolevn commented Jul 21, 2026

Copy link
Copy Markdown
Member Author

3.13 backport of the original PR #154340 is already fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
sobolevn enabled auto-merge (squash) July 21, 2026 10:19
@sobolevn
sobolevn merged commit 196e16d into python:main Jul 21, 2026
58 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jul 21, 2026

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Jul 21, 2026
@bedevere-app

bedevere-app Bot commented Jul 21, 2026

Copy link
Copy Markdown

GH-154342 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Jul 21, 2026
@bedevere-app

bedevere-app Bot commented Jul 21, 2026

Copy link
Copy Markdown

GH-154343 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 21, 2026
sobolevn added a commit that referenced this pull request Jul 21, 2026
@miss-islington @sobolevn
[3.14] gh-154275: Fix cleanup code in _Py_make_parameters (GH-154341)…
e1eb9e8 
… (#154343)

gh-154275: Fix cleanup code in `_Py_make_parameters` (GH-154341)
(cherry picked from commit 196e16d)

Co-authored-by: sobolevn <[email protected]>
sobolevn added a commit that referenced this pull request Jul 21, 2026
@miss-islington @sobolevn
[3.15] gh-154275: Fix cleanup code in _Py_make_parameters (GH-154341)…
b3e046c 
… (#154342)

gh-154275: Fix cleanup code in `_Py_make_parameters` (GH-154341)
(cherry picked from commit 196e16d)

Co-authored-by: sobolevn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.