GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-64660: Do not hardcode the name of the returned variable by serhiy-storchaka · Pull Request #155268 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 6, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

data.return_value keeps its meaning -- the variable which receives the value returned by the impl, which declare() and custom return converters repoint. The name of the variable returned by the parsing function is now available as data.parser_retval, so that return converters no longer need to hardcode it.

The return converters in PC/msvcrtmodule.c are updated as well; wchar_t_return_converter hardcoded both names.

The generated code is not changed.

  • Issue: Argument Clinic included return converters hard code use of _return_value #64660

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-64660: Do not hardcode the name of the returned variable
85e6e61 
Return converters had to hardcode "return_value", because declare() sets
data.return_value to the variable which receives the value returned by
the impl.  The name of the variable returned by the parsing function is
now available as data.parser_retval.
@serhiy-storchaka
serhiy-storchaka requested review from a team, AA-Turner and erlend-aasland as code owners August 6, 2026 08:45
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 6, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 6, 2026
Argument Clinic included return converters hard code use of _return_value #64660
Closed
@serhiy-storchaka
serhiy-storchaka merged commit 99b8847 into python:main Aug 13, 2026
64 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Aug 13, 2026
@serhiy-storchaka
serhiy-storchaka deleted the clinic-retval branch August 13, 2026 09:57
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
@serhiy-storchaka @mbeijen
pythongh-64660: Do not hardcode the name of the returned variable (py…
9198cce 
…thonGH-155268)

Return converters had to hardcode "return_value", because declare() sets
data.return_value to the variable which receives the value returned by
the impl.  The name of the variable returned by the parsing function is
now available as data.parser_retval.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.