Description

brettcannon

opened on Jan 31, 2014

Issue body actions

BPO	20461
Nosy	@larryhastings

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/larryhastings'
closed_at = None
created_at = <Date 2014-01-31.17:28:47.030>
labels = ['build', 'expert-argument-clinic']
title = 'Argument Clinic included return converters hard code use of ``_return_value``'
updated_at = <Date 2020-03-18.18:40:11.018>
user = 'https://github.com/brettcannon'

bugs.python.org fields:

activity = <Date 2020-03-18.18:40:11.018>
actor = 'brett.cannon'
assignee = 'larry'
closed = False
closed_date = None
closer = None
components = ['Build', 'Argument Clinic']
creation = <Date 2014-01-31.17:28:47.030>
creator = 'brett.cannon'
dependencies = []
files = []
hgrepos = []
issue_num = 20461
keywords = []
message_count = 1.0
messages = ['209808']
nosy_count = 1.0
nosy_names = ['larry']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'test needed'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue20461'
versions = ['Python 3.4']

Linked PRs

• gh-64660: Don't hardcode Argument Clinic return converter result variable name #104200
• gh-64660: Do not hardcode the name of the returned variable #155268

Activity

1. brettcannon commented on Jan 31, 2014

   

   brettcannon

   on Jan 31, 2014

   MemberAuthor

   More actions

   E.g. NoneType_return_converter assumes _return_value is used in render() although CReturnConverter.declare() stores it in data.return_value and it's a parameter to render().
2. brettcannon

   assigned

   larryhastings

   on Jan 31, 2014
3. brettcannon

   added

   buildThe build process and cross-buildThe build process and cross-build

   on Jan 31, 2014
4. serhiy-storchaka

   added

   topic-argument-clinic

   on Feb 25, 2015
5. ezio-melotti

   transferred this issue fromon Apr 10, 2022
6. erlend-aasland

   added 2 commits that reference this issue on May 5, 2023

   pythongh-64660: Don't hard-code '_return_value' in AC return converters

   acfdab7

   pythongh-64660: Don't hardcode Argument Clinic return converter resul…

   de9dc35
7. erlend-aasland commented on May 5, 2023

   

   erlend-aasland

   on May 5, 2023

   Contributor

   More actions

   See gh-104200 for an improvement. There's still stuff to be done, IMO. For example, return_converter (no underscore prefix!) is also hardcoded several places. There's also the hack mentioned by Brett in the OP.
8. erlend-aasland

   added a commit that references this issue on May 7, 2023

   gh-64660: Don't hardcode Argument Clinic return converter result vari…

   ac02062
9. jbower-fb

   added a commit that references this issue on May 8, 2023

   pythongh-64660: Don't hardcode Argument Clinic return converter resul…

   67b4b55
10. carljm

    added a commit that references this issue on May 9, 2023

    Merge branch 'main' into inlinecomp2

    76077cd
11. serhiy-storchaka

    added a commit that references this issue on Aug 13, 2026

    gh-64660: Do not hardcode the name of the returned variable (GH-155268)

    99b8847
12. serhiy-storchaka

    closed this as completedon Aug 13, 2026
13. mbeijen

    added a commit that references this issue on Aug 14, 2026

    pythongh-64660: Do not hardcode the name of the returned variable (py…

    9198cce

Issue actions