GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||
GeezerVison is showing github.com — gh-156774: Speed up pdb startup with asyncio guard by brittanyrey · Pull Request #156775 · python/cpython Conversation
|
| Benchmark | asyncio guard |
|---|---|
import pdb |
-28.8% |
breakpoint() → continue |
-28.5% |
python -m pdb script |
-26.0% |
| pdb post-mortem | -24.6% |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Defer the eight imports that are not already pulled in by pdb's required-eager imports (cmd, bdb, code, typing and the guarded _pyrepl.utils), and lift five unguarded function-level imports to module-scope lazy imports. Guard Pdb._get_asyncio_task() on 'asyncio' in sys.modules. It runs on every interaction(), so without the guard the deferred asyncio import is paid back immediately on the first breakpoint and the lazy import buys nothing for an actual debugging session. If asyncio was never imported there cannot be a running task, so returning None is equivalent. The guarded imports (readline, rlcompleter, _pyrepl) stay function-level: they sit in try/except ImportError blocks, and hoisting them would move the failure outside the guard. import pdb -42.1% breakpoint() -> cont -41.1% python -m pdb script -33.4% pdb post-mortem -33.3%
|
See #156567 for the lazy imports, your review welcome! I was planning on doing the asyncio guard as a followup :) Shall we reduce this PR to just that? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry about that! I did a peek over the lazy imports label & missed your issue! I'm glad to scope this down to just the asyncio gated change. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Drop the other lazy imports and the lifted function-level imports, leaving just the asyncio deferral and the _get_asyncio_task() guard. Those two carry most of the win and keep the diff to five lines. import pdb -28.8% (was -42.1% with the full set) breakpoint() -> cont -28.5% python -m pdb script -26.0% pdb post-mortem -24.6%
|
PR + issue are fully rescoped @hugovk |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
* main: (158 commits) pythongh-156924: Try reifying lazy imports in `ForwarRef.evaluate()` (python#156940) pythongh-156233: Fix typos and code snippet errors in the docs (python#156475) pythongh-156837: Refer to yield expressions in generator function definitions (pythonGH-156863) pythongh-155292: Skip updating unicodedata with mismatched interpreter (pythonGH-157066) pythongh-157170: Document the scope of global curses settings (pythonGH-157207) pythongh-155966: Correct handling of `math.tanpi` poles (python#155980) pythongh-157170: Restore use_env() after test_use_prescr_screen in test_curses (pythonGH-157171) pythongh-156910: fix deadlock in type_set_abstractmethods under free-threading (python#156948) pythongh-155648: Write the empty and placeholder IDLE tests (python#156260) pythongh-153569: centralize formatted-string state and source spans (python#156484) pythongh-157137: Mark the PEP 820 soft deprecations as 3.15, not `next` (python#157138) pythongh-152433: Use regular LoadLibrary in UWP for Windows system libs (pythonGH-156972) pythongh-121617: Fix Py_CLEAR() memcpy in C++: replace NULL with _Py_NULL (python#157188) pythongh-157135: Fix documentation errors in the `math.atan{2}pi` functions (python#157136) pythongh-121617: Fix Py_CLEAR() in C++: replace NULL with _Py_NULL (python#157067) pythongh-156774: Speed up pdb startup with asyncio guard (python#156775) pythongh-156109: Allow static, non-framework iOS builds (python#156110) pythongh-156780: Emscripten: add missing EM_JS_DEPS (python#156798) pythongh-152936: Make privileged functions available on Android (python#152977) pythongh-123018: Keep the libedit history file header when truncating (pythonGH-157165) ...
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.