GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-157135: Fix documentation errors in the half-turn `*pi` functions by fedonman · Pull Request #157136 · python/cpython

Conversation

@fedonman

@fedonman fedonman commented Sep 7, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

atanpi's docstring gave acospi's result range, the trigonometric summary table in Doc/library/math.rst described atan2pi with atan's formula, and the comments above m_atanpi and m_atan2pi both read asin(x)/pi. This corrects the four statements to say what the functions compute.

No changelog entry: these functions have not been released.

  • Issue: Documentation errors in the new half-turn *pi functions #157135

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@fedonman
pythongh-157135: Fix documentation errors in the half-turn *pi func…
a27a4ba
…tions

atanpi's docstring gave acospi's result range, the trigonometric
summary table described atan2pi with atan's formula, and the
comments above m_atanpi and m_atan2pi both read asin(x)/pi.
@bedevere-app bedevere-app Bot mentioned this pull request Sep 7, 2026
Documentation errors in the new half-turn *pi functions #157135
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Sep 7, 2026
@read-the-docs-community

read-the-docs-community Bot commented Sep 7, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #34439309 | 📁 Comparing a27a4ba against main (23180c5)

  🔍 Preview build  

1 file changed
± library/math.html
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

skirpichev
skirpichev approved these changes Sep 8, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 8, 2026
@skirpichev skirpichev added the skip news label Sep 8, 2026
@skirpichev

skirpichev commented Sep 8, 2026

Copy link
Copy Markdown
Member

No changelog entry: these functions have not been released.

We usually don't create news entries for docs-only changes.

StanFromIreland and fedonman reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StanFromIreland
StanFromIreland approved these changes Sep 8, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 8, 2026
@StanFromIreland
StanFromIreland merged commit 7f3d7d0 into python:main Sep 8, 2026
66 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 8, 2026
@StanFromIreland

StanFromIreland commented Sep 8, 2026

Copy link
Copy Markdown
Member

Merged, thanks for the fix. This doesn't have to be backported because IIRC these were added recently, right @skirpichev ?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@skirpichev

skirpichev commented Sep 8, 2026

Copy link
Copy Markdown
Member

This doesn't have to be backported because IIRC these were added recently

Yes, it's only in 3.16: https://docs.python.org/3.16/whatsnew/3.16.html#math

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

maurycy added a commit to maurycy/cpython that referenced this pull request Sep 10, 2026
@maurycy
Merge branch 'main' into tachyon-native-callable
e028ff5
* main: (158 commits)
  pythongh-156924: Try reifying lazy imports in `ForwarRef.evaluate()` (python#156940)
  pythongh-156233: Fix typos and code snippet errors in the docs (python#156475)
  pythongh-156837: Refer to yield expressions in generator function definitions (pythonGH-156863)
  pythongh-155292: Skip updating unicodedata with mismatched interpreter (pythonGH-157066)
  pythongh-157170: Document the scope of global curses settings (pythonGH-157207)
  pythongh-155966: Correct handling of `math.tanpi` poles (python#155980)
  pythongh-157170: Restore use_env() after test_use_prescr_screen in test_curses (pythonGH-157171)
  pythongh-156910: fix deadlock in type_set_abstractmethods under free-threading (python#156948)
  pythongh-155648: Write the empty and placeholder IDLE tests (python#156260)
  pythongh-153569: centralize formatted-string state and source spans (python#156484)
  pythongh-157137: Mark the PEP 820 soft deprecations as 3.15, not `next` (python#157138)
  pythongh-152433: Use regular LoadLibrary in UWP for Windows system libs (pythonGH-156972)
  pythongh-121617: Fix Py_CLEAR() memcpy in C++: replace NULL with _Py_NULL (python#157188)
  pythongh-157135: Fix documentation errors in the `math.atan{2}pi` functions (python#157136)
  pythongh-121617: Fix Py_CLEAR() in C++: replace NULL with _Py_NULL (python#157067)
  pythongh-156774: Speed up pdb startup with asyncio guard (python#156775)
  pythongh-156109: Allow static, non-framework iOS builds (python#156110)
  pythongh-156780: Emscripten: add missing EM_JS_DEPS (python#156798)
  pythongh-152936: Make privileged functions available on Android (python#152977)
  pythongh-123018: Keep the libedit history file header when truncating (pythonGH-157165)
  ...
clin1234 pushed a commit to clin1234/cpython that referenced this pull request Sep 12, 2026
@fedonman @clin1234
pythongh-157135: Fix documentation errors in the math.atan{2}pi fun…
fa348d3
…ctions (python#157136)
johnslavik pushed a commit to johnslavik/cpython that referenced this pull request Sep 14, 2026
@fedonman @johnslavik
pythongh-157135: Fix documentation errors in the math.atan{2}pi fun…
0afff53
…ctions (python#157136)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@fedonman @skirpichev @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.