GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.15] gh-63882: Implement empty tests in test_minidom (GH-156677) by miss-islington · Pull Request #157428 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 13, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

25 tests were defined as "def testX(self): pass" and reported success
without testing anything.
(cherry picked from commit f154574)

Co-authored-by: Serhiy Storchaka [email protected]

  • Issue: test_minidom has many empty tests #63882

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @miss-islington
pythongh-63882: Implement empty tests in test_minidom (pythonGH-156677)
8a95cb4 
25 tests were defined as "def testX(self): pass" and reported success
without testing anything.
(cherry picked from commit f154574)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Sep 13, 2026
test_minidom has many empty tests #63882
Closed
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Sep 13, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 13, 2026
gh-63882: Implement empty tests in test_minidom #156677
Merged
@bedevere-app bedevere-app Bot added the skip news label Sep 13, 2026
@serhiy-storchaka
Do not test Attr.specified, which is only set in 3.16
ef49149
@hugovk
hugovk merged commit 04347ef into python:3.15 Sep 15, 2026
51 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 15, 2026
@miss-islington
miss-islington deleted the backport-f154574-3.15 branch September 15, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @hugovk @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.