GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-63882: Implement empty tests in test_minidom by serhiy-storchaka · Pull Request #156677 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 30, 2026 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The 25 tests defined as def testX(self): pass now test NamedNodeMap methods, the factory methods for namespaced nodes, parsing of elements, attributes, namespaces and processing instructions, and the traversal attributes.

testParse and testParseProcessingInstructions are limited to what is not already covered by testParseFromBinaryFile, testParseFromTextFile and testProcessingInstruction.

This makes PR #128948, which comments these tests out, unnecessary.

  • Issue: test_minidom has many empty tests #63882

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-63882: Implement empty tests in test_minidom
337ae51 
25 tests were defined as "def testX(self): pass" and reported success
without testing anything.
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Aug 30, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Aug 30, 2026
test_minidom has many empty tests #63882
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Aug 30, 2026
gh-63882: Comment out empty test_minidom tests #128948
Closed
@aisk aisk added the skip news label Aug 31, 2026
@serhiy-storchaka
serhiy-storchaka merged commit f154574 into python:main Sep 13, 2026
54 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the gh-63882-empty-tests branch September 13, 2026 12:53
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 13, 2026
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Sep 13, 2026
@miss-islington-app

miss-islington-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

GH-157426 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 13, 2026
@bedevere-app

bedevere-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

GH-157427 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 13, 2026
@bedevere-app

bedevere-app Bot commented Sep 13, 2026

Copy link
Copy Markdown

GH-157428 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Sep 13, 2026
johnslavik pushed a commit to johnslavik/cpython that referenced this pull request Sep 14, 2026
@serhiy-storchaka @johnslavik
pythongh-63882: Implement empty tests in test_minidom (pythonGH-156677)
b30ff9c 
25 tests were defined as "def testX(self): pass" and reported success
without testing anything.
serhiy-storchaka added a commit that referenced this pull request Sep 14, 2026
@miss-islington @serhiy-storchaka
[3.13] gh-63882: Implement empty tests in test_minidom (GH-156677) (G…
c698c63 
…H-157427)

25 tests were defined as "def testX(self): pass" and reported success
without testing anything.
(cherry picked from commit f154574)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Sep 14, 2026
@miss-islington @serhiy-storchaka
[3.14] gh-63882: Implement empty tests in test_minidom (GH-156677) (G…
a4f6216 
…H-157426)

25 tests were defined as "def testX(self): pass" and reported success
without testing anything.
(cherry picked from commit f154574)

Co-authored-by: Serhiy Storchaka <[email protected]>
hugovk pushed a commit that referenced this pull request Sep 15, 2026
@miss-islington @serhiy-storchaka
[3.15] gh-63882: Implement empty tests in test_minidom (GH-156677) (#…
04347ef 
…157428)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @aisk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.