GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-159811: Raise OpenSSL errors in `_hashlib.HASH` after re-attaching the thread state by picnixz · Pull Request #159817 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Oct 19, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

_hashlib_HASH_hash() set an exception when EVP_DigestUpdate() failed, but it is called inside a GIL-released region by _hashlib.HASH.update() and by the _hashlib.HASH constructor when the data exceeds HASHLIB_GIL_MINSIZE bytes. Setting the exception with the thread state detached crashes the interpreter instead of raising a ValueError.

Only report the failure in _hashlib_HASH_hash() and set the exception in its callers once the thread state is re-attached. The OpenSSL error queue is per thread, so the exception message is unaffected.

The _hashlib.HMAC counterpart is handled in #159818 as it only affects 3.15 and later, whereas this one should be backported to 3.13 and 3.14 as well.

  • Issue: _hashlib: GIL may be released while attempting to set an exception #159811

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
pythongh-159811: Raise OpenSSL errors in _hashlib.HASH after re-att…
5624624 
…aching the thread state

`_hashlib_HASH_hash()` set an exception when EVP_DigestUpdate() failed,
but it is called inside a GIL-released region by `_hashlib.HASH.update()`
and by the `_hashlib.HASH` constructor when the data exceeds
HASHLIB_GIL_MINSIZE bytes. Setting the exception with the thread state
detached crashed the interpreter instead of raising a ValueError.

Only report the failure in `_hashlib_HASH_hash()` and set the exception
in its callers once the thread state is re-attached. The OpenSSL error
queue is per thread, so the exception message is unaffected.
@picnixz
picnixz requested a review from gpshead as a code owner October 19, 2026 23:59
@bedevere-app bedevere-app Bot mentioned this pull request Oct 19, 2026
_hashlib: GIL may be released while attempting to set an exception #159811
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 19, 2026
@picnixz picnixz mentioned this pull request Oct 19, 2026
gh-159811: Raise OpenSSL errors in _hashlib.HMAC after re-attaching the thread state #159818
Merged
@picnixz picnixz added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes sprint labels Oct 20, 2026
@github-project-automation github-project-automation Bot added this to Sprint Oct 20, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Sprint Oct 20, 2026
@picnixz picnixz self-assigned this Oct 20, 2026
@picnixz
picnixz merged commit 6fa2d64 into python:main Oct 20, 2026
64 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 20, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in Sprint Oct 20, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

Sorry, @picnixz, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 6fa2d645ea57120d1cbf38b45fc8ee2b5019090b 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

GH-159927 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 20, 2026
@bedevere-app

bedevere-app Bot commented Oct 20, 2026

Copy link
Copy Markdown

GH-159937 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 20, 2026
@picnixz
picnixz deleted the meta/crypto/c/hashlib/32/hash-gil-issue-159811 branch October 20, 2026 18:09
picnixz added a commit that referenced this pull request Oct 20, 2026
@picnixz
[3.14] gh-159811: Raise OpenSSL errors in _hashlib.HASH after re-at…
5eed22f 
…taching the thread state (GH-159817) (#159937)

When `EVP_DigestUpdate()` failed, `_hashlib_HASH_hash()` raised a Python
exception, however, `_hashlib.HASH.update()` and the `_hashlib.HASH`
constructor release the GIL before calling it when the data is larger
than `HASHLIB_GIL_MINSIZE` bytes.

`_hashlib_HASH_hash()` now only returns an error status and its callers
raise the exception once they have re-attached the thread state.

(cherry picked from commit 6fa2d64)
picnixz added a commit that referenced this pull request Oct 20, 2026
@miss-islington @picnixz
[3.15] gh-159811: Raise OpenSSL errors in _hashlib.HASH after re-at…
0405f10 
…taching the thread state (GH-159817) (#159927)

gh-159811: Raise OpenSSL errors in `_hashlib.HASH` after re-attaching the thread state (GH-159817)

When `EVP_DigestUpdate()` failed, `_hashlib_HASH_hash()` raised a Python
exception, however, `_hashlib.HASH.update()` and the `_hashlib.HASH`
constructor release the GIL before calling it when the data is larger
than `HASHLIB_GIL_MINSIZE` bytes.

`_hashlib_HASH_hash()` now only returns an error status and its callers
raise the exception once they have re-attached the thread state.

(cherry picked from commit 6fa2d64)

Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@picnixz picnixz

Labels

sprint

Projects

Sprint
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.