GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-38122: minor fixes to AsyncMock spec handling (GH-16099). by matrixise · Pull Request #16137 · python/cpython

Conversation

@matrixise

@matrixise matrixise commented Sep 14, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 14fd925)

Co-authored-by: Michael Foord [email protected]

https://bugs.python.org/issue38122

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@voidspace @matrixise
[3.8] bpo-38122: minor fixes to AsyncMock spec handling (pythonGH-16099…
301d852 
…).

(cherry picked from commit 14fd925)

Co-authored-by: Michael Foord <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 14, 2019
@bedevere-bot bedevere-bot mentioned this pull request Sep 14, 2019
bpo-38122: minor fixes to AsyncMock spec handling #16099
Merged
@bedevere-bot bedevere-bot added skip news awaiting core review labels Sep 14, 2019
@matrixise matrixise assigned voidspace Sep 14, 2019
@matrixise

matrixise commented Sep 14, 2019

Copy link
Copy Markdown
Member Author

Hi @voidspace

There is problem with the #14700 because that one has not been backported to 3. and your code use _AnyComparer. I try to find the right solution with @pganssle
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@matrixise matrixise self-assigned this Sep 14, 2019
@matrixise
Remove unused _AnyComparer class
6fa0593
@matrixise

matrixise commented Sep 14, 2019

Copy link
Copy Markdown
Member Author

@voidspace _AnyComparer is specific to master, not backported to 3.8, so, I have removed that class from your PR and run the tests. wait & see.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@matrixise
matrixise requested a review from lisroach September 26, 2019 09:00
lisroach
lisroach approved these changes Sep 27, 2019
View reviewed changes

@lisroach lisroach left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 27, 2019
@tirkarthi

tirkarthi commented Oct 10, 2019

Copy link
Copy Markdown
Member

Seems this missed the RC build :( It more looks like a code refactor. If I understand it correctly in previous case there was list comprehension over arguments starting with "spec" to take first argument and perhaps depending on the order they are passed. Now with PR it checks for spec_set and falls back to spec making the choice predictable to detect. I guess it could cause problem if someone depends on the order in 3.8 RC or 3.8.0 and upgrades to 3.8.1 as it's merged later. Also there is a removed comment about what to do when spec_set and spec are different so could it be tested to ensure this choice is explicit?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@matrixise

matrixise commented Feb 17, 2020

Copy link
Copy Markdown
Member Author

I worked on this issue in september but 3.8 has been released in october, do you think we could merge it into 3.8?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csabella

csabella commented May 27, 2020

Copy link
Copy Markdown
Contributor

@matrixise, should this change still be backported to 3.8? Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@matrixise

matrixise commented May 27, 2020

Copy link
Copy Markdown
Member Author

@csabella for this PR, yep, I think we should backport it to 3.8.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tirkarthi tirkarthi mentioned this pull request Dec 7, 2020
bpo-42532: Check if NonCallableMock's spec_arg is not None instead of call its __bool__ function #23613
Merged
@ambv

ambv commented Apr 26, 2021

Copy link
Copy Markdown
Contributor

Sorry, closing this stale backport as 3.8 is closing to security fixes only mode.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv closed this Apr 26, 2021
@lisroach lisroach mentioned this pull request Apr 10, 2022
AsyncMock force always creating an AsyncMock for child mocks #82303
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lisroach lisroach lisroach approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@matrixise matrixise

@voidspace voidspace

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@matrixise @tirkarthi @csabella @ambv @lisroach @voidspace @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.