GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38122: minor fixes to AsyncMock spec handling by voidspace · Pull Request #16099 · python/cpython

Conversation

@voidspace

@voidspace voidspace commented Sep 13, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Simplification of the spec handling for AsyncMock and correction for how spec_set is handled.

https://bugs.python.org/issue38122

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
voidspace added 6 commits September 11, 2019 16:08
@voidspace
Port tests from original PR
917d722
@voidspace
Port tests from original PR
890795e
@voidspace
Merge branch 'spec-signatures' of https://github.com/voidspace/cpython …
cfb1bb8 
…into spec-signatures
@voidspace
Minor fixes
9f8a081
@voidspace
Remove extraneous tests
327b33c
@voidspace
Remove extraneous test
6f058d9
@the-knights-who-say-ni

the-knights-who-say-ni commented Sep 13, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@voidspace

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Sep 13, 2019
@bedevere-bot bedevere-bot added the awaiting core review label Sep 13, 2019
@voidspace
voidspace requested a review from lisroach September 13, 2019 13:15
@voidspace voidspace added needs backport to 3.8 skip news labels Sep 13, 2019
lisroach
lisroach approved these changes Sep 13, 2019
View reviewed changes

@lisroach lisroach left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 13, 2019
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Sep 13, 2019
@matrixise matrixise changed the title bpo-38122 minor fixes to AsyncMock spec handling bpo-38122: minor fixes to AsyncMock spec handling Sep 13, 2019
voidspace and others added 2 commits September 13, 2019 18:03
@voidspace
Merge branch 'master' into minor-fixes
8c2ab3b
@matrixise
Fix whitespace
fbc12ef
@matrixise
matrixise merged commit 14fd925 into python:master Sep 13, 2019
@miss-islington

miss-islington commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

Thanks @voidspace for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 13, 2019
@miss-islington

miss-islington commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

Sorry, @voidspace and @matrixise, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 14fd925a18fe3db0922a7d798e373102fe7a8a9c 3.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned matrixise Sep 13, 2019
@matrixise

matrixise commented Sep 14, 2019

Copy link
Copy Markdown
Member

@voidspace Could you work on the backport for 3.8? Thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
matrixise pushed a commit to matrixise/cpython that referenced this pull request Sep 14, 2019
@voidspace @matrixise
[3.8] bpo-38122: minor fixes to AsyncMock spec handling (pythonGH-16099…
301d852 
…).

(cherry picked from commit 14fd925)

Co-authored-by: Michael Foord <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 14, 2019

Copy link
Copy Markdown

GH-16137 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Sep 14, 2019
@matrixise

matrixise commented Sep 14, 2019

Copy link
Copy Markdown
Member

@voidspace I have created a PR with the backport, but I would like to get your approval.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tirkarthi tirkarthi mentioned this pull request Dec 7, 2020
bpo-42532: Check if NonCallableMock's spec_arg is not None instead of call its __bool__ function #23613
Merged
@cjw296

cjw296 commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

@voidspace: curious as to why these ended up having no tests committed as part of this PR. It's unclear whether https://bugs.python.org/issue38122 is just refactoring or a change in behaviour. If it's the latter, I'd have hoped for some additional tests to verify this...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lisroach lisroach mentioned this pull request Apr 10, 2022
AsyncMock force always creating an AsyncMock for child mocks #82303
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lisroach lisroach lisroach approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@matrixise matrixise

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@voidspace @the-knights-who-say-ni @miss-islington @matrixise @bedevere-bot @cjw296 @lisroach
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.