GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42532: Check if NonCallableMock's spec_arg is not None instead of call its __bool__ function by idanw206 · Pull Request #23613 · python/cpython

Conversation

@idanw206

@idanw206 idanw206 commented Dec 2, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue42532

If an object has logic in its __bool__ function, it'll be called here, but it shouldn't be called.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Idan Weiss
Check if NonCallableMock's spec_arg is not None instead of call its _…
1bc3518 
…_bool__ function
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Dec 2, 2020
@the-knights-who-say-ni

the-knights-who-say-ni commented Dec 2, 2020

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@idanw206

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Dec 2, 2020
@blurb-it
📜🤖 Added by blurb_it.
81e35b9
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Dec 2, 2020
mariocj89
mariocj89 reviewed Dec 4, 2020
View reviewed changes

@mariocj89 mariocj89 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spotted bug!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Library/2020-12-02-07-37-59.bpo-42532.ObNep_.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@idanw206 @mariocj89
Update Misc/NEWS.d/next/Library/2020-12-02-07-37-59.bpo-42532.ObNep_.rst
d3b40aa 
Co-authored-by: Mario Corchero <[email protected]>
@idanw206

idanw206 commented Dec 4, 2020

Copy link
Copy Markdown
Contributor Author

Nicely spotted bug!

Thanks! :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mariocj89
mariocj89 approved these changes Dec 4, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Dec 4, 2020
@cjw296
cjw296 self-requested a review December 5, 2020 09:31
cjw296
cjw296 requested changes Dec 5, 2020
View reviewed changes

@cjw296 cjw296 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice spot, but please can you add a test that fails before your fix and passes after it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 5, 2020
@bedevere-bot

bedevere-bot commented Dec 5, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Dec 5, 2020
@idanw206
idanw206 force-pushed the bpo-42532-dont-call-bool-on-noncallablemock-specarg branch from a4c2be1 to 6ac0e20 Compare December 5, 2020 17:51
@idanw206

idanw206 commented Dec 5, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Dec 5, 2020
@bedevere-bot

bedevere-bot commented Dec 5, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@cjw296: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from cjw296 December 5, 2020 17:52
@idanw206 Idan Weiss
Added test for unexpected call of when passing spec_arg in mock module
71c4f0c
@idanw206
idanw206 force-pushed the bpo-42532-dont-call-bool-on-noncallablemock-specarg branch from 6ac0e20 to 71c4f0c Compare December 6, 2020 08:24
Idan Weiss
Fixed whitespaces in testmock
190c9ed
@idanw206
idanw206 force-pushed the bpo-42532-dont-call-bool-on-noncallablemock-specarg branch from 3ad46ec to 190c9ed Compare December 6, 2020 09:19
@idanw206
Fixed whitespaces in testmock.py
b853185
cjw296
cjw296 approved these changes Dec 6, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Dec 6, 2020
@cjw296
cjw296 merged commit c598a04 into python:master Dec 6, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 6, 2020
@cjw296 cjw296 added needs backport to 3.8 labels Dec 6, 2020
@miss-islington

miss-islington commented Dec 6, 2020

Copy link
Copy Markdown
Contributor

Thanks @idanw206 for the PR, and @cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Dec 6, 2020

Copy link
Copy Markdown
Contributor

Thanks @idanw206 for the PR, and @cjw296 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Dec 6, 2020

Copy link
Copy Markdown
Contributor

Sorry, @idanw206 and @cjw296, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c598a04dd29b89ad072245ddaf738badcfb41ac7 3.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned cjw296 Dec 6, 2020
@miss-islington

miss-islington commented Dec 6, 2020

Copy link
Copy Markdown
Contributor

Sorry @idanw206 and @cjw296, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c598a04dd29b89ad072245ddaf738badcfb41ac7 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjw296 cjw296 removed needs backport to 3.8 labels Dec 6, 2020
@cjw296

cjw296 commented Dec 6, 2020

Copy link
Copy Markdown
Contributor

@tirkarthi - I've taken off the backport labels since neither of the ones I added appear to have worked. Where should this get backported and how do we do that nowadays?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tirkarthi

tirkarthi commented Dec 6, 2020

Copy link
Copy Markdown
Member

There is a tool called cherry_picker that needs to be installed and can be run locally to cherry pick the commits. It seems bot cannot do it automatically due to conflicts. I will raise manual backports.

Dev guide : https://devguide.python.org/committing/?highlight=Backport#backporting-changes-to-an-older-version
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjw296

cjw296 commented Dec 6, 2020

Copy link
Copy Markdown
Contributor

I guess I'm concerned that there are conflicts, it doesn't feel like there should be?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tirkarthi

tirkarthi commented Dec 6, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Yes, it might affect mock backport. The change is simple enough so not sure if conflict is in mock.py or the tests. I will update here once I try the backport to 3.9 and 3.8.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tirkarthi

tirkarthi commented Dec 7, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@cjw296 I get below patch as conflict while trying to cherry pick. I guess 3.8 doesn't need this since it seems to iterate through all args and check for spec which has been simplified in 3.9 and above with #16099. The simplification has a backport to 3.8 in #16137 but was not applied. Hence backporting this PR would need #16137 also to be applied.

diff --cc Lib/unittest/mock.py
index 3629cf6109,4db1bacf4b..0000000000
--- a/Lib/unittest/mock.py
+++ b/Lib/unittest/mock.py
@@@ -403,18 -402,12 +403,25 @@@ class NonCallableMock(Base)
          # so we can create magic methods on the
          # class without stomping on other mocks
          bases = (cls,)
 -        if not issubclass(cls, AsyncMockMixin):
 +        if not issubclass(cls, AsyncMock):
              # Check if spec is an async object or function
++<<<<<<< HEAD
 +            sig = inspect.signature(NonCallableMock.__init__)
 +            bound_args = sig.bind_partial(cls, *args, **kw).arguments
 +            spec_arg = [
 +                arg for arg in bound_args.keys()
 +                if arg.startswith('spec')
 +            ]
 +            if spec_arg:
 +                # what if spec_set is different than spec?
 +                if _is_async_obj(bound_args[spec_arg[0]]):
 +                    bases = (AsyncMockMixin, cls,)
++=======
+             bound_args = _MOCK_SIG.bind_partial(cls, *args, **kw).arguments
+             spec_arg = bound_args.get('spec_set', bound_args.get('spec'))
+             if spec_arg is not None and _is_async_obj(spec_arg):
+                 bases = (AsyncMockMixin, cls)
++>>>>>>> c598a04dd2... [bpo-42532](https://bugs.python.org/issue42532): Check if NonCallableMock's spec_arg is not None instead of call its __bool__ function (GH23613)
          new = type(cls.__name__, bases, {'__doc__': cls.__doc__})
          instance = _safe_super(NonCallableMock, cls).__new__(new)
          return instance
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjw296

cjw296 commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

It's unclear to me why #16099 doesn't have any tests as part of the commit. That would help us figure out whether both or neither of these PRs should end up in 3.8...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tirkarthi

tirkarthi commented Dec 7, 2020

Copy link
Copy Markdown
Member

My guess is that it's a refactoring PR where all bound_args are iterated and checking for starting with "spec" might give others starting with spec like "specfoo" which could have been neither supported/tested. The PR probably tries to be explicit about checking for only spec_set and spec.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjw296

cjw296 commented Dec 10, 2020

Copy link
Copy Markdown
Contributor

@idanw206 - this has been released in the backport now: https://pypi.org/project/mock/4.0.3/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tirkarthi added a commit that referenced this pull request Dec 14, 2020
@tirkarthi @idanw206
[3.9] bpo-42532: Check if NonCallableMock's spec_arg is not None inst…
14f2a12 
…ead of call its __bool__ function (GH-23613) (GH-23676)

Check if NonCallableMock's spec_arg is not None instead of call its __bool__ function
(cherry picked from commit c598a04)

Co-authored-by: idanw206 <[email protected]>
@bedevere-bot

bedevere-bot commented Dec 14, 2020

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora LTO + PGO 3.9 has failed when building commit 14f2a12.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/423/builds/358) and take a look at the build logs.
  4. Check if the failure is related to this commit (14f2a12) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/423/builds/358

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 1        
remote: Enumerating objects: 12, done.        
remote: Counting objects:   8% (1/12)        
remote: Counting objects:  16% (2/12)        
remote: Counting objects:  25% (3/12)        
remote: Counting objects:  33% (4/12)        
remote: Counting objects:  41% (5/12)        
remote: Counting objects:  50% (6/12)        
remote: Counting objects:  58% (7/12)        
remote: Counting objects:  66% (8/12)        
remote: Counting objects:  75% (9/12)        
remote: Counting objects:  83% (10/12)        
remote: Counting objects:  91% (11/12)        
remote: Counting objects: 100% (12/12)        
remote: Counting objects: 100% (12/12), done.        
remote: Compressing objects:  16% (1/6)        
remote: Compressing objects:  33% (2/6)        
remote: Compressing objects:  50% (3/6)        
remote: Compressing objects:  66% (4/6)        
remote: Compressing objects:  83% (5/6)        
remote: Compressing objects: 100% (6/6)        
remote: Compressing objects: 100% (6/6), done.        
remote: Total 12 (delta 6), reused 6 (delta 6), pack-reused 0        
From https://github.com/python/cpython
 * branch                  3.9        -> FETCH_HEAD
Reset branch '3.9'

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make[2]: [Makefile:1855: clean-retain-profile] Error 1 (ignored)
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5717:25,
    inlined from ‘assemble’ at Python/compile.c:6056:18:
Python/compile.c:5671:19: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5671 |         *lnotab++ = k;
      |         ~~~~~~~~~~^~~
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5717:25,
    inlined from ‘assemble’ at Python/compile.c:6056:18:
Python/compile.c:5671:19: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5671 |         *lnotab++ = k;
      |                   ^
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5717:25,
    inlined from ‘assemble’ at Python/compile.c:6056:18:
Python/compile.c:5671:19: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5671 |         *lnotab++ = k;
      |                   ^
In function ‘assemble_lnotab’,
    inlined from ‘assemble_emit’ at Python/compile.c:5717:0,
    inlined from ‘assemble’ at Python/compile.c:6056:0:
Python/compile.c:5671: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
 5671 |         *lnotab++ = k;
      | 
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Modules/_pickle.c: In function ‘load_int’:
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Modules/_pickle.c:5181:17: warning: ‘s’ may be used uninitialized in this function [-Wmaybe-uninitialized]
 5181 |         value = PyLong_FromString(s, NULL, 0);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Modules/socketmodule.c: In function ‘getsockaddrarg’:
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Modules/socketmodule.c:2395:9: warning: ‘strncpy’ specified bound 64 equals destination size [-Wstringop-truncation]
 2395 |         strncpy((char *)sa->salg_name, name, sizeof(sa->salg_name));
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Parser/listnode.c: In function ‘list1node’:
Parser/listnode.c:71:1: warning: ‘/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Parser/listnode.gcda’ profile count data file not found [-Wmissing-profile]
   71 | }
      | ^
Python/frozenmain.c: In function ‘Py_FrozenMain’:
Python/frozenmain.c:129:1: warning: ‘/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/frozenmain.gcda’ profile count data file not found [-Wmissing-profile]
  129 | }
      | ^
Python/pyfpe.c: In function ‘PyFPE_dummy’:
Python/pyfpe.c:15:1: warning: ‘/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/pyfpe.gcda’ profile count data file not found [-Wmissing-profile]
   15 | }
      | ^
/usr/bin/ld: python.lto.o: in function `run_mod':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/pythonrun.c:1230: undefined reference to `PyAST_CompileObject'
/usr/bin/ld: python.lto.o: in function `symtable_add_def_helper':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/symtable.c:1018: undefined reference to `_Py_Mangle'
/usr/bin/ld: python.lto.o: in function `builtin_compile':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/bltinmodule.c:808: undefined reference to `PyAST_CompileObject'
/usr/bin/ld: python.lto.o: in function `Py_CompileStringObject':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/pythonrun.c:1313: undefined reference to `PyAST_CompileObject'
/usr/bin/ld: python.lto.o: in function `symtable_lookup':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/symtable.c:1004: undefined reference to `_Py_Mangle'
/usr/bin/ld: python.lto.o: in function `symtable_record_directive':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/symtable.c:1158: undefined reference to `_Py_Mangle'
/usr/bin/ld: python.lto.o: in function `_Py_compile_string':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/./Modules/_peg_parser.c:74: undefined reference to `PyAST_CompileObject'
/usr/bin/ld: python.lto.o: in function `type_new':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Objects/typeobject.c:2532: undefined reference to `_Py_Mangle'
/usr/bin/ld: python.lto.o: in function `symtable_visit_expr':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/symtable.c:1018: undefined reference to `_Py_Mangle'
/usr/bin/ld: python.lto.o:/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/symtable.c:1018: undefined reference to `_Py_Mangle'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:602: python] Error 1
make[1]: *** Waiting for unfinished jobs....
/usr/bin/ld: _testembed.lto.o: in function `run_mod':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/pythonrun.c:1230: undefined reference to `PyAST_CompileObject'
/usr/bin/ld: _testembed.lto.o: in function `builtin_compile':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/bltinmodule.c:808: undefined reference to `PyAST_CompileObject'
/usr/bin/ld: _testembed.lto.o: in function `Py_CompileStringObject':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/pythonrun.c:1313: undefined reference to `PyAST_CompileObject'
/usr/bin/ld: _testembed.lto.o: in function `symtable_lookup':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/symtable.c:1004: undefined reference to `_Py_Mangle'
/usr/bin/ld: _testembed.lto.o: in function `symtable_record_directive':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/symtable.c:1158: undefined reference to `_Py_Mangle'
/usr/bin/ld: _testembed.lto.o: in function `_Py_compile_string':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/./Modules/_peg_parser.c:74: undefined reference to `PyAST_CompileObject'
/usr/bin/ld: _testembed.lto.o: in function `type_new':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Objects/typeobject.c:2532: undefined reference to `_Py_Mangle'
/usr/bin/ld: _testembed.lto.o: in function `symtable_add_def_helper':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/symtable.c:1018: undefined reference to `_Py_Mangle'
/usr/bin/ld: _testembed.lto.o: in function `symtable_visit_expr':
/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/symtable.c:1018: undefined reference to `_Py_Mangle'
/usr/bin/ld: _testembed.lto.o:/home/dje/cpython-buildarea/3.9.edelsohn-fedora-z.lto-pgo/build/Python/symtable.c:1018: undefined reference to `_Py_Mangle'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:737: Programs/_testembed] Error 1
make: *** [Makefile:545: profile-opt] Error 2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjw296 cjw296 cjw296 approved these changes
+1 more reviewer
@mariocj89 mariocj89 mariocj89 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@cjw296 cjw296

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@idanw206 @the-knights-who-say-ni @bedevere-bot @miss-islington @cjw296 @tirkarthi @mariocj89
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.