GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-28556: Update the opening note in typing docs by ilevkivskyi · Pull Request #16204 · python/cpython

Conversation

@ilevkivskyi

@ilevkivskyi ilevkivskyi commented Sep 16, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR replaces the old note mentioning that typing is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making typing non-provisional, but de-facto no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs.

https://bugs.python.org/issue28556

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ilevkivskyi
Update the opening note in typing docs
a73aef9
@ilevkivskyi ilevkivskyi added docs Documentation in the Doc dir skip news needs backport to 3.7 labels Sep 16, 2019
@ilevkivskyi
ilevkivskyi requested a review from gvanrossum September 16, 2019 21:46
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 16, 2019
@bedevere-bot bedevere-bot added the awaiting core review label Sep 16, 2019
gvanrossum
gvanrossum reviewed Sep 16, 2019
View reviewed changes
Comment thread Doc/library/typing.rst Outdated
:term:`provisional basis <provisional api>`. New features might
be added and API may change even between minor releases if deemed
necessary by the core developers.
Python runtime does not enforce the function and variable type annotations.

@gvanrossum gvanrossum Sep 16, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python runtime does not enforce the function and ...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ilevkivskyi
Address CR
f479d0d
gvanrossum
gvanrossum approved these changes Sep 16, 2019
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall exactly how it became non-provisional, I think we already bent the rules for provisional modules by keeping it provisional longer than one release cycle. :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 16, 2019
@ilevkivskyi
ilevkivskyi merged commit 81528ba into python:master Sep 16, 2019
@ilevkivskyi
ilevkivskyi deleted the update-typing-note branch September 16, 2019 22:04
@miss-islington

miss-islington commented Sep 16, 2019

Copy link
Copy Markdown
Contributor

Thanks @ilevkivskyi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 16, 2019
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2019
@ilevkivskyi @miss-islington
bpo-28556: Update the opening note in typing docs (pythonGH-16204)
e00e0db 
This PR replaces the old note mentioning that `typing` is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making `typing` non-provisional, but _de-facto_ no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs.
(cherry picked from commit 81528ba)

Co-authored-by: Ivan Levkivskyi <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Sep 16, 2019
@bedevere-bot

bedevere-bot commented Sep 16, 2019

Copy link
Copy Markdown

GH-16205 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2019
@ilevkivskyi @miss-islington
bpo-28556: Update the opening note in typing docs (pythonGH-16204)
039d862 
This PR replaces the old note mentioning that `typing` is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making `typing` non-provisional, but _de-facto_ no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs.
(cherry picked from commit 81528ba)

Co-authored-by: Ivan Levkivskyi <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Sep 16, 2019
@bedevere-bot

bedevere-bot commented Sep 16, 2019

Copy link
Copy Markdown

GH-16206 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Sep 16, 2019
@miss-islington @ilevkivskyi
bpo-28556: Update the opening note in typing docs (GH-16204)
733193d 
This PR replaces the old note mentioning that `typing` is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making `typing` non-provisional, but _de-facto_ no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs.
(cherry picked from commit 81528ba)

Co-authored-by: Ivan Levkivskyi <[email protected]>
miss-islington added a commit that referenced this pull request Sep 16, 2019
@miss-islington @ilevkivskyi
bpo-28556: Update the opening note in typing docs (GH-16204)
7076764 
This PR replaces the old note mentioning that `typing` is a provisional module with a new one mentioning types are not enforced at runtime. I am not sure if there was any official announcement about making `typing` non-provisional, but _de-facto_ no new features were added during Python 3.7, and no backwards incompatible changes were made except for few small things that were considered bugs.
(cherry picked from commit 81528ba)

Co-authored-by: Ivan Levkivskyi <[email protected]>
@Fidget-Spinner Fidget-Spinner mentioned this pull request May 1, 2021
prepare release 3.10.0.0 python/typing#805
Merged
JelleZijlstra added a commit to python/peps that referenced this pull request May 1, 2021
@JelleZijlstra
PEP 484: Mark as Final
230aa73 
PEP 484 is still marked as "Provisional", but as @Fidget-Spinner pointed out in python/typing#805, it shouldn't be any more. python/cpython#16204 removed talk about typing's provisional status from the module docs, and enhancements to typing have been in the form of new PEPs for the last few release cycles.

Going to mark this as a draft so Guido can have a chance to comment once he's back.
@JelleZijlstra JelleZijlstra mentioned this pull request May 1, 2021
PEP 484: Mark as Final python/peps#1942
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ilevkivskyi @miss-islington @bedevere-bot @gvanrossum @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.