GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — prepare release 3.10.0.0 by JelleZijlstra · Pull Request #805 · python/typing

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 1, 2021

Copy link
Copy Markdown
Member

Also update the description for typing-extensions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
prepare release 3.10.0.0
0536891
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 1, 2021
Fidget-Spinner
Fidget-Spinner approved these changes May 1, 2021
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Changing the tox env versions for the typing module is a good catch considering #784.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread typing_extensions/setup.py
Typing Extensions -- Backported and Experimental Type Hints for Python

The ``typing`` module was added to the standard library in Python 3.5 on
a provisional basis and will no longer be provisional in Python 3.7. However,

@Fidget-Spinner Fidget-Spinner May 1, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off topic: I see #247 and python/cpython#16204 saying typing became implicitly non-provisional in 3.7 because no new features were added, but PEP 484 still says Status: | Provisional ? Maybe that PEP needs discussion/updating once Guido's back.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra May 1, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I opened python/peps#1942 to fix it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread typing_extensions/setup.py
exit(1)

version = '3.7.4.3'
version = '3.10.0.0'

@Fidget-Spinner Fidget-Spinner May 1, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's too early to also add to the classifiers list below this the following classifier: 'Programming Language :: Python :: 3.10', while you're at it?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra May 1, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was thinking about that. Let me just run the test suite on current CPython master to be sure.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Fidget-Spinner Fidget-Spinner May 1, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope I didn't do any double work here, but FWIW, the latest CPython master runs the tests with no errors on my machine.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra May 1, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
srittau
srittau approved these changes May 1, 2021
View reviewed changes
JelleZijlstra
JelleZijlstra commented May 1, 2021
View reviewed changes
Comment thread typing_extensions/setup.py
The ``typing_extensions`` module contains backports of these changes.
Experimental types that will eventually be added to the ``typing``
module are also included in ``typing_extensions``, such as
``typing.ParamSpec`` and ``typing.TypeGuard``.

@JelleZijlstra JelleZijlstra May 1, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And also IntVar, which still doesn't have a PEP proposing it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JelleZijlstra added a commit to python/peps that referenced this pull request May 1, 2021
@JelleZijlstra
PEP 484: Mark as Final
230aa73 
PEP 484 is still marked as "Provisional", but as @Fidget-Spinner pointed out in python/typing#805, it shouldn't be any more. python/cpython#16204 removed talk about typing's provisional status from the module docs, and enhancements to typing have been in the form of new PEPs for the last few release cycles.

Going to mark this as a draft so Guido can have a chance to comment once he's back.
@JelleZijlstra JelleZijlstra mentioned this pull request May 1, 2021
PEP 484: Mark as Final python/peps#1942
Closed
@JelleZijlstra
also support 3.10
ec8aeb3
@JelleZijlstra
JelleZijlstra merged commit edd78b2 into python:master May 1, 2021
@JelleZijlstra
JelleZijlstra deleted the release branch May 1, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes
+1 more reviewer
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @srittau @Fidget-Spinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.