GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-26730: Fix SpooledTemporaryFile data corruption (GH-17400) by miss-islington · Pull Request #17405 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 27, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.

Co-Authored-By: Serhiy Storchaka [email protected]
(cherry picked from commit ea9835c)

Co-authored-by: Inada Naoki [email protected]

https://bugs.python.org/issue26730

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane @miss-islington
bpo-26730: Fix SpooledTemporaryFile data corruption (pythonGH-17400)
3ff8cc1 
SpooledTemporaryFile.rollback() might cause data corruption
when it is in text mode.

Co-Authored-By: Serhiy Storchaka <[email protected]>
(cherry picked from commit ea9835c)

Co-authored-by: Inada Naoki <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Nov 27, 2019
bpo-26730: Fix SpooledTemporaryFile data corruption #17400
Merged
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 27, 2019
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Nov 27, 2019
@miss-islington

miss-islington commented Nov 27, 2019

Copy link
Copy Markdown
Contributor Author

@methane: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
2 similar comments
@miss-islington

miss-islington commented Nov 27, 2019

Copy link
Copy Markdown
Contributor Author

@methane: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Nov 27, 2019

Copy link
Copy Markdown
Contributor Author

@methane: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
methane
methane approved these changes Nov 28, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 28, 2019
@miss-islington
miss-islington merged commit d21b8e8 into python:3.8 Nov 28, 2019
@miss-islington
miss-islington deleted the backport-ea9835c-3.8 branch November 28, 2019 05:23
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @methane @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.