GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-37347: Require SQLite 3.7.3+ by sir-sigurd · Pull Request #17413 · python/cpython

Conversation

@sir-sigurd

@sir-sigurd sir-sigurd commented Nov 28, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue37347

#14268 makes sqlite3 module require SQLite 3.7.2+ because it's using sqlite3_create_function_v2(), but actually it was added in SQLite 3.7.3.

This PR:

  • updates setup.py to require SQLite 3.7.3+
  • removes unneeded code that was required for support of older SQLite versions
  • explicitly states required SQLite version in doc of sqlite3 module

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sir-sigurd
bpo-37347: Require SQLite 3.7.3+
f2aca1c
@sir-sigurd
sir-sigurd requested a review from berkerpeksag as a code owner November 28, 2019 15:42
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 28, 2019
@bedevere-bot bedevere-bot added the awaiting review label Nov 28, 2019
@ned-deily
ned-deily requested a review from benjaminp November 28, 2019 17:19
@ned-deily

ned-deily commented Dec 9, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thanks for the PR but, as bpo-37347 is closed and was focused on a specific problem, you should open a separate issue to propose dropping support for SQLite versions prior to 3.7.3 and move this PR to it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
berkerpeksag
berkerpeksag requested changes Dec 11, 2019
View reviewed changes

@berkerpeksag berkerpeksag left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Ned that removing pre 3.7.3 code from sqlite3 needs its own issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/sqlite3.rst

.. note::

This module requires SQLite 3.7.3+.

@berkerpeksag berkerpeksag Dec 11, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this information can be incorporated into the following paragraph:

The sqlite3 module was written by Gerhard Häring.  It provides a SQL interface
compliant with the DB-API 2.0 specification described by :pep:`249`.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Dec 11, 2019
@bedevere-bot

bedevere-bot commented Dec 11, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csabella

csabella commented Jan 25, 2020

Copy link
Copy Markdown
Contributor

@sir-sigurd please address the review comments. If the new bug tracker issue has already been created, please mention it in this PR and close this one. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csabella

csabella commented May 22, 2020

Copy link
Copy Markdown
Contributor

@sir-sigurd, ping
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csabella csabella mentioned this pull request May 23, 2020
bpo-40744: Drop support for SQLite3 pre v3.7.3 #20330
Closed
@erlend-aasland erlend-aasland mentioned this pull request May 30, 2020
bpo-40810: Fix CheckTraceCallbackContent for SQLite pre 3.7.15 #20530
Merged
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request May 30, 2020
Erlend E. Aasland
Require SQLite 3.7.3
a53c9ef 
Remove code required to to support SQLite pre 3.7.3.

Integrate setup.py, docs and unit test changes from PR python#17413

Style changes not related to bpo-40744 were dropped from the merge.
Berker Peksag's suggested documentation changes was included.

See python#17413

Co-written-by: Berker Peksag <[email protected]>
Co-written-by: Sergey Fedoseev <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jun 16, 2020
bpo-40744: Drop support for SQLite pre 3.7.3 #20909
Merged
@sir-sigurd

sir-sigurd commented Jul 6, 2020

Copy link
Copy Markdown
Contributor Author

Closing in favor of #20909.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sir-sigurd sir-sigurd closed this Jul 6, 2020
@sir-sigurd
sir-sigurd deleted the sqlite-min-version branch July 6, 2020 18:31
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Sep 7, 2020
Erlend E. Aasland
Require SQLite 3.7.3
22fb16b 
Remove code required to to support SQLite pre 3.7.3.

Integrate setup.py, docs and unit test changes from PR python#17413

Style changes not related to bpo-40744 were dropped from the merge.
Berker Peksag's suggested documentation changes was included.

See python#17413

Co-written-by: Berker Peksag <[email protected]>
Co-written-by: Sergey Fedoseev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag requested changes
@benjaminp benjaminp Awaiting requested review from benjaminp

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sir-sigurd @ned-deily @bedevere-bot @csabella @berkerpeksag @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.