GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40744: Drop support for SQLite pre 3.7.3 by erlend-aasland · Pull Request #20909 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 16, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Remove code required to to support SQLite pre 3.7.3.

Integrate setup.py, docs and unit test changes from PR #17413

Style changes not related to bpo-40744 were dropped from the merge.
Berker Peksag's suggested documentation changes was included.

See #17413

Co-written-by: Berker Peksag [email protected]
Co-written-by: Sergey Fedoseev [email protected]

https://bugs.python.org/issue40744

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner June 16, 2020 09:10
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 16, 2020
@bedevere-bot bedevere-bot added the awaiting review label Jun 16, 2020
@sir-sigurd sir-sigurd mentioned this pull request Jul 6, 2020
bpo-37347: Require SQLite 3.7.3+ #17413
Closed
Erlend E. Aasland
Require SQLite 3.7.3
22fb16b 
Remove code required to to support SQLite pre 3.7.3.

Integrate setup.py, docs and unit test changes from PR python#17413

Style changes not related to bpo-40744 were dropped from the merge.
Berker Peksag's suggested documentation changes was included.

See python#17413

Co-written-by: Berker Peksag <[email protected]>
Co-written-by: Sergey Fedoseev <[email protected]>
@erlend-aasland
erlend-aasland force-pushed the fix-issue-40744 branch from 0782d45 to 22fb16b Compare September 7, 2020 11:55
@erlend-aasland

erlend-aasland commented Sep 7, 2020

Copy link
Copy Markdown
Contributor Author

@pablogsal, would you mind if I request your review on this as well?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Sep 7, 2020

Copy link
Copy Markdown
Member

@pablogsal, would you mind if I request your review on this as well?

No problem. Will try to give it a go soon. Feel free to ping me in a couple of days if I have not made a review by then :)
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal reviewed Sep 7, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2020-05-30-08-10-23.bpo-40744.jKURVV.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 7, 2020
@bedevere-bot

bedevere-bot commented Sep 7, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 22fb16b 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 7, 2020
Erlend E. Aasland
Improve NEWS entry
5d180f8
pablogsal
pablogsal reviewed Sep 7, 2020
View reviewed changes
Comment thread Modules/_sqlite/module.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Sep 7, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 7, 2020
@pablogsal
pablogsal merged commit 207c321 into python:master Sep 7, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 7, 2020
@erlend-aasland

erlend-aasland commented Sep 7, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the review, @pablogsal !
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the fix-issue-40744 branch September 7, 2020 21:27
@pablogsal

pablogsal commented Sep 7, 2020

Copy link
Copy Markdown
Member

Thanks, @erlend-aasland for the PR :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Sep 7, 2020

Copy link
Copy Markdown
Contributor Author

Should this be backported to 3.9, or is it too late?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Sep 7, 2020

Copy link
Copy Markdown
Member

Should this be backported to 3.9, or is it too late?

Too late IMHO, check my message on bpo
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 10, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_1635741_1
00b300c 
* origin/master: (1373 commits)
  bpo-1635741: Port mashal module to multi-phase init (python#22149)
  bpo-1635741: Port _string module to multi-phase init (pythonGH-22148)
  bpo-1635741: Convert _sha256 types to heap types (pythonGH-22134)
  bpo-1635741: Port the termios to multi-phase init (PEP 489) (pythonGH-22139)
  bpo-41732: add iterator to memoryview (pythonGH-22119)
  bpo-40744: Drop support for SQLite pre 3.7.3 (pythonGH-20909)
  bpo-41316: Make tarfile follow specs for FNAME (pythonGH-21511)
  bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (pythonGH-22092)
  bpo-1635741 port _curses_panel to multi-phase init (PEP 489) (pythonGH-21986)
  bpo-1635741: Port _overlapped module to multi-phase init (pythonGH-22051)
  bpo-1635741: Port _opcode module to multi-phase init (PEP 489) (pythonGH-22050)
  bpo-1635741 port zlib module to multi-phase init (pythonGH-21995)
  [doc] Add link to Generic in typing (pythonGH-22125)
  bpo-41513: Expand comments and add references for a better understanding (pythonGH-22123)
  bpo-1635741: Port _sha1, _sha512, _md5 to multiphase init (pythonGH-21818)
  closes bpo-41723: Fix an error in the py_compile documentation. (pythonGH-22110)
  [doc] Fix padding in some typing definitions (pythonGH-22114)
  Fix documented Python version for venv --upgrade-deps (pythonGH-22113)
  bpo-40318: Migrate to SQLite3 trace v2 API (pythonGH-19581)
  bpo-41687: Fix sendfile implementation to work with Solaris (python#22040)
  ...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Erlend Egeberg Aasland @xzy3-cdc
bpo-40744: Drop support for SQLite pre 3.7.3 (pythonGH-20909)
eb44630 
Remove code required to support SQLite pre 3.7.3.

Co-written-by: Berker Peksag <[email protected]>
Co-written-by: Sergey Fedoseev <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request Jan 5, 2021
bpo-40810: Require SQLite 3.7.15 #24106
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @pablogsal @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.