GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-37860: Enable docs deploy previews through GitHub Actions by epicfaace · Pull Request #19025 · python/cpython

Conversation

@epicfaace

@epicfaace epicfaace commented Mar 15, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Sample PR: epicfaace#7

https://bugs.python.org/issue37860

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
epicfaace added 19 commits March 15, 2020 16:11
@epicfaace
Create deploy-previews.yml
f12d58d
@epicfaace
Update deploy-previews.yml
dd312dd
@epicfaace
Update deploy-previews.yml
492e953
@epicfaace
Update deploy-previews.yml
1825f89
@epicfaace
Update deploy-previews.yml
31cf48e
@epicfaace
Update deploy-previews.yml
6f3a771
@epicfaace
Update deploy-previews.yml
19fa5c8
@epicfaace
Update deploy-previews.yml
98c91b9
@epicfaace
Update deploy-previews.yml
dd1b380
@epicfaace
Update deploy-previews.yml
e781e03
@epicfaace
Update deploy-previews.yml
c23fc32
@epicfaace
Update deploy-previews.yml
5bfaefb
@epicfaace
Update deploy-previews.yml
0440449
@epicfaace
Update deploy-previews.yml
dabc15f
@epicfaace
Update deploy-previews.yml
1bd904a
@epicfaace
Update deploy-previews.yml
587ee98
@epicfaace
Update deploy-previews.yml
c16f0dc
@epicfaace
Merge pull request #6 from epicfaace/epicfaace-patch-1
c1ce565
Create deploy-previews.yml
@epicfaace
Update deploy-previews.yml
9a4d8b8
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 15, 2020
@bedevere-bot bedevere-bot added the awaiting review label Mar 15, 2020
epicfaace added 2 commits March 15, 2020 18:57
@epicfaace
Update deploy-previews.yml
1e29197
@epicfaace
Update deploy-previews.yml
07210c0
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Mar 16, 2020
@hugovk hugovk mentioned this pull request Dec 28, 2021
bpo-46184: remove netlify.toml #30272
Merged
@sobolevn sobolevn mentioned this pull request Jan 2, 2022
bpo-46005: add note about setuptools to Doc/extending/building.rst #30062
Closed
@hugovk

hugovk commented Jan 12, 2022

Copy link
Copy Markdown
Member

This looks good, although one downside is it creates a new directory for each and every commit pushed to a PR:

  • https://github.com/epicfaace/cpython/tree/gh-pages
  • 586 MB for 10 builds

That's going to get pretty big and fast, so would need to have some way to cleanup old ones.

It would be better to use the PR number instead of commit SHA and only build PRs that change docs or docs build logic.

Also I wonder if that amount of churn on a single branch would have a performance impact on the rest of the Git repo?

Perhaps another host server would be better.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@epicfaace

epicfaace commented Jan 12, 2022

Copy link
Copy Markdown
Contributor Author
  • 586 MB for 10 builds

Yeah, and GitHub Pages also has a hard limit of 1 GB in size -- https://docs.github.com/en/pages/getting-started-with-github-pages/about-github-pages#usage-limits. Why is the docs site so large again? Are there certain large static files that can be symlinked / shared between deploy previews?

It would be better to use the PR number instead of commit SHA and only build PRs that change docs or docs build logic.

Good idea.

Also I wonder if that amount of churn on a single branch would have a performance impact on the rest of the Git repo?

I don't think it will be an issue as long as we clean up merged PRs -- so we only include PRs in this branch that are currently open.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk mentioned this pull request Apr 16, 2022
Doc: Fix spurious comma in the author metadata field #32386
Merged
@epicfaace epicfaace mannequin mentioned this pull request Apr 16, 2022
Add deploy preview for docs #82041
Closed
@epicfaace

epicfaace commented May 16, 2022

Copy link
Copy Markdown
Contributor Author

Closing in favor of #92852

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@epicfaace epicfaace closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@epicfaace @hugovk @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.