GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46005: add note about setuptools to Doc/extending/building.rst by sobolevn · Pull Request #30062 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Dec 11, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue46005

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sobolevn
bpo-46005: add setuptools note to Doc/extending/building.rst
ec8133d
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Dec 11, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 11, 2021
@bedevere-bot bedevere-bot added the awaiting review label Dec 11, 2021
@AlexWaygood AlexWaygood added the needs backport to 3.10 label Dec 13, 2021
@merwok merwok added the skip news label Jan 2, 2022
merwok
merwok reviewed Jan 2, 2022
View reviewed changes

@merwok merwok left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would remove the news snippet. It will not really provide value when collected in a NEWS document (unless I’ve missed recent conventions, NEWS does not duplicate the full git changelog).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sobolevn
Delete 2021-12-11-22-22-32.bpo-46005.DdcZhU.rst
d3b86e8
@merwok merwok added the needs backport to 3.9 label Jan 2, 2022
merwok
merwok approved these changes Jan 2, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 2, 2022
@merwok

merwok commented Jan 2, 2022

Copy link
Copy Markdown
Member

Wasn’t there a python.github.io site configured to show docs built from pull requests?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood

AlexWaygood commented Jan 2, 2022

Copy link
Copy Markdown
Member

Wasn’t there a python.github.io site configured to show docs built from pull requests?

The artifact is uploaded here 🙂

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood

AlexWaygood commented Jan 2, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

BTW, @merwok, should this be backported to 3.9? I think distutils was only deprecated in 3.10.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@merwok merwok added needs backport to 3.9 and removed needs backport to 3.9 labels Jan 2, 2022
@merwok

merwok commented Jan 2, 2022

Copy link
Copy Markdown
Member

Yes, that’s the artifact, it needs to be downloaded and extracted. I was referring to a website that’s easier to look at 🙂

I checked the 3.9 branch and the _setuptools_disclaimer.rst is there, so we can backport.
The formal deprecation may be in 3.10, but the package was minimally maintained before and setuptools was recommended.

AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood

AlexWaygood commented Jan 2, 2022

Copy link
Copy Markdown
Member

Yes, that’s the artifact, it needs to be downloaded and extracted. I was referring to a website that’s easier to look at 🙂

I don't know of such a website (but then, I'm fairly new to CPython! If there is one, I'd be very interested to know about it...)

Having downloaded and extracted it myself, this is what it looks like, anyhow!
image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn

sobolevn commented Jan 2, 2022

Copy link
Copy Markdown
Member Author

@AlexWaygood probably @merwok is asking about #30272 and #19025

Right now the automation does not work 😞

AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

merwok
merwok approved these changes Jan 2, 2022
View reviewed changes
@merwok merwok changed the title bpo-46005: add setuptools note to Doc/extending/building.rst bpo-46005: add note about setuptools to Doc/extending/building.rst Jan 2, 2022
@taleinat taleinat added the DO-NOT-MERGE label Jan 18, 2022
@taleinat

taleinat commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

Thanks for the PR, @sobolevn!

I'm not sold on this change though. I'm marking this PR as "do not merge" for now, until the discussion on the b.p.o. issue reaches a conclusion.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes and removed needs backport to 3.9 labels May 20, 2022
@AA-Turner

AA-Turner commented Jun 9, 2022

Copy link
Copy Markdown
Member

Trigger CLA

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner AA-Turner closed this Jun 9, 2022
@AA-Turner AA-Turner reopened this Jun 9, 2022
@AA-Turner AA-Turner removed the CLA signed label Jun 9, 2022
@elmjag elmjag mannequin mentioned this pull request Jun 25, 2022
[doc] replace 'distutils' examples with 'setuptools' #90163
Closed
@sobolevn

sobolevn commented Nov 5, 2022

Copy link
Copy Markdown
Member Author

I am closing this PR, because distutils module was completely removed.
There will be major changes to its documentation.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn sobolevn closed this Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge DO-NOT-MERGE docs Documentation in the Doc dir needs backport to 3.11 only security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@sobolevn @merwok @AlexWaygood @taleinat @AA-Turner @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.