GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46184: remove `netlify.toml` by sobolevn · Pull Request #30272 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Dec 26, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Related to #30257

I guess we can skip NEWS on this one.

https://bugs.python.org/issue46184

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
bpo-46184: remove netlify.toml
e0e9041
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 26, 2021
@bedevere-bot bedevere-bot added the awaiting review label Dec 26, 2021
@sobolevn sobolevn closed this Dec 27, 2021
@sobolevn sobolevn reopened this Dec 27, 2021
@sobolevn

sobolevn commented Dec 27, 2021

Copy link
Copy Markdown
Member Author

Windows build for winarm take a lot of time, then it is canceled. https://dev.azure.com/Python/cpython/_build/results?buildId=93679&view=logs&j=91c152bd-7320-5194-b252-1404e56e2478

This failure does not seem related.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Dec 27, 2021
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as it seems unused.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Dec 27, 2021
@hugovk

hugovk commented Dec 28, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This file was added in #15288 / https://bugs.python.org/issue37860 but Netlify wasn't turned on due to build limits:

#15288 (comment)

I guess that was never resolved, so okay to remove this file, @epicfaace?

If so, should also remove Doc/runtime.txt, added for Netlify in the same PR.

And see #19025 for an open, alternate approach using GitHub Actions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn added 2 commits December 28, 2021 15:10
@sobolevn
Delete runtime.txt
2aa4139
@sobolevn
Delete requirements.txt
9aa4f06
hugovk
hugovk reviewed Dec 28, 2021
View reviewed changes
Comment thread Doc/requirements.txt
@@ -1,12 +0,0 @@
# Requirements to build the Python documentation

@hugovk hugovk Dec 28, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc/requirements.txt is still needed:

https://github.com/python/cpython/runs/4649987492?check_suite_focus=true#step:7:30

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@sobolevn sobolevn Dec 28, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk thank you! 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@sobolevn
Revert "Delete requirements.txt"
1ba745d 
This reverts commit 9aa4f06.
@sobolevn

sobolevn commented Dec 28, 2021

Copy link
Copy Markdown
Member Author

@AlexWaygood do you think that this can be marked as "skip news"?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Dec 28, 2021

Copy link
Copy Markdown
Member

@AlexWaygood do you think that this can be marked as "skip news"?

Okay, I am adding the skip-news label, as it seems appropriate to me. But, this is not something I really know anything about, so anybody who thinks that this needs a news entry should feel free to remove it again. 🙂
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added the skip news label Dec 28, 2021
@epicfaace

epicfaace commented Dec 28, 2021

Copy link
Copy Markdown
Contributor

I guess that was never resolved, so okay to remove this file, @epicfaace?

Yes, sgtm!
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Dec 30, 2021

Copy link
Copy Markdown
Member Author

@Mariatta are you the right person to ping in this case? 🙂
Mariatta reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mariatta
Mariatta approved these changes Dec 30, 2021
View reviewed changes

@Mariatta Mariatta left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning these up.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 30, 2021
@Mariatta
Mariatta merged commit fbaf2e6 into python:main Dec 30, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 30, 2021
@bedevere-bot

bedevere-bot commented Dec 30, 2021

Copy link
Copy Markdown

@Mariatta: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn sobolevn mentioned this pull request Jan 2, 2022
bpo-46005: add note about setuptools to Doc/extending/building.rst #30062
Closed
epicfaace added a commit to epicfaace/cpython that referenced this pull request May 16, 2022
@epicfaace
Revert "bpo-46184: remove netlify.toml (python#30272)"
6a80a21 
This reverts commit fbaf2e6.
@epicfaace epicfaace mentioned this pull request May 16, 2022
bpo-37860: re-add netlify.toml to set up deploy previews for docs #92852
Merged
ewdurbin pushed a commit that referenced this pull request Dec 6, 2022
@epicfaace @hugovk
bpo-37860: re-add netlify.toml to set up deploy previews for docs (#9…
85d5a7e 
…2852)

* Revert "bpo-46184: remove `netlify.toml` (#30272)"

This reverts commit fbaf2e6.

* Delete runtime.txt

* Create runtime.txt

* Delete runtime.txt

* Update netlify.toml

* Update netlify.toml

* Add netlify badge

* Update Doc/tools/templates/layout.html

Co-authored-by: Hugo van Kemenade <[email protected]>

* Update layout.html

Co-authored-by: Hugo van Kemenade <[email protected]>
aryautkarsh091 added a commit to aryautkarsh091/astropy that referenced this pull request Jan 18, 2026
@aryautkarsh091
Fix minversion TypeError with dev version strings
1251baa 
Switch to packaging.version.Version for version comparison
to handle PEP 440 dev/rc versions correctly. This resolves
failures introduced by PR astropy#7647 and avoids distutils'
LooseVersion bug (see python/cpython#30272).

Add tests for dev/rc version handling in minversion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@Mariatta Mariatta Mariatta approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@sobolevn @hugovk @AlexWaygood @epicfaace @bedevere-bot @Mariatta @kumaraditya303 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.