GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40318: Migrate to SQLite3 trace v2 API by erlend-aasland · Pull Request #19581 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 18, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Use new sqlite3_trace_v2() API if possible.

https://bugs.python.org/issue40318

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
stonebig reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner April 18, 2020 12:22
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 18, 2020
@bedevere-bot bedevere-bot added the awaiting review label Apr 18, 2020
Erlend E. Aasland added 2 commits April 19, 2020 22:46
Erlend E. Aasland
Use new sqlite3_trace_v2() API if possible
c959d36 
Ref. https://sqlite.org/c3ref/trace_v2.html
Erlend E. Aasland
Add NEWS entry
f1ae11c
@erlend-aasland
erlend-aasland force-pushed the fix-issue-40318 branch from 718a379 to f1ae11c Compare April 19, 2020 20:47
@erlend-aasland

erlend-aasland commented Apr 19, 2020

Copy link
Copy Markdown
Contributor Author

Ready for review, @berkerpeksag.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal reviewed Sep 5, 2020
View reviewed changes
Comment thread Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal reviewed Sep 5, 2020
View reviewed changes
Comment thread Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
Update Modules/_sqlite/connection.c
8980855
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 5, 2020
@bedevere-bot

bedevere-bot commented Sep 5, 2020

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 8980855 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 5, 2020
pablogsal
pablogsal approved these changes Sep 5, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 5, 2020
@erlend-aasland

erlend-aasland commented Sep 5, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for your review, @pablogsal !
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Sep 5, 2020

Copy link
Copy Markdown
Member

@erlend-aasland Seems that sqlite3_enable_shared_cache is also deprecated? Would you like to make another PR (with another issue for this)? You can add me as a reviewer :)
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Sep 5, 2020

Copy link
Copy Markdown
Contributor Author

@erlend-aasland Seems that sqlite3_enable_shared_cache is also deprecated? Would you like to make another PR (with another issue for this)? You can add me as a reviewer :)

Sure, I'll have a go at it :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Sep 5, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Seems that there is an already opened issue here:
https://bugs.python.org/issue30646

Edit: Check the issue, but seems that there is not much to do, unfortunately, as there is no alternative for that function.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Sep 5, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Seems that there is an already opened issue here:
https://bugs.python.org/issue30646

Edit: Check the issue, but seems that there is not much to do, unfortunately, as there is no alternative for that function.

I'm not so sure about that. Ref. the SQLite docs:

Note: This method is disabled on MacOS X 10.7 and iOS version 5.0 and will always return SQLITE_MISUSE. On those systems, shared cache mode should be enabled per-database connection via sqlite3_open_v2() with SQLITE_OPEN_SHAREDCACHE.

We could just make sure that db connections are opened with SQLITE_OPEN_SHAREDCACHE if we are on macOS. I'll repost this on the issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Sep 5, 2020

Copy link
Copy Markdown
Member

We could just make sure that db connections are opened with SQLITE_OPEN_SHAREDCACHE if we are on macOS.

Could you mention that in the issue? Ned and Ronald are our MacOS experts so they should weight that
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit 7f331c8 into python:master Sep 5, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 5, 2020
@pablogsal

pablogsal commented Sep 5, 2020

Copy link
Copy Markdown
Member

Thanks for your contribution @erlend-aasland !
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland deleted the fix-issue-40318 branch September 5, 2020 20:47
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 10, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_1635741_1
00b300c 
* origin/master: (1373 commits)
  bpo-1635741: Port mashal module to multi-phase init (python#22149)
  bpo-1635741: Port _string module to multi-phase init (pythonGH-22148)
  bpo-1635741: Convert _sha256 types to heap types (pythonGH-22134)
  bpo-1635741: Port the termios to multi-phase init (PEP 489) (pythonGH-22139)
  bpo-41732: add iterator to memoryview (pythonGH-22119)
  bpo-40744: Drop support for SQLite pre 3.7.3 (pythonGH-20909)
  bpo-41316: Make tarfile follow specs for FNAME (pythonGH-21511)
  bpo-41720: Add "return NotImplemented" in turtle.Vec2D.__rmul__(). (pythonGH-22092)
  bpo-1635741 port _curses_panel to multi-phase init (PEP 489) (pythonGH-21986)
  bpo-1635741: Port _overlapped module to multi-phase init (pythonGH-22051)
  bpo-1635741: Port _opcode module to multi-phase init (PEP 489) (pythonGH-22050)
  bpo-1635741 port zlib module to multi-phase init (pythonGH-21995)
  [doc] Add link to Generic in typing (pythonGH-22125)
  bpo-41513: Expand comments and add references for a better understanding (pythonGH-22123)
  bpo-1635741: Port _sha1, _sha512, _md5 to multiphase init (pythonGH-21818)
  closes bpo-41723: Fix an error in the py_compile documentation. (pythonGH-22110)
  [doc] Fix padding in some typing definitions (pythonGH-22114)
  Fix documented Python version for venv --upgrade-deps (pythonGH-22113)
  bpo-40318: Migrate to SQLite3 trace v2 API (pythonGH-19581)
  bpo-41687: Fix sendfile implementation to work with Solaris (python#22040)
  ...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Erlend Egeberg Aasland @pablogsal @xzy3-cdc
bpo-40318: Migrate to SQLite3 trace v2 API (pythonGH-19581)
48d490d 
Ref. https://sqlite.org/c3ref/trace_v2.html

Co-authored-by: Pablo Galindo <[email protected]>
This was referenced Nov 2, 2020
bpo-42241: Backport migration to SQLite3 trace v2… #23097
Closed
bpo-42242: Backport migration to SQLite3 trace v2 #23099
Closed
@erlend-aasland

erlend-aasland commented Nov 2, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@pablogsal: is there any chance to backport this to 3.9 and possibly 3.8? See bpo-42241 and bpo-42242.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
SamuelMarks pushed a commit to SamuelMarks/cpython that referenced this pull request Nov 2, 2020
Erlend Egeberg Aasland @SamuelMarks
[3.9] bpo-40318: Migrate to SQLite3 trace v2 API (pythonGH-19581)
a699bd7 
Ref. https://sqlite.org/c3ref/trace_v2.html

Co-authored-by: Pablo Galindo <[email protected]>
(cherry picked from commit 7f331c8)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
SamuelMarks pushed a commit to SamuelMarks/cpython that referenced this pull request Nov 2, 2020
Erlend Egeberg Aasland @SamuelMarks
[3.8] bpo-40318: Migrate to SQLite3 trace v2 API (pythonGH-19581)
7656761 
Ref. https://sqlite.org/c3ref/trace_v2.html

Co-authored-by: Pablo Galindo <[email protected]>
(cherry picked from commit 7f331c8)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@pablogsal

pablogsal commented Nov 2, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@pablogsal: is there any chance to backport this to 3.9 and possibly 3.8? See bpo-42241 and bpo-42242.

Unfortunately no, as this is nor a bugfix not a security fix :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Nov 2, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@pablogsal: is there any chance to backport this to 3.9 and possibly 3.8? See [bpo-42241]>
Unfortunately no, as this is not a bugfix not a security fix :(

Got it; thanks :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Nov 2, 2020
[3.9] bpo-40318: Migrate to SQLite3 trace v2 API (GH-19581) #23102
Closed
@SamuelMarks

SamuelMarks commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

@pablogsal Hmm… but wouldn't fixing compiler warnings constitute a bug fix? 🤔
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Nov 2, 2020

Copy link
Copy Markdown
Member

@pablogsal Hmm… but wouldn't fixing compiler warnings constitute a bug fix? 🤔

Yes, bug this is fixing the warning by opting into a new different API that although unlikely, may have some different behaviour for users while the price of not doing anything is a compiler warning that is not new. That's certainly not worth the risk of backporting 😉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Apr 29, 2022
sqlite3 regression: bound values are not expanded in traced statements #89301
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @bedevere-bot @pablogsal @SamuelMarks @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.