GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40275: Avoid importing asyncio in test.support by serhiy-storchaka · Pull Request #19600 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Apr 19, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Import IsolatedAsyncioTestCase lazily in unittest.
  • Import asyncio.events lazily in test.support.

https://bugs.python.org/issue40275

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-40275: Avoid importing asyncio in test.support
a45c6c6 
* Import IsolatedAsyncioTestCase lazily in unittest.
* Import asyncio.events lazily in test.support.
@serhiy-storchaka serhiy-storchaka added the skip news label Apr 19, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 19, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Apr 19, 2020
@serhiy-storchaka
Fix __getattr__ and add __dir__ in unittest.
212d7fd
This was referenced Apr 19, 2020
bpo-40275: Avoid importing logging in test.support #19601
Merged
bpo-40275: Avoid importing socket in test.support #19603
Merged
shihai1991
shihai1991 approved these changes Apr 20, 2020
View reviewed changes

@shihai1991 shihai1991 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner
vstinner reviewed Apr 20, 2020
View reviewed changes
Comment thread Lib/unittest/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Apr 20, 2020
View reviewed changes
Comment thread Lib/unittest/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added 2 commits April 20, 2020 18:46
@serhiy-storchaka
Add comments.
ea6d6f2
@serhiy-storchaka
Add blusrb.
edd3bc1
vstinner
vstinner approved these changes Apr 20, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 20, 2020
@vstinner

vstinner commented Apr 20, 2020

Copy link
Copy Markdown
Member

Even if unittest.async_case is only new in 3.9, you might add a NEWS entry to mention that you made the import lazy. It's up to you, I already approved your PR ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
Tweak wording of the NEWS entry.
41a52c8
vstinner
vstinner approved these changes Apr 20, 2020
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (I reviewed the NEWS entry.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
serhiy-storchaka merged commit 3c8a5b4 into python:master Apr 25, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 25, 2020
@serhiy-storchaka
serhiy-storchaka deleted the test-support-asyncio branch April 25, 2020 07:04
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Apr 27, 2020
@CuriousLearner
Merge branch 'master' of github.com:python/cpython into fix-issue21914
42c39a3 
* 'master' of github.com:python/cpython: (2949 commits)
  Add files in tests/test_peg_generator to the install target lists (pythonGH-19723)
  bpo-40398: Fix typing.get_args() for special generic aliases. (pythonGH-19720)
  bpo-40348: Fix typos in the programming FAQ (pythonGH-19729)
  bpo-38387: Formally document PyDoc_STRVAR and PyDoc_STR macros (pythonGH-16607)
  bpo-40401: Remove duplicate pyhash.h include from pythoncore.vcxproj (pythonGH-19725)
  bpo-40387: Improve queue join() example. (pythonGH-19724)
  bpo-40396: Support GenericAlias in the typing functions. (pythonGH-19718)
  Fix typo in Lib/typing.py (pythonGH-19717)
  Fix typo in object.__format__ docs (pythonGH-19504)
  bpo-40275: Avoid importing logging in test.support (pythonGH-19601)
  bpo-40275: Avoid importing socket in test.support (pythonGH-19603)
  bpo-40275: Avoid importing asyncio in test.support (pythonGH-19600)
  bpo-40279: Add some error-handling to the module initialisation docs example (pythonGH-19705)
  closes bpo-40385: Remove Tools/scripts/checkpyc.py (pythonGH-19709)
  bpo-40334: Add What's New sections for PEP 617 and PEP 585 (pythonGH-19704)
  bpo-40340: Separate examples more clearly in the programming FAQ (pythonGH-19688)
  bpo-40360: Deprecate lib2to3 module in light of PEP 617 (pythonGH-19663)
  bpo-40334: Rewrite test_c_parser to avoid memory leaks (pythonGH-19694)
  bpo-38061: subprocess uses closefrom() on FreeBSD (pythonGH-19697)
  bpo-38061: os.closerange() uses closefrom() on FreeBSD (pythonGH-19696)
  ...
MadGreg-UK
MadGreg-UK reviewed Jul 22, 2022
View reviewed changes

@MadGreg-UK MadGreg-UK left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finded https://docs.github.com/github/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
MadGreg-UK
MadGreg-UK reviewed Jul 22, 2022
View reviewed changes

@MadGreg-UK MadGreg-UK left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MadGreg-UK

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@shihai1991 shihai1991 shihai1991 approved these changes
+1 more reviewer
@MadGreg-UK MadGreg-UK MadGreg-UK left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@serhiy-storchaka @vstinner @MadGreg-UK @shihai1991 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.