GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40348: Fix typos in the programming FAQ by ZackerySpytz · Pull Request #19729 · python/cpython

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Apr 27, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue40348

Automerge-Triggered-By: @aeros

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZackerySpytz
bpo-40348: Fix typos in the programming FAQ
c59b7d9
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 27, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 27, 2020
@ZackerySpytz

ZackerySpytz commented Apr 27, 2020

Copy link
Copy Markdown
Contributor Author

This is a "skip news" PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aeros aeros added the skip news label Apr 27, 2020
aeros
aeros approved these changes Apr 27, 2020
View reviewed changes

@aeros aeros left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ZackerySpytz. Based on the above context, a self.__outfile does not exist. Instead, it seems like it should definitely be self._outfile. So, I agree with the reporter of the bpo issue and the fix made in the PR.

This typo is also present in the 3.8 and 3.7 docs; I'll backport it to those branches as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 27, 2020
@aeros aeros added needs backport to 3.7 labels Apr 27, 2020
@miss-islington
miss-islington merged commit caf1aad into python:master Apr 27, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 27, 2020
@miss-islington

miss-islington commented Apr 27, 2020

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 27, 2020
@ZackerySpytz @miss-islington
bpo-40348: Fix typos in the programming FAQ (pythonGH-19729)
a22fcb1 
(cherry picked from commit caf1aad)

Co-authored-by: Zackery Spytz <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Apr 27, 2020
@bedevere-bot

bedevere-bot commented Apr 27, 2020

Copy link
Copy Markdown

GH-19730 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.7 label Apr 27, 2020
@bedevere-bot

bedevere-bot commented Apr 27, 2020

Copy link
Copy Markdown

GH-19731 is a backport of this pull request to the 3.7 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 27, 2020
@ZackerySpytz @miss-islington
bpo-40348: Fix typos in the programming FAQ (pythonGH-19729)
b768c94 
(cherry picked from commit caf1aad)

Co-authored-by: Zackery Spytz <[email protected]>
miss-islington added a commit that referenced this pull request Apr 27, 2020
@miss-islington @ZackerySpytz
bpo-40348: Fix typos in the programming FAQ (GH-19729)
25def5f 
(cherry picked from commit caf1aad)

Co-authored-by: Zackery Spytz <[email protected]>
miss-islington added a commit that referenced this pull request Apr 27, 2020
@miss-islington @ZackerySpytz
bpo-40348: Fix typos in the programming FAQ (GH-19729)
9412f4d 
(cherry picked from commit caf1aad)

Co-authored-by: Zackery Spytz <[email protected]>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Apr 27, 2020
@CuriousLearner
Merge branch 'master' of github.com:python/cpython into fix-issue21914
42c39a3 
* 'master' of github.com:python/cpython: (2949 commits)
  Add files in tests/test_peg_generator to the install target lists (pythonGH-19723)
  bpo-40398: Fix typing.get_args() for special generic aliases. (pythonGH-19720)
  bpo-40348: Fix typos in the programming FAQ (pythonGH-19729)
  bpo-38387: Formally document PyDoc_STRVAR and PyDoc_STR macros (pythonGH-16607)
  bpo-40401: Remove duplicate pyhash.h include from pythoncore.vcxproj (pythonGH-19725)
  bpo-40387: Improve queue join() example. (pythonGH-19724)
  bpo-40396: Support GenericAlias in the typing functions. (pythonGH-19718)
  Fix typo in Lib/typing.py (pythonGH-19717)
  Fix typo in object.__format__ docs (pythonGH-19504)
  bpo-40275: Avoid importing logging in test.support (pythonGH-19601)
  bpo-40275: Avoid importing socket in test.support (pythonGH-19603)
  bpo-40275: Avoid importing asyncio in test.support (pythonGH-19600)
  bpo-40279: Add some error-handling to the module initialisation docs example (pythonGH-19705)
  closes bpo-40385: Remove Tools/scripts/checkpyc.py (pythonGH-19709)
  bpo-40334: Add What's New sections for PEP 617 and PEP 585 (pythonGH-19704)
  bpo-40340: Separate examples more clearly in the programming FAQ (pythonGH-19688)
  bpo-40360: Deprecate lib2to3 module in light of PEP 617 (pythonGH-19663)
  bpo-40334: Rewrite test_c_parser to avoid memory leaks (pythonGH-19694)
  bpo-38061: subprocess uses closefrom() on FreeBSD (pythonGH-19697)
  bpo-38061: os.closerange() uses closefrom() on FreeBSD (pythonGH-19696)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@aeros aeros aeros approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ZackerySpytz @miss-islington @bedevere-bot @aeros @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.