GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29602: fix signed zero handling in complex constructor. by mdickinson · Pull Request #203 · python/cpython

Conversation

@mdickinson

@mdickinson mdickinson commented Feb 20, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR, based on a patch by Serhiy Storchaka, fixes the issues with signed zeros identified in http://bugs.python.org/issue29602:

  • given a class class A(object) implementing __complex__, complex(A()) ignored the sign of a negative zero in the imaginary part
  • given a subclass class C(complex), construction of a C instance from a complex instance also ignored the sign of a negative zero in the imaginary part.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
mdickinson added 2 commits February 20, 2017 20:01
@mdickinson
Fix incorrect handling of signed zeros for complex-related classes.
f0bd6c5
@mdickinson
Add Misc/NEWS entry.
5c7ff78
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 20, 2017
@mdickinson mdickinson added type-bug An unexpected behavior, bug, or error needs backport to 2.7 labels Feb 20, 2017
@mdickinson
mdickinson requested a review from serhiy-storchaka February 20, 2017 20:11
serhiy-storchaka
serhiy-storchaka approved these changes Feb 20, 2017
View reviewed changes
@mdickinson
mdickinson merged commit 112ec38 into python:master Feb 20, 2017
@mdickinson
mdickinson deleted the fix/complex-subclass-zeros branch February 20, 2017 20:28
@mdickinson mdickinson mentioned this pull request Feb 20, 2017
bpo-29602: fix signed zero handling in complex constructor #204
Merged
mdickinson added a commit to mdickinson/cpython that referenced this pull request Feb 20, 2017
@mdickinson
bpo-29602: fix signed zero handling in complex constructor. (python#203)
427dcc9
* Fix incorrect handling of signed zeros for complex-related classes.

* Add Misc/NEWS entry.

(cherry picked from commit 112ec38)
mdickinson added a commit to mdickinson/cpython that referenced this pull request Feb 20, 2017
@mdickinson
bpo-29602: fix signed zero handling in complex constructor. (python#203)
ca7fcf4
* Fix incorrect handling of signed zeros for complex-related classes.

* Add Misc/NEWS entry.

(cherry picked from commit 112ec38)
This was referenced Feb 20, 2017
bpo-29602: fix signed zero handling in complex constructor #205
Merged
bpo-29602: fix signed zero handling in complex constructor #206
Merged
mdickinson added a commit that referenced this pull request Feb 20, 2017
@mdickinson
bpo-29602: fix signed zero handling in complex constructor. (#203) (#205
0936a00
)

* Fix incorrect handling of signed zeros for complex-related classes.

* Add Misc/NEWS entry.

(cherry picked from commit 112ec38)
mdickinson added a commit that referenced this pull request Feb 20, 2017
@mdickinson
bpo-29602: fix signed zero handling in complex constructor. (#203) (#206
d9b3cdd
)

* Fix incorrect handling of signed zeros for complex-related classes.

* Add Misc/NEWS entry.

(cherry picked from commit 112ec38)
@Mariatta Mariatta removed needs backport to 2.7 labels Feb 21, 2017
akruis added a commit to akruis/cpython that referenced this pull request Jan 6, 2019
@akruis
Stackless issue python#203: use the macro _PyStackless_TRY_STACKLESS
f6dfdea
instead of _PyRuntime.st.try_stackless.
akruis added a commit to akruis/cpython that referenced this pull request Jan 12, 2019
@akruis
Stackless issue python#203: use the macro _PyStackless_TRY_STACKLESS
60f321a
instead of _PyRuntime.st.try_stackless.
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @Mariatta
Update cherry_picker from 1.2.1 to 1.2.2 (#203)
158701a
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@jaraco
Add test capturing current behavior and missed expectation. Ref pytho…
94d59b6
…n#203.
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@jaraco
Remove restriction that a 'package' cannot be a module. Allows resolu…
5b1281d
…tion of resources from adjacent modules, even those not found in a package. Fixes python#203.
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@jaraco
Update changelog. Ref python#203.
a60496b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mdickinson @serhiy-storchaka @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.