GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-29602: fix signed zero handling in complex constructor by mdickinson · Pull Request #205 · python/cpython

Conversation

@mdickinson

@mdickinson mdickinson commented Feb 20, 2017

Copy link
Copy Markdown
Member

Backport of #203 to branch for 3.5.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mdickinson
bpo-29602: fix signed zero handling in complex constructor. (python#203)
ca7fcf4 
* Fix incorrect handling of signed zeros for complex-related classes.

* Add Misc/NEWS entry.

(cherry picked from commit 112ec38)
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 20, 2017
@mdickinson mdickinson added type-bug An unexpected behavior, bug, or error cherry-pick for 3.5 labels Feb 20, 2017
serhiy-storchaka
serhiy-storchaka approved these changes Feb 20, 2017
View reviewed changes
@codecov

codecov Bot commented Feb 20, 2017

Copy link
Copy Markdown

Codecov Report

Merging #205 into 3.5 will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              3.5     #205      +/-   ##
==========================================
+ Coverage   82.41%   82.41%   +<.01%     
==========================================
  Files        1404     1404              
  Lines      341433   341454      +21     
==========================================
+ Hits       281390   281411      +21     
  Misses      60043    60043
Impacted Files Coverage Δ
Lib/test/test_complex.py 98.41% <100%> (+0.06%) ✅
Lib/test/test_select.py 87.69% <ø> (-1.54%) ❌
Lib/threading.py 81.73% <ø> (-0.87%) ❌
Lib/test/test_poll.py 92.02% <ø> (-0.62%) ❌
Lib/test/lock_tests.py 86.17% <ø> (-0.59%) ❌
Lib/test/test_thread.py 66.32% <ø> (-0.52%) ❌
Lib/nntplib.py 81.21% <ø> (-0.36%) ❌
Lib/test/test_buffer.py 96.53% <ø> (-0.18%) ❌
Lib/test/test_weakref.py 96.58% <ø> (-0.16%) ❌
Lib/pydoc.py 62.05% <ø> (-0.07%) ❌
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66fa9d4...ca7fcf4. Read the comment docs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mdickinson
mdickinson merged commit 0936a00 into python:3.5 Feb 20, 2017
@mdickinson
mdickinson deleted the bpo-29549-backport-to-3.5 branch February 20, 2017 21:50
akruis added a commit to akruis/cpython that referenced this pull request Jan 13, 2019
@akruis
Stackless issue python#205: fix building with STACKLESS_OFF
d194757 
The recent changes broke building with STACKLESS_OFF
(Usually $ make CFLAGS=-DSTACKLESS_OFF).
Now it works again.
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@pyup-bot @Mariatta
Update cachetools from 3.0.0 to 3.1.0 (#205)
fa17dcc
jaraco added a commit to jaraco/cpython that referenced this pull request Feb 17, 2023
@jaraco
Merge pull request python#205 from FFY00/reame-compatible-versions
eb05540 
readme: update compatible Python versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mdickinson @serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.