GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-26205: Specify the number of nested scopes by nanjekyejoannah · Pull Request #21324 · python/cpython

Conversation

@nanjekyejoannah

@nanjekyejoannah nanjekyejoannah commented Jul 5, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue26205

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nanjekyejoannah
Clarify number of scopes
549f0b9
@nanjekyejoannah nanjekyejoannah added the skip news label Jul 5, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 5, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jul 5, 2020
terryjreedy
terryjreedy requested changes Jul 6, 2020
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve with the requested change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/tutorial/classes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 6, 2020
@bedevere-bot

bedevere-bot commented Jul 6, 2020

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Jul 6, 2020
@nanjekyejoannah @terryjreedy
Indicate 3 or 4
54ab7a6 
Co-authored-by: Terry Jan Reedy <[email protected]>
terryjreedy
terryjreedy approved these changes Jul 6, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Jul 6, 2020
@terryjreedy

terryjreedy commented Jul 6, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Please merge and backport with a changed ('activated') title, as I discussed on #21340.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy terryjreedy added needs backport to 3.8 labels Jul 6, 2020
@nanjekyejoannah nanjekyejoannah changed the title bpo-26205: Inconsistency concerning nested scopes bpo-26205: Specify number of nested scopes Jul 6, 2020
@nanjekyejoannah nanjekyejoannah changed the title bpo-26205: Specify number of nested scopes bpo-26205: Specify the number of nested scopes Jul 6, 2020
@nanjekyejoannah
nanjekyejoannah merged commit 9ed3cd8 into python:master Jul 6, 2020
@miss-islington

miss-islington commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 6, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2020
@nanjekyejoannah @miss-islington
bpo-26205: Specify the number of nested scopes (pythonGH-21324)
f43eee8 
* Clarify number of scopes

* Indicate 3 or 4

Co-authored-by: Terry Jan Reedy <[email protected]>

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 9ed3cd8)

Co-authored-by: Joannah Nanjekye <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 6, 2020

Copy link
Copy Markdown

GH-21341 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jul 6, 2020
@bedevere-bot

bedevere-bot commented Jul 6, 2020

Copy link
Copy Markdown

GH-21342 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Jul 6, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2020
@nanjekyejoannah @miss-islington
bpo-26205: Specify the number of nested scopes (pythonGH-21324)
b5dc5ea 
* Clarify number of scopes

* Indicate 3 or 4

Co-authored-by: Terry Jan Reedy <[email protected]>

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 9ed3cd8)

Co-authored-by: Joannah Nanjekye <[email protected]>
@nanjekyejoannah

nanjekyejoannah commented Jul 6, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the review @terryjreedy
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nanjekyejoannah added a commit that referenced this pull request Jul 6, 2020
@miss-islington @nanjekyejoannah
bpo-26205: Specify the number of nested scopes (GH-21324) (GH-21342)
7ceb3e3 
* Clarify number of scopes

* Indicate 3 or 4

Co-authored-by: Terry Jan Reedy <[email protected]>

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 9ed3cd8)

Co-authored-by: Joannah Nanjekye <[email protected]>

Co-authored-by: Joannah Nanjekye <[email protected]>
nanjekyejoannah added a commit that referenced this pull request Jul 6, 2020
@miss-islington @nanjekyejoannah
bpo-26205: Specify the number of nested scopes (GH-21324) (GH-21341)
3f4a9fd 
* Clarify number of scopes

* Indicate 3 or 4

Co-authored-by: Terry Jan Reedy <[email protected]>

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 9ed3cd8)

Co-authored-by: Joannah Nanjekye <[email protected]>

Co-authored-by: Joannah Nanjekye <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jul 6, 2020
@nanjekyejoannah @terryjreedy @shihai1991
bpo-26205: Specify the number of nested scopes (pythonGH-21324)
a085bc2 
* Clarify number of scopes

* Indicate 3 or 4

Co-authored-by: Terry Jan Reedy <[email protected]>

Co-authored-by: Terry Jan Reedy <[email protected]>
@RoscoeRHiggins RoscoeRHiggins mannequin mentioned this pull request Oct 29, 2022
Better specify number of nested scopes #70393
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@nanjekyejoannah @bedevere-bot @terryjreedy @miss-islington @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.