GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-28681: Clarify multiple function names in the tutorial by nanjekyejoannah · Pull Request #21340 · python/cpython

Conversation

@nanjekyejoannah

@nanjekyejoannah nanjekyejoannah commented Jul 5, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Merged ideas from @bitdancer and @terryjreedy in the bpo thread.

https://bugs.python.org/issue28681

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nanjekyejoannah
improve control flow docs
c880542
@nanjekyejoannah nanjekyejoannah added the skip news label Jul 5, 2020
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 5, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jul 5, 2020
terryjreedy
terryjreedy requested changes Jul 6, 2020
View reviewed changes

@terryjreedy terryjreedy left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the addition of 'also' to the part I wrote. Re-reading, I find it a bit jarring without the addition. Thank you for attending to this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/tutorial/controlflow.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Jul 6, 2020
@bedevere-bot

bedevere-bot commented Jul 6, 2020

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nanjekyejoannah @terryjreedy
Add also
dac2d86 
Co-authored-by: Terry Jan Reedy <[email protected]>
@terryjreedy terryjreedy changed the title bpo-28681: About function renaming in the tutorial bpo-28681: Clarify multiple function names in the tutorial Jul 6, 2020
@terryjreedy

terryjreedy commented Jul 6, 2020

Copy link
Copy Markdown
Member

Guido strongly prefers and the devguide now clearly states that the first message line of a merged commit should be an active tense statement, like the first line of docstrings. (I would say "Should start with an active verb" except that there might be a short introductory phrase.) This is easier to ensure if the default, the PR title, is written that way. Hence my edit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy terryjreedy mentioned this pull request Jul 6, 2020
bpo-26205: Specify the number of nested scopes #21324
Merged
terryjreedy
terryjreedy approved these changes Jul 6, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Jul 6, 2020
@terryjreedy terryjreedy added needs backport to 3.8 labels Jul 6, 2020
@nanjekyejoannah
nanjekyejoannah merged commit d12af71 into python:master Jul 6, 2020
@miss-islington

miss-islington commented Jul 6, 2020

Copy link
Copy Markdown
Contributor

Thanks @nanjekyejoannah for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 6, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2020
@nanjekyejoannah @miss-islington
bpo-28681: Clarify multiple function names in the tutorial (pythonGH-…
aafa60e 
…21340)

* improve control flow docs

* Add also

Co-authored-by: Terry Jan Reedy <[email protected]>

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit d12af71)

Co-authored-by: Joannah Nanjekye <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 6, 2020

Copy link
Copy Markdown

GH-21343 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jul 6, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2020
@nanjekyejoannah @miss-islington
bpo-28681: Clarify multiple function names in the tutorial (pythonGH-…
715fb11 
…21340)

* improve control flow docs

* Add also

Co-authored-by: Terry Jan Reedy <[email protected]>

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit d12af71)

Co-authored-by: Joannah Nanjekye <[email protected]>
@nanjekyejoannah

nanjekyejoannah commented Jul 6, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the review @terryjreedy
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 6, 2020

Copy link
Copy Markdown

GH-21344 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Jul 6, 2020
nanjekyejoannah added a commit that referenced this pull request Jul 6, 2020
@miss-islington @nanjekyejoannah
bpo-28681: Clarify multiple function names in the tutorial (GH-21340) (…
00c09f0 
…GH-21343)

* improve control flow docs

* Add also

Co-authored-by: Terry Jan Reedy <[email protected]>

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit d12af71)

Co-authored-by: Joannah Nanjekye <[email protected]>

Co-authored-by: Joannah Nanjekye <[email protected]>
nanjekyejoannah added a commit that referenced this pull request Jul 6, 2020
@miss-islington @nanjekyejoannah
bpo-28681: Clarify multiple function names in the tutorial (GH-21340) (…
6790f9b 
…GH-21344)

* improve control flow docs

* Add also

Co-authored-by: Terry Jan Reedy <[email protected]>

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit d12af71)

Co-authored-by: Joannah Nanjekye <[email protected]>

Co-authored-by: Joannah Nanjekye <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jul 6, 2020
@nanjekyejoannah @terryjreedy @shihai1991
bpo-28681: Clarify multiple function names in the tutorial (pythonGH-…
f3ebc64 
…21340)

* improve control flow docs

* Add also

Co-authored-by: Terry Jan Reedy <[email protected]>

Co-authored-by: Terry Jan Reedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@nanjekyejoannah @bedevere-bot @terryjreedy @miss-islington @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.