GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41858: Fix incomplete line on optparse documentation by eamanu · Pull Request #22407 · python/cpython

Conversation

@eamanu

@eamanu eamanu commented Sep 25, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This line seems to be incomplete. This fix come from the translation
to spanish of @fjsevilla-dev on python/python-docs-es#758.
reading the proposal for the translate has sense add the next lines.

I thinks that NEWS could be ignore here.

https://bugs.python.org/issue41858

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@earias314
Fix incomplete line on optparse documentation
4e65fc3 
This line seems to be incomplete. This fix come from the translation
to spanish of @fjsevilla-dev on python/python-docs-es#758.
reading the proposal for the translate has sense add `the next lines`.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 25, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Sep 25, 2020
@eamanu eamanu mentioned this pull request Sep 25, 2020
Traducido archivo library/optparse python/python-docs-es#758
Merged
taleinat
taleinat reviewed Sep 26, 2020
View reviewed changes

@taleinat taleinat left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my eyes (I'm a native English speaker but not a language expert), "the following lines" is not required, though I agree that this sentence is slightly too terse without it.

I'd change this to "users can run either one of:".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@taleinat taleinat added the skip news label Sep 26, 2020
@taleinat

taleinat commented Sep 26, 2020

Copy link
Copy Markdown
Contributor

On second thought, I prefer @terryjreedy's suggestion on the b.p.o. issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@earias314
Use following instead of the next lines`
1142818
@terryjreedy terryjreedy self-assigned this Sep 27, 2020
@terryjreedy terryjreedy added needs backport to 3.8 labels Sep 27, 2020
@terryjreedy
terryjreedy merged commit 00eb063 into python:master Sep 27, 2020
@miss-islington

miss-islington commented Sep 27, 2020

Copy link
Copy Markdown
Contributor

Thanks @eamanu for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Sep 27, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2020
@eamanu @miss-islington
bpo-41858: Clarify line in optparse doc (pythonGH-22407)
8b0b7a5 
The existing line is easily read as being incomplete.
(cherry picked from commit 00eb063)

Co-authored-by: Emmanuel Arias <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 27, 2020

Copy link
Copy Markdown

GH-22425 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Sep 27, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2020
@eamanu @miss-islington
bpo-41858: Clarify line in optparse doc (pythonGH-22407)
9ac0ffe 
The existing line is easily read as being incomplete.
(cherry picked from commit 00eb063)

Co-authored-by: Emmanuel Arias <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 27, 2020

Copy link
Copy Markdown

GH-22426 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Sep 27, 2020
miss-islington added a commit that referenced this pull request Sep 27, 2020
@miss-islington @eamanu
bpo-41858: Clarify line in optparse doc (GH-22407)
e0e614c 
The existing line is easily read as being incomplete.
(cherry picked from commit 00eb063)

Co-authored-by: Emmanuel Arias <[email protected]>
miss-islington added a commit that referenced this pull request Sep 27, 2020
@miss-islington @eamanu
bpo-41858: Clarify line in optparse doc (GH-22407)
8b2595f 
The existing line is easily read as being incomplete.
(cherry picked from commit 00eb063)

Co-authored-by: Emmanuel Arias <[email protected]>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 29, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_1635741_1
e3b9365 
* origin/master: (113 commits)
  bpo-41773: Raise exception for non-finite weights in random.choices().  (pythonGH-22441)
  bpo-41873: Add vectorcall for float() (pythonGH-22432)
  bpo-41861: Convert _sqlite3 PrepareProtocolType to heap type (pythonGH-22428)
  bpo-41842: Add codecs.unregister() function (pythonGH-22360)
  bpo-41875: Use __builtin_unreachable when possible (pythonGH-22433)
  bpo-40105: ZipFile truncate in append mode with shorter comment (pythonGH-19337)
  bpo-41870: Use PEP 590 vectorcall to speed up bool()  (pythonGH-22427)
  [doc] Leverage the fact that the actual types can now be indexed for typing (pythonGH-22340)
  bpo-41861: Convert _sqlite3 cache and node static types to heap types (pythonGH-22417)
  bpo-41858: Clarify line in optparse doc (pythonGH-22407)
  Revert "Fix all Python Cookbook links (python#22205)" (pythonGH-22424)
  bpo-1635741: Port _bisect module to multi-phase init (pythonGH-22415)
  bpo-41428: Fix compiler warning in unionobject.c (pythonGH-22416)
  Fix logging error message (pythonGH-22410)
  bpo-39934: Account for control blocks in 'except' in compiler. (pythonGH-22395)
  bpo-41775: Make 'IDLE Shell' the shell title  (python#22399)
  bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388)
  bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387)
  bpo-41833: threading.Thread now uses the target name (pythonGH-22357)
  bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633)
  ...
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
@miss-islington @eamanu @ambv
bpo-41858: Clarify line in optparse doc (pythonGH-22407)
a5750cf 
The existing line is easily read as being incomplete.
(cherry picked from commit 00eb063)

Co-authored-by: Emmanuel Arias <[email protected]>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@eamanu @xzy3-cdc
bpo-41858: Clarify line in optparse doc (pythonGH-22407)
ecdc675 
The existing line is easily read as being incomplete.
@eamanu
eamanu deleted the fix-optparsedoc branch November 8, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@taleinat taleinat taleinat left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@eamanu @taleinat @miss-islington @bedevere-bot @the-knights-who-say-ni @terryjreedy @earias314
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.