GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41861: Convert sqlite3 cache and node types to heap types by erlend-aasland · Pull Request #22417 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Sep 26, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@vstinner, ref. PR #22409

https://bugs.python.org/issue41861

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Erlend E. Aasland added 3 commits September 26, 2020 12:15
Erlend E. Aasland
Convert CacheType to heap type
b3af287
Erlend E. Aasland
Convert NodeType to heap type
c3cedc5
Erlend E. Aasland
Add NEWS entry
a3e33bd
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner September 26, 2020 10:31
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 26, 2020
@bedevere-bot bedevere-bot added the awaiting review label Sep 26, 2020
@erlend-aasland erlend-aasland changed the title bpo-41861: /cache and node types bpo-41861: Convert sqlite3 cache and node types to heap types Sep 26, 2020
vstinner
vstinner reviewed Sep 26, 2020
View reviewed changes
Comment thread Modules/_sqlite/cache.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Modules/_sqlite/cache.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Misc/NEWS.d/next/Library/2020-09-26-12-16-28.bpo-41861.3xTsIp.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland
Revert "Add NEWS entry"
f1568b1
This reverts commit a3e33bd.
@vstinner vstinner added the skip news label Sep 26, 2020
Erlend E. Aasland added 2 commits September 26, 2020 13:03
Erlend E. Aasland
Use PyType_FromModuleAndSpec iso. PyType_FromSpec
cdb6e4c
Erlend E. Aasland
Improve dealloc
6be8abc
@erlend-aasland

erlend-aasland commented Sep 26, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for your comments, @vstinner. Please take another look.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland
Fix dealloc for cache type as well
fad7260
@erlend-aasland
erlend-aasland requested a review from vstinner September 26, 2020 11:46
Erlend E. Aasland
Make node type spec static
e8be010
@erlend-aasland

erlend-aasland commented Sep 26, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@vstinner I've prepared the other PR's, and after applying the same suggestions to every (upcoming) PR, I've gotten rid of the reference leaks. So now, all the sqlite3 types are ready. I suggest to squash the statement and prepare protocol type in one PR, and then keep the rest as separate PRs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit a937ab4 into python:master Sep 27, 2020
@bedevere-bot bedevere-bot removed the awaiting review label Sep 27, 2020
@vstinner

vstinner commented Sep 27, 2020

Copy link
Copy Markdown
Member

Merged, thanks! You can now convert the next static types ;-)

erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Sep 27, 2020

Copy link
Copy Markdown
Contributor Author

Merged, thanks! You can now convert the next static types ;-)

Yay, will do :) Thanks for reviewing!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland
erlend-aasland deleted the fix-bpo-41861/cache-and-node-types branch September 27, 2020 18:34
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 29, 2020
@shihai1991
Merge remote-tracking branch 'origin/master' into bpo_1635741_1
e3b9365
* origin/master: (113 commits)
  bpo-41773: Raise exception for non-finite weights in random.choices().  (pythonGH-22441)
  bpo-41873: Add vectorcall for float() (pythonGH-22432)
  bpo-41861: Convert _sqlite3 PrepareProtocolType to heap type (pythonGH-22428)
  bpo-41842: Add codecs.unregister() function (pythonGH-22360)
  bpo-41875: Use __builtin_unreachable when possible (pythonGH-22433)
  bpo-40105: ZipFile truncate in append mode with shorter comment (pythonGH-19337)
  bpo-41870: Use PEP 590 vectorcall to speed up bool()  (pythonGH-22427)
  [doc] Leverage the fact that the actual types can now be indexed for typing (pythonGH-22340)
  bpo-41861: Convert _sqlite3 cache and node static types to heap types (pythonGH-22417)
  bpo-41858: Clarify line in optparse doc (pythonGH-22407)
  Revert "Fix all Python Cookbook links (python#22205)" (pythonGH-22424)
  bpo-1635741: Port _bisect module to multi-phase init (pythonGH-22415)
  bpo-41428: Fix compiler warning in unionobject.c (pythonGH-22416)
  Fix logging error message (pythonGH-22410)
  bpo-39934: Account for control blocks in 'except' in compiler. (pythonGH-22395)
  bpo-41775: Make 'IDLE Shell' the shell title  (python#22399)
  bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388)
  bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387)
  bpo-41833: threading.Thread now uses the target name (pythonGH-22357)
  bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633)
  ...
@erlend-aasland erlend-aasland mentioned this pull request Oct 17, 2020
bpo-40775: Fix sqlite3 Node type naming #20418
Closed
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Erlend Egeberg Aasland @xzy3-cdc
bpo-41861: Convert _sqlite3 cache and node static types to heap types (…
37e67ca
…pythonGH-22417)
@erlend-aasland erlend-aasland mentioned this pull request Aug 20, 2021
bpo-24905: Support BLOB incremental I/O in sqlite module #271
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.