GeezerVison

FYI, rebased onto master, applied _PyType_GetModuleByDef in order to migrate from global to module state.

I have made the requested changes; please review again.

Thanks for making the requested changes!

: please review the changes made to this pull request.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO + PGO 3.x has failed when building commit 01c6aa4.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/442/builds/671) and take a look at the build logs.
4. Check if the failure is related to this commit (01c6aa4) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/442/builds/671

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

409 tests OK.

10 slowest tests:

• test_concurrent_futures: 2 min 40 sec
• test_multiprocessing_spawn: 1 min 7 sec
• test_multiprocessing_forkserver: 1 min 1 sec
• test_multiprocessing_fork: 52.3 sec
• test_signal: 47.3 sec
• test_asyncio: 47.1 sec
• test_imaplib: 32.2 sec
• test_pydoc: 31.1 sec
• test_io: 30.5 sec
• test_socket: 29.1 sec

1 test altered the execution environment:
test_asyncio

15 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib test_nis
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 4 min 54 sec

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/selector_events.py", line 680, in abort
    self._force_close(None)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/selector_events.py", line 731, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/base_events.py", line 746, in call_soon
    self._check_closed()
  File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

Thanks for reviewing, @pitrou !

@pitrou: You merged the commit message with the sentence:

@vstinner / @corona10, would you mind reviewing this?

And I'm now getting emails from cpython forks, like this commit:

JelleZijlstra@01c6aa4

Ah, sorry. I get this sometimes when my name is mentioned too :-)

Ah, sorry. I get this sometimes when my name is mentioned too :-)

Well, the "automerge" label causes a similar feature and it's part of our workflow. I'm not sure how to ignore such emails. @pganssle has such issue: https://twitter.com/pganssle/status/1379161385863643155

It's partly my fault; I cc'd you in the PR text instead of in a separate comment/post. After this incident, I've made sure I don't mention anyone in the PR text. Maybe it could be mentioned in the Dev Guide? Maybe we could make the CI prevent it by rewriting the commit message (if needed) upon merging.

I asked how to not get spammed on python-committers: https://mail.python.org/archives/list/[email protected]/thread/OCVQ6IYOVTVYW7ADDNOHKR7JDRBYLM3T/