GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40077: Fix typo in simplequeue_get_state_by_type() by erlend-aasland · Pull Request #23975 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Dec 28, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The typo did no damage, but it looks suspicious and confusing.
Introduced by GH-23136.

Skip news.

https://bugs.python.org/issue40077

Automerge-Triggered-By: GH:pitrou

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-40077: Fix typo in simplequeue_get_state_by_type()
85b53a0 
The typo did no damage, but it looks suspicious and confusing.
Introduced by pythonGH-23136.
@erlend-aasland
erlend-aasland requested a review from rhettinger as a code owner December 28, 2020 11:21
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 28, 2020
@bedevere-bot bedevere-bot added the awaiting review label Dec 28, 2020
@erlend-aasland

erlend-aasland commented Dec 28, 2020

Copy link
Copy Markdown
Contributor Author

cc @corona10 / @vstinner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Dec 28, 2020

Copy link
Copy Markdown
Member

cc @pitrou who merged PR #23136.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pitrou pitrou added skip news 🤖 automerge labels Dec 28, 2020
pitrou
pitrou approved these changes Dec 28, 2020
View reviewed changes

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an obvious fix. Thank you @erlend-aasland for spotting this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 28, 2020
@miss-islington
miss-islington merged commit bf108bb into python:master Dec 28, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 28, 2020
@erlend-aasland
erlend-aasland deleted the fix-queuemod-macro branch December 28, 2020 19:13
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-40077: Fix typo in simplequeue_get_state_by_type() (pythonGH-23975)
13da1da 
The typo did no damage, but it looks suspicious and confusing.
Introduced by pythonGH-23136.

Skip news.

Automerge-Triggered-By: GH:pitrou
@corona10 corona10 mentioned this pull request Jun 27, 2022
Convert static types to heap types: use PyType_FromSpec() #84258
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@erlend-aasland @vstinner @pitrou @the-knights-who-say-ni @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.