GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-41832: Update PyType_Slot.pfunc description info in type.rst by shihai1991 · Pull Request #23243 · python/cpython

Conversation

@shihai1991

@shihai1991 shihai1991 commented Nov 12, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Revert the PyType_Slot.pfunc description info which was deleted in #23123.

https://bugs.python.org/issue41832

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@shihai1991
Update PyType_Slot.pfunc description info in type.rst
f391db5
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 12, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 12, 2020
@shihai1991

shihai1991 commented Nov 12, 2020

Copy link
Copy Markdown
Member Author

I revert the slot.pfunc info. cc @encukou
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mental32
mental32 approved these changes Nov 12, 2020
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Nov 12, 2020
encukou
encukou reviewed Nov 13, 2020
View reviewed changes
Comment thread Doc/c-api/type.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Nov 13, 2020

Copy link
Copy Markdown
Member

Can we update it for Py_tp_doc like this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou added the skip news label Nov 13, 2020
@shihai1991
apply petr's comment
a6d8bd1
@shihai1991

shihai1991 commented Nov 14, 2020

Copy link
Copy Markdown
Member Author

Can we update it for Py_tp_doc like this?

Sure. your description info will be more exact.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit 2b39da4 into python:master Nov 14, 2020
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 14, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@shihai1991 @adorilson
bpo-41832: Restore note about NULL in PyType_Slot.pfunc (pythonGH-23243)
901d99b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
+1 more reviewer
@mental32 mental32 mental32 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@shihai1991 @encukou @mental32 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.