GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-41832: PyType_FromModuleAndSpec() can accept the NULL tp_doc slot. by shihai1991 · Pull Request #23123 · python/cpython

Conversation

shihai1991 commented Nov 3, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

https://bugs.python.org/issue41832

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          PyType_FromModuleAndSpec() can accept tp_doc=NULL

e604f31

shihai1991 requested a review from markshannon as a code owner

November 3, 2020 12:44

the-knights-who-say-ni added the CLA signed label

Nov 3, 2020

bedevere-bot added the awaiting review label

Nov 3, 2020

shihai1991 commented Nov 3, 2020

Copy link

Copy Markdown

Member Author

pls take a look, thanks. @vstinner @corona10 @encukou

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner reviewed

Nov 3, 2020

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove empty docstrings from the _lsprof module? See PR #22220.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_testcapimodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

shihai1991 commented Nov 3, 2020

Copy link

Copy Markdown

Member Author

Can you please remove empty docstrings from the _lsprof module? See PR #22220.

No problem. I planed to use a seperate PR to do it before ;)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

shihai1991 force-pushed the bpo_41832 branch from d9aca89 to f42beb2 Compare

November 3, 2020 16:35


          apply victor's comment

dabfb67

shihai1991 force-pushed the bpo_41832 branch from f42beb2 to dabfb67 Compare

November 3, 2020 17:03

vstinner reviewed

Nov 3, 2020

View reviewed changes

Comment thread

Doc/whatsnew/3.10.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_lsprof.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_testcapimodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

shihai1991 added 2 commits

November 4, 2020 12:47


          apply victor's comment

1f5eec3


          apply petr's comment

d0aafe3

shihai1991 force-pushed the bpo_41832 branch from f249edc to d0aafe3 Compare

November 4, 2020 12:37

vstinner reviewed

Nov 4, 2020

View reviewed changes

Comment thread

Modules/_testcapimodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/type.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

shihai1991 added 2 commits

November 5, 2020 12:53


          apply victor's comment

cca7bc7


          Merge branch 'master' into bpo_41832

c267e35

* master:
  bpo-42260: Add _PyInterpreterState_SetConfig() (pythonGH-23158)
  Disable peg generator tests when building with PGO (pythonGH-23141)
  bpo-1635741: _sqlite3 uses PyModule_AddObjectRef() (pythonGH-23148)
  bpo-1635741: Fix PyInit_pyexpat() error handling (pythonGH-22489)
  bpo-42260: Main init modify sys.flags in-place (pythonGH-23150)
  bpo-1635741: Fix ref leak in _PyWarnings_Init() error path (pythonGH-23151)
  bpo-1635741: _ast uses PyModule_AddObjectRef() (pythonGH-23146)
  bpo-1635741: _contextvars uses PyModule_AddType() (pythonGH-23147)
  bpo-42260: Reorganize PyConfig (pythonGH-23149)
  bpo-1635741: Add PyModule_AddObjectRef() function (pythonGH-23122)
  bpo-42236: os.device_encoding() respects UTF-8 Mode (pythonGH-23119)
  bpo-42251: Add gettrace and getprofile to threading (pythonGH-23125)
  Enable signing of nuget.org packages and update to supported timestamp server (pythonGH-23132)
  Fix incorrect links in ast docs (pythonGH-23017)
  Add _PyType_GetModuleByDef (pythonGH-22835)
  Post 3.10.0a2
  bpo-41796: Call _PyAST_Fini() earlier to fix a leak (pythonGH-23131)
  bpo-42249: Fix writing binary Plist files larger than 4 GiB. (pythonGH-23121)
  bpo-40077: Convert mmap.mmap static type to a heap type (pythonGH-23108)
  Python 3.10.0a2

shihai1991 changed the title ~~bpo-41832: PyType_FromModuleAndSpec() can accept tp_doc=NULL~~ bpo-41832: PyType_FromModuleAndSpec() can accept the NULL tp_doc slot.

Nov 5, 2020

vstinner approved these changes

Nov 5, 2020

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please rephase the PyType_FromModuleAndSpec() note.

@encukou: Do yo want to double check the PR?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/c-api/type.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/type.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/type.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting merge and removed awaiting review labels

Nov 5, 2020

shihai1991 added 2 commits

November 6, 2020 12:16


          Merge remote-tracking branch 'origin/master' into bpo_41832

15e18cc

* origin/master:
  bpo-42179: Doc/tutorial: Remove mention of __cause__ (pythonGH-23162)
  bpo-26389: Allow passing an exception object in the traceback module (pythonGH-22610)
  bpo-42260: PyConfig_Read() only parses argv once (pythonGH-23168)
  bpo-42260: Add _PyConfig_FromDict() (pythonGH-23167)
  bpo-41877 Check for asert, aseert, assrt in mocks (pythonGH-23165)
  [docs] fix wrongly named AsyncContextDecorator (pythonGH-23164)
  bpo-42262: Add Py_NewRef() and Py_XNewRef() (pythonGH-23152)
  bpo-42266: Handle monkey-patching descriptors in LOAD_ATTR cache (pythonGH-23157)
  bpo-40816 Add AsyncContextDecorator class (pythonGH-20516)


          apply victor's comment

b452c05

vstinner merged commit 88c2cfd into python:master

Nov 6, 2020

bedevere-bot removed the awaiting merge label

Nov 6, 2020

vstinner commented Nov 6, 2020

Copy link

Copy Markdown

Member

Thanks, the updated documentation is way better. I merged your PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

shihai1991 added a commit to shihai1991/cpython that referenced this pull request

Nov 7, 2020


          Merge remote-tracking branch 'origin/master' into bpo_41073_add_types…

2d72953

…lots1

* origin/master: (80 commits)
  bpo-42282: Fold constants inside named expressions (pythonGH-23190)
  bpo-41028: Doc: Move switchers to docsbuild-scripts. (pythonGH-20969)
  bpo-42133: update parts of the stdlib to fall back to `__spec__.loader` when `__loader__` is missing (python#22929)
  Remove outdated reference to pywin32 from platform module (pythonGH-22005)
  bpo-41832: PyType_FromModuleAndSpec() now accepts NULL tp_doc (pythonGH-23123)
  Minor grammar edits for the descriptor howto guide (GH-python#23175)
  bpo-42179: Doc/tutorial: Remove mention of __cause__ (pythonGH-23162)
  bpo-26389: Allow passing an exception object in the traceback module (pythonGH-22610)
  bpo-42260: PyConfig_Read() only parses argv once (pythonGH-23168)
  bpo-42260: Add _PyConfig_FromDict() (pythonGH-23167)
  bpo-41877 Check for asert, aseert, assrt in mocks (pythonGH-23165)
  [docs] fix wrongly named AsyncContextDecorator (pythonGH-23164)
  bpo-42262: Add Py_NewRef() and Py_XNewRef() (pythonGH-23152)
  bpo-42266: Handle monkey-patching descriptors in LOAD_ATTR cache (pythonGH-23157)
  bpo-40816 Add AsyncContextDecorator class (pythonGH-20516)
  bpo-42260: Add _PyInterpreterState_SetConfig() (pythonGH-23158)
  Disable peg generator tests when building with PGO (pythonGH-23141)
  bpo-1635741: _sqlite3 uses PyModule_AddObjectRef() (pythonGH-23148)
  bpo-1635741: Fix PyInit_pyexpat() error handling (pythonGH-22489)
  bpo-42260: Main init modify sys.flags in-place (pythonGH-23150)
  ...

shihai1991 mentioned this pull request

Nov 12, 2020

bpo-41832: Update PyType_Slot.pfunc description info in type.rst #23243

Merged

adorilson pushed a commit to adorilson/cpython that referenced this pull request

Mar 13, 2021


          bpo-41832: PyType_FromModuleAndSpec() now accepts NULL tp_doc (python…

d0a2a94

…GH-23123)

Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request

May 3, 2021


          bpo-41832: PyType_FromModuleAndSpec() now accepts NULL tp_doc (python…

a2b620c

…GH-23123)

Reviewers

vstinner

vstinner approved these changes

markshannon

Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

shihai1991 commented Nov 3, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shihai1991 commented Nov 3, 2020

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shihai1991 commented Nov 3, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner commented Nov 6, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shihai1991 commented Nov 3, 2020 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.