GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [doc] Fix erroneous backslashes in signatures and names by andresdelfino · Pull Request #23658 · python/cpython

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Dec 5, 2020 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The issue being resolved is shown in the 3.10 docs (if you select docs for older versions you won't see a visual glitch).

The newer sphinx version that produces the 3.10 docs doesn't treat the backslash to escape things in some situations it previously did.

Automerge-Triggered-By: GH:Mariatta

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@andresdelfino
Fix signatures markup
1eea567
@andresdelfino
andresdelfino requested review from 1st1, asvetlov and ethanfurman as code owners December 5, 2020 15:22
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 5, 2020
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 5, 2020
@andresdelfino
Fix signatures markup
2a2a63f
@andresdelfino andresdelfino added skip issue skip news labels Dec 5, 2020
andresdelfino added 3 commits December 5, 2020 12:36
@andresdelfino
Fix signatures markup
d21522b
@andresdelfino
Fix signatures markup
9299e00
@andresdelfino
Fix signatures markup
153c71d
@andresdelfino
andresdelfino requested a review from a team as a code owner December 6, 2020 20:26
@andresdelfino
Fix attribute markup
afd6dd2
@andresdelfino andresdelfino mentioned this pull request Dec 8, 2020
[doc] Fix email.policy.Policy.mangle_from_ name #23605
Closed
@andresdelfino andresdelfino changed the title [doc] Fix signatures markup [doc] Fix signatures and attributes markup Dec 8, 2020
@andresdelfino andresdelfino changed the title [doc] Fix signatures and attributes markup [doc] Fix erroneous backslashes Dec 8, 2020
@andresdelfino andresdelfino changed the title [doc] Fix erroneous backslashes [doc] Fix erroneous backslashes in signatures and names Dec 8, 2020
@andresdelfino andresdelfino added needs backport to 3.8 labels Dec 10, 2020
Mariatta
Mariatta approved these changes Dec 17, 2020
View reviewed changes

@Mariatta Mariatta left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Dec 17, 2020
@Mariatta Mariatta added the 🤖 automerge label Dec 17, 2020
@miss-islington
miss-islington merged commit dcc997c into python:master Dec 17, 2020
@miss-islington

miss-islington commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Dec 17, 2020
@miss-islington

miss-islington commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

Sorry, @andresdelfino, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dcc997cd28ab33ebac44182ee55533c1b37689f7 3.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington miss-islington self-assigned this Dec 17, 2020
@miss-islington

miss-islington commented Dec 17, 2020

Copy link
Copy Markdown
Contributor

Sorry @andresdelfino, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker dcc997cd28ab33ebac44182ee55533c1b37689f7 3.8

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andresdelfino
andresdelfino deleted the fix_signatures branch December 17, 2020 01:39
@andresdelfino

andresdelfino commented Dec 17, 2020

Copy link
Copy Markdown
Contributor Author

I'll work on the backports tomorrow.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Dec 17, 2020
@andresdelfino
[3.9] [doc] Fix erroneous backslashes in signatures and names (python…
45075c2
…GH-23658)

The issue being resolved is shown in the 3.10 docs (if you select docs for older versions you won't see a visual glitch).

The newer sphinx version that produces the 3.10 docs doesn't treat the backslash to escape things in some situations it previously did..
(cherry picked from commit dcc997c)

Co-authored-by: Andre Delfino <[email protected]>
@bedevere-bot

bedevere-bot commented Dec 17, 2020

Copy link
Copy Markdown

GH-23827 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Dec 17, 2020
@bedevere-bot

bedevere-bot commented Dec 17, 2020

Copy link
Copy Markdown

GH-23828 is a backport of this pull request to the 3.8 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Dec 17, 2020
andresdelfino added a commit to andresdelfino/cpython that referenced this pull request Dec 17, 2020
@andresdelfino
[3.8] [doc] Fix erroneous backslashes in signatures and names (python…
246dfee
…GH-23658)

The issue being resolved is shown in the 3.10 docs (if you select docs for older versions you won't see a visual glitch).

The newer sphinx version that produces the 3.10 docs doesn't treat the backslash to escape things in some situations it previously did..
(cherry picked from commit dcc997c)

Co-authored-by: Andre Delfino <[email protected]>
miss-islington pushed a commit that referenced this pull request Dec 22, 2020
@andresdelfino
[3.9] [doc] Fix erroneous backslashes in signatures and names (GH-23658…
e89993c
…) (GH-23827)

The issue being resolved is shown in the 3.10 docs (if you select docs for older versions you won't see a visual glitch).

The newer sphinx version that produces the 3.10 docs doesn't treat the backslash to escape things in some situations it previously did..
(cherry picked from commit dcc997c)

Co-authored-by: Andre Delfino <[email protected]>
miss-islington pushed a commit that referenced this pull request Dec 22, 2020
@andresdelfino
[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658…
02349e2
…) (GH-23828)

The issue being resolved is shown in the 3.10 docs (if you select docs for older versions you won't see a visual glitch).

The newer sphinx version that produces the 3.10 docs doesn't treat the backslash to escape things in some situations it previously did..
(cherry picked from commit dcc997c)

Co-authored-by: Andre Delfino <[email protected]>
@TizzySaurus TizzySaurus mentioned this pull request Jan 2, 2021
Python escape codes (\n, \t etc.) are missing the '\' for 3.8 and 3.9 docs python/python-docs-theme#63
Closed
JulienPalard added a commit that referenced this pull request Jan 4, 2021
@JulienPalard
Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (…
b806721
…GH-23658)"

This partially reverts commit
e89993c, which was removing
backslashes in documentations compiled with Sphinx < 3, used for
Python 3.8 and 3.9 docs.
JulienPalard added a commit that referenced this pull request Jan 4, 2021
@JulienPalard
Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (…
bcacd9d
…GH-23658)"

This partially reverts commit
02349e2, which was removing
backslashes in documentations compiled with Sphinx < 3, used for
Python 3.8 and 3.9 docs.
JulienPalard added a commit that referenced this pull request Jan 4, 2021
@JulienPalard
Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (…
218ed0b
…GH-23658)" (GH-24093)

This partially reverts commit
02349e2, which was removing
backslashes in documentations compiled with Sphinx < 3, used for
Python 3.8 and 3.9 docs.
JulienPalard added a commit that referenced this pull request Jan 4, 2021
@JulienPalard
Revert "[3.9] [doc] Fix erroneous backslashes in signatures and names (…
e6d0107
…GH-23658)" (GH-24092)

This partially reverts commit
e89993c, which was removing
backslashes in documentations compiled with Sphinx < 3, used for
Python 3.8 and 3.9 docs.
JulienPalard added a commit to JulienPalard/cpython that referenced this pull request Jan 21, 2021
@JulienPalard
Revert "[doc] Fix erroneous backslashes in signatures and names (pyth…
900251b
…onGH-23658)" (pythonGH-24093)

This partially reverts commit
02349e2, which was removing
backslashes in documentations compiled with Sphinx < 3, used for
Python 3.8 and 3.9 docs.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@andresdelfino @adorilson
[doc] Fix erroneous backslashes in signatures and names (pythonGH-23658)
4afb8db
The issue being resolved is shown in the 3.10 docs (if you select docs for older versions you won't see a visual glitch).

The newer sphinx version that produces the 3.10 docs doesn't treat the backslash to escape things in some situations it previously did.
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 12, 2022
[DOC] Warnings/notes in docs including most of the page #91483
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes
@1st1 1st1 Awaiting requested review from 1st1
@asvetlov asvetlov Awaiting requested review from asvetlov
@ethanfurman ethanfurman Awaiting requested review from ethanfurman

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@miss-islington miss-islington

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@andresdelfino @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.