GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" by JulienPalard · Pull Request #24093 · python/cpython

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Jan 4, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Reverts #23828 due to python/python-docs-theme#63

https://bugs.python.org/issue42822

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JulienPalard
JulienPalard requested review from a team, 1st1, asvetlov and gpshead as code owners January 4, 2021 12:35
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 4, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jan 4, 2021
@JulienPalard

JulienPalard commented Jan 4, 2021

Copy link
Copy Markdown
Member Author

Hum no, a full revert is not needed, only some bits has to be reverted, let me check this in details.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JulienPalard
JulienPalard requested a review from andresdelfino January 4, 2021 12:37
@JulienPalard
Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (…
bcacd9d 
…GH-23658)"

This partially reverts commit
02349e2, which was removing
backslashes in documentations compiled with Sphinx < 3, used for
Python 3.8 and 3.9 docs.
@JulienPalard
JulienPalard force-pushed the revert-23828-backport-dcc997c-3.8 branch from 43bcae7 to bcacd9d Compare January 4, 2021 12:51
@JulienPalard

JulienPalard commented Jan 4, 2021

Copy link
Copy Markdown
Member Author

@andresdelfino Same here, I kept only backslashes involved in strings, so in one hand we keep the difference as small as possible between versions (easing backports), while keeping the doc right.

I hope I picked the right ones, I still did not took the time to build it locally to visually check every change (I'm at $DAYJOB lunch break ;p).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JulienPalard JulienPalard changed the title Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" Jan 4, 2021
@JulienPalard JulienPalard added skip news docs Documentation in the Doc dir labels Jan 4, 2021
@JulienPalard JulienPalard changed the title bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" [3.8] bpo-42822: Revert "[3.8] [doc] Fix erroneous backslashes in signatures and names (GH-23658)" Jan 4, 2021
@bedevere-bot bedevere-bot added the skip issue label Jan 4, 2021
andresdelfino
andresdelfino approved these changes Jan 4, 2021
View reviewed changes

@andresdelfino andresdelfino left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andresdelfino

andresdelfino commented Jan 4, 2021

Copy link
Copy Markdown
Contributor

@JulienPalard I compared your changes with the ones introduced and found all of the problematic ones fixed :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JulienPalard
JulienPalard merged commit 218ed0b into 3.8 Jan 4, 2021
@JulienPalard
JulienPalard deleted the revert-23828-backport-dcc997c-3.8 branch January 4, 2021 16:19
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 4, 2021
JulienPalard added a commit to JulienPalard/cpython that referenced this pull request Jan 21, 2021
@JulienPalard
Revert "[doc] Fix erroneous backslashes in signatures and names (pyth…
900251b 
…onGH-23658)" (pythonGH-24093)

This partially reverts commit
02349e2, which was removing
backslashes in documentations compiled with Sphinx < 3, used for
Python 3.8 and 3.9 docs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gpshead gpshead Awaiting requested review from gpshead
1 more reviewer
@andresdelfino andresdelfino andresdelfino approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JulienPalard @andresdelfino @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.