GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlib by aeros · Pull Request #23728 · python/cpython

Conversation

@aeros

@aeros aeros commented Dec 10, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

As per PEP 594, this PR removes asyncore, asynchat, and smptd. This includes any documentation, tests, and source code, except for parts that were needed for existing tests. Those were moved to Lib/test/support/<module>, and the essential parts were determined through usage of coverage.py. After I removed test_<module>, I looked to see which members were utilized in the existing tests, and removed any that were not used. I did not do any partial removals though; e.g. specific unused branches within a member that is otherwise used. I also left unused __repr__ for debugging purposes.

For improved communication and convenience to users, importing any of the 3 removed modules after these changes results in the following:

raise ImportError(
    "As of 3.10, <module> has been removed from the standard library, see "
    "PEP 594 for details. An archived (no longer maintained) version exists "
    "at https://github.com/tiran/legacylib"
)

This could potentially be removed in couple versions if needed, but since it imposes no real maintenance burden I think we can leave the custom ImportError indefinitely. The only change would possibly be updating tiran/legacylib to python/legacylib, assuming it is eventually moved there.

https://bugs.python.org/issue42611

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
aeros added 2 commits December 9, 2020 23:21
@aeros
Remove asyncore, asynchat, and smptd
c060dcb
@aeros
Fix whitespace
dfb3e37
@aeros aeros added the skip issue label Dec 10, 2020
@aeros
aeros requested a review from tiran December 10, 2020 04:40
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 10, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Dec 10, 2020
@aeros aeros changed the title PEP 594 - Remove asyncore, asynchat, and smptd from stdlib bpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlib Dec 10, 2020
@aeros aeros removed the skip issue label Dec 10, 2020
blurb-it Bot and others added 3 commits December 10, 2020 04:53
@blurb-it
📜🤖 Added by blurb_it.
cbf67d3
@aeros
Remove module references in doc ToC
ee6c2f3
@aeros
Use concurrent.futures for test_support test_CleanImport
1a2a823
@aeros
aeros marked this pull request as ready for review December 10, 2020 05:52
@aeros
aeros requested review from a team and vsajip as code owners December 10, 2020 05:52
@aeros
aeros removed request for a team and vsajip December 10, 2020 06:22
@aeros aeros added the DO-NOT-MERGE label Dec 18, 2020
@github-actions

github-actions Bot commented Jan 18, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 18, 2021
@tiran
tiran removed their request for review December 7, 2021 12:07
@hugovk hugovk mentioned this pull request Apr 11, 2022
Remove asyncore, asynchat and smtpd modules #72719
Closed
@hugovk

hugovk commented Apr 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Follow-up: PEP 594 has been accepted and these modules are set for removal in 3.12.

Relevant issues:

  • Remove asyncore, asynchat and smtpd modules #72719
  • test_poplib replace asyncore #74699
  • PEP 594 Removing dead batteries from stdlib #86777
  • Deprecate modules listed in PEP 594 #91217

Merged documentation PRs:

  • bpo-47022: Document asynchat, asyncore and smtpd removals in 3.12 #31891
  • bpo-47061: document module deprecations due to PEP 594 #31984

I expect 3.12 will open for development in about a month when 3.11 reaches beta.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk mentioned this pull request Apr 11, 2022
test_poplib replace asyncore #74699
Closed
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 2, 2022
@iritkatriel

iritkatriel commented Aug 28, 2022

Copy link
Copy Markdown
Member

Closing as out of date.

This PR was superseded by #72719 (which was reverted and will not be superseded by yet a new one).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@iritkatriel iritkatriel closed this Aug 28, 2022
@aeros aeros mentioned this pull request May 12, 2023
PEP 594 Removing dead batteries from stdlib #86777
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@aeros @hugovk @iritkatriel @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.