GeezerVison is showing github.com — bpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlib by aeros · Pull Request #23728 · python/cpython
Conversation
aeros
commented
Dec 10, 2020
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
As per PEP 594, this PR removes asyncore, asynchat, and smptd. This includes any documentation, tests, and source code, except for parts that were needed for existing tests. Those were moved to Lib/test/support/<module>, and the essential parts were determined through usage of coverage.py. After I removed test_<module>, I looked to see which members were utilized in the existing tests, and removed any that were not used. I did not do any partial removals though; e.g. specific unused branches within a member that is otherwise used. I also left unused __repr__ for debugging purposes.
For improved communication and convenience to users, importing any of the 3 removed modules after these changes results in the following:
raise ImportError(
"As of 3.10, <module> has been removed from the standard library, see "
"PEP 594 for details. An archived (no longer maintained) version exists "
"at https://github.com/tiran/legacylib"
)
This could potentially be removed in couple versions if needed, but since it imposes no real maintenance burden I think we can leave the custom ImportError indefinitely. The only change would possibly be updating tiran/legacylib to python/legacylib, assuming it is eventually moved there.
https://bugs.python.org/issue42611
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
aeros
changed the title
PEP 594 - Remove asyncore, asynchat, and smptd from stdlib
bpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlib
Dec 10, 2020
|
This PR is stale because it has been open for 30 days with no activity.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
hugovk
commented
Apr 11, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Follow-up: PEP 594 has been accepted and these modules are set for removal in 3.12.
Relevant issues:
Merged documentation PRs:
I expect 3.12 will open for development in about a month when 3.11 reaches beta.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Closing as out of date.
This PR was superseded by #72719 (which was reverted and will not be superseded by yet a new one).
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|