GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-47022: Document asynchat, asyncore and smtpd removals in 3.12 by hugovk · Pull Request #31891 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Mar 15, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594.

Automerge-Triggered-By: GH:brettcannon

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hugovk
hugovk requested a review from a team as a code owner March 15, 2022 07:50
@bedevere-bot bedevere-bot added the awaiting review label Mar 15, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 15, 2022
@hugovk hugovk added needs backport to 3.9 labels Mar 15, 2022
@hugovk

This comment was marked as resolved.

Sign in to view
@hugovk hugovk added the docs Documentation in the Doc dir label Mar 15, 2022
@hugovk
bpo-47022: Document asynchat, asyncore and smtpd removals in 3.12
3eb9ba8
@hugovk
hugovk force-pushed the pep594-document-3.12-removals branch from 662a963 to 3eb9ba8 Compare March 15, 2022 10:05
@hugovk
hugovk requested review from brettcannon and tiran March 15, 2022 10:49
@brettcannon

brettcannon commented Mar 15, 2022

Copy link
Copy Markdown
Member

Two things.

One, can you add a directive to the docs like:

cpython/Doc/library/imp.rst

Line 6 in 099f756

:deprecated:

? That's what makes a module say "deprecated" in the module index.

Two, the SC wanted to leave out target removal versions in the docs in case we have to change something due to feedback (in the code itself via the warnings.warn call still makes sense). But since these modules were already deprecated and the community has not come back asking to save them I think specifying 3.12 is safe.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hugovk added 2 commits March 16, 2022 10:44
@hugovk
bpo-47022: Mark asynchat, asyncore and smtpd as deprecated in module …
f0b3842
…list
@hugovk
bpo-47022: List asynchat, asyncore and smtpd on deprecated modules page
4f5e33b
@hugovk

hugovk commented Mar 16, 2022

Copy link
Copy Markdown
Member Author

Two things.

One, can you add a directive to the docs like:

cpython/Doc/library/imp.rst

Line 6 in 099f756

:deprecated:

? That's what makes a module say "deprecated" in the module index.

Done!

Also added to the Superseded Modules page listing deprecated modules (imp is there), putting those needing most attention first (to be removed soonest, and most recently added).

Two, the SC wanted to leave out target removal versions in the docs in case we have to change something due to feedback (in the code itself via the warnings.warn call still makes sense). But since these modules were already deprecated and the community has not come back asking to save them I think specifying 3.12 is safe.

👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brettcannon
brettcannon approved these changes Mar 16, 2022
View reviewed changes
asvetlov
asvetlov approved these changes Mar 16, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 16, 2022
@brettcannon brettcannon added the 🤖 automerge label Mar 18, 2022
@miss-islington
miss-islington merged commit 7747384 into python:main Mar 18, 2022
@miss-islington

miss-islington commented Mar 18, 2022

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Mar 18, 2022
@miss-islington

miss-islington commented Mar 18, 2022

Copy link
Copy Markdown
Contributor

Sorry, @hugovk, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 77473846439b8a3eae66de1a1cfe931619f38513 3.10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington miss-islington self-assigned this Mar 18, 2022
@miss-islington

miss-islington commented Mar 18, 2022

Copy link
Copy Markdown
Contributor

Sorry @hugovk, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 77473846439b8a3eae66de1a1cfe931619f38513 3.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk
hugovk deleted the pep594-document-3.12-removals branch March 19, 2022 20:39
hugovk added a commit to hugovk/cpython that referenced this pull request Mar 19, 2022
@hugovk
[3.10] bpo-47022: Document asynchat, asyncore and smtpd removals in 3…
f5751f7
….12 (pythonGH-31891)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <[email protected]>
@hugovk hugovk mentioned this pull request Mar 19, 2022
[3.10] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.12 (GH-31891) #31997
Merged
@bedevere-bot

bedevere-bot commented Mar 19, 2022

Copy link
Copy Markdown

GH-31997 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Mar 19, 2022
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Mar 19, 2022
@bedevere-bot

bedevere-bot commented Mar 19, 2022

Copy link
Copy Markdown

GH-31998 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

asvetlov pushed a commit that referenced this pull request Mar 20, 2022
@hugovk
[3.10] bpo-47022: Document asynchat, asyncore and smtpd removals in 3…
94f038c
….12 (GH-31891) (#31997)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit to hugovk/cpython that referenced this pull request Mar 22, 2022
@hugovk
[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.…
5419793
…12 (pythonGH-31891)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <[email protected]>
brettcannon pushed a commit that referenced this pull request Mar 22, 2022
@hugovk
[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.…
af341eb
…12 (GH-31891) (#31998)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <[email protected]>
This was referenced Apr 11, 2022
Remove asyncore, asynchat and smtpd modules #72719
Closed
bpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlib #23728
Closed
@hugovk hugovk mentioned this pull request Apr 26, 2022
gh-68966: Deprecate the mailcap module #91951
Merged
This was referenced May 9, 2022
Enforce the use of deprecated-removed in docs #92564
Open
gh-92611: Link to section for PEP 594 modules; mention rm version & alternatives #92612
Merged
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@hugovk @hello-adam
[3.9] bpo-47022: Document asynchat, asyncore and smtpd removals in 3.…
bf720a3
…12 (pythonGH-31891) (python#31998)

Document the deprecation of asyncore, asynchat, and smtpd with a slated removal in Python 3.12 thanks to PEP 594..
(cherry picked from commit 7747384)

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@asvetlov asvetlov asvetlov approved these changes
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@miss-islington miss-islington

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@hugovk @brettcannon @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.