GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-47061: document module deprecations due to PEP 594 by brettcannon · Pull Request #31984 · python/cpython

Conversation

@brettcannon

@brettcannon brettcannon commented Mar 18, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Also removed asynchat, asyncore, and smtpd from their respective toctree entries so they are only in the superceded subtree.

https://bugs.python.org/issue47061

Automerge-Triggered-By: GH:brettcannon

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brettcannon
bpo-47061: document module deprecations due to PEP 594
f42355b
@brettcannon
brettcannon requested a review from ethanfurman as a code owner March 18, 2022 20:26
@bedevere-bot bedevere-bot added the awaiting core review label Mar 18, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 18, 2022
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Mar 18, 2022
@brettcannon
Add a news entry
a2d4308
@brettcannon
brettcannon requested a review from tiran March 18, 2022 20:33
@brettcannon brettcannon self-assigned this Mar 18, 2022
tiran
tiran approved these changes Mar 18, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 18, 2022
tiran
tiran reviewed Mar 18, 2022
View reviewed changes
Comment thread Doc/library/chunk.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tiran
Fix typo in chunk.rst
236a3d5
ngnpope
ngnpope reviewed Mar 19, 2022
View reviewed changes
Comment thread Doc/library/audioop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon @ngnpope
Update Doc/library/audioop.rst
3083a86 
Co-authored-by: Nick Pope <[email protected]>
hugovk
hugovk reviewed Mar 19, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-03-18-13-30-40.bpo-47061.etLHK5.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Mar 19, 2022

Copy link
Copy Markdown
Member

Should this also have an entry in "What's New In Python 3.11"?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon
Tweak the news file formatting
77f59a7
@brettcannon

brettcannon commented Mar 21, 2022

Copy link
Copy Markdown
Member Author

Should this also have an entry in "What's New In Python 3.11"?

I purposefully left one out as I will updating it as I go along and deprecate the modules which I will be doing in separate PRs.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon brettcannon added needs backport to 3.9 labels Mar 21, 2022
@miss-islington
miss-islington merged commit 9ac2de9 into python:main Mar 21, 2022
@miss-islington

miss-islington commented Mar 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 21, 2022
@miss-islington

miss-islington commented Mar 21, 2022

Copy link
Copy Markdown
Contributor

Sorry, @brettcannon, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9ac2de922a0f783bd43b8e026e4fb70fd1888572 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned miss-islington and unassigned brettcannon Mar 21, 2022
@brettcannon
brettcannon deleted the pep594-docs branch March 21, 2022 23:16
@bedevere-bot

bedevere-bot commented Mar 21, 2022

Copy link
Copy Markdown

GH-32039 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Mar 21, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 21, 2022
@brettcannon @miss-islington
bpo-47061: document module deprecations due to PEP 594 (pythonGH-31984)
1f61ddb 
Also removed asynchat, asyncore, and smtpd from their respective toctree entries so they are only  in the superceded subtree.
(cherry picked from commit 9ac2de9)

Co-authored-by: Brett Cannon <[email protected]>
@brettcannon

brettcannon commented Mar 21, 2022

Copy link
Copy Markdown
Member Author

Thanks everyone for the reviews!
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Mar 22, 2022
@miss-islington
[3.10] bpo-47061: document module deprecations due to PEP 594 (GH-31984…
c353835 
…) (GH-32039)

Also removed asynchat, asyncore, and smtpd from their respective toctree entries so they are only  in the superceded subtree.
(cherry picked from commit 9ac2de9)


Co-authored-by: Brett Cannon <[email protected]>

Automerge-Triggered-By: GH:brettcannon
@hugovk

hugovk commented Mar 23, 2022

Copy link
Copy Markdown
Member

And thanks for the PR!

Is a manual 3.9 backport needed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon

brettcannon commented Mar 23, 2022

Copy link
Copy Markdown
Member Author

@hugovk yep, a manual backport for 3.9 is needed. I was planning to tackle it probably this Friday, but if you want to take it on I will not stop you. 😉
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk pushed a commit to hugovk/cpython that referenced this pull request Mar 23, 2022
@brettcannon @hugovk
[3.9] bpo-47061: document module deprecations due to PEP 594 (pythonG…
059a8f3 
…H-31984)

Also removed asynchat, asyncore, and smtpd from their respective toctree entries so they are only  in the superceded subtree.
(cherry picked from commit 9ac2de9)

Co-authored-by: Brett Cannon <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Mar 23, 2022
@bedevere-bot

bedevere-bot commented Mar 23, 2022

Copy link
Copy Markdown

GH-32082 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Mar 23, 2022

Copy link
Copy Markdown
Member

There we go, and the cherry_picker 9ac2de922a0f783bd43b8e026e4fb70fd1888572 3.9 command applied cleanly first time :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit that referenced this pull request Mar 23, 2022
@hugovk
[3.9] bpo-47061: document module deprecations due to PEP 594 (GH-31984)…
e513b81 
… (GH-32082)

Also removed asynchat, asyncore, and smtpd from their respective toctree entries so they are only  in the superceded subtree.
(cherry picked from commit 9ac2de9)

Co-authored-by: Brett Cannon <[email protected]>

Automerge-Triggered-By: GH:brettcannon
This was referenced Apr 11, 2022
Remove asyncore, asynchat and smtpd modules #72719
Closed
bpo-42611: PEP 594 - Remove asyncore, asynchat, and smptd from stdlib #23728
Closed
@brettcannon brettcannon mentioned this pull request Apr 11, 2022
Deprecate modules listed in PEP 594 #91217
Closed
@hugovk hugovk mentioned this pull request Apr 26, 2022
gh-68966: Deprecate the mailcap module #91951
Merged
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@hugovk @hello-adam
[3.9] bpo-47061: document module deprecations due to PEP 594 (pythonG…
71691c9 
…H-31984) (pythonGH-32082)

Also removed asynchat, asyncore, and smtpd from their respective toctree entries so they are only  in the superceded subtree.
(cherry picked from commit 9ac2de9)

Co-authored-by: Brett Cannon <[email protected]>

Automerge-Triggered-By: GH:brettcannon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@ethanfurman ethanfurman Awaiting requested review from ethanfurman
+2 more reviewers
@tiran tiran tiran approved these changes
@ngnpope ngnpope ngnpope left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@miss-islington miss-islington

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@brettcannon @hugovk @miss-islington @bedevere-bot @tiran @ngnpope @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.