GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40956: Fix sqlite3 AC code by corona10 · Pull Request #23837 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Dec 18, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40956

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
bpo-40956: Fix sqlite3 AC code
a5641af
@corona10
corona10 requested a review from serhiy-storchaka December 18, 2020 14:47
@corona10
corona10 requested a review from berkerpeksag as a code owner December 18, 2020 14:47
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 18, 2020
@bedevere-bot bedevere-bot added the awaiting core review label Dec 18, 2020
@corona10 corona10 added skip news and removed awaiting core review labels Dec 18, 2020
@corona10

corona10 commented Dec 18, 2020

Copy link
Copy Markdown
Member Author

This PR is the fixed code that I missed through the code review.
#23341 (review)
cc @erlend-aasland
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Dec 18, 2020

Copy link
Copy Markdown
Member Author

@serhiy-storchaka Can you please take a look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Dec 18, 2020
View reviewed changes
@bedevere-bot bedevere-bot added the awaiting merge label Dec 18, 2020
@erlend-aasland

erlend-aasland commented Dec 18, 2020

Copy link
Copy Markdown
Contributor

This PR is the fixed code that I missed through the code review.
#23341 (review)
cc @erlend-aasland

Thanks, @corona10 & @serhiy-storchaka !
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Dec 18, 2020
bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 1 of 2 #23341
Merged
@corona10
corona10 merged commit 2179349 into python:master Dec 18, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 18, 2020
@corona10

corona10 commented Dec 18, 2020

Copy link
Copy Markdown
Member Author

Thanks! @serhiy-storchaka @erlend-aasland
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 deleted the bpo-40956-ac branch December 18, 2020 15:42
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@corona10 @adorilson
bpo-40956: Fix sqlite3 AC code (pythonGH-23837)
e2f6bb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@corona10 @erlend-aasland @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.