GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 1 of 2 by erlend-aasland · Pull Request #23341 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Nov 17, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue40956

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
Convert _sqlite3.Connection to Argument Clinic, part 1
4d178b6
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner November 17, 2020 14:16
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 17, 2020
@bedevere-bot bedevere-bot added the awaiting review label Nov 17, 2020
@erlend-aasland

erlend-aasland commented Nov 17, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@corona10: As proposed on #23057, I've split that PR up in two parts. This is the first, and larger (by line count) part, however probably the easiest to review, as the AC conversion is straight-forward.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Nov 17, 2020
gh-79097: Add support for aggregate window functions in sqlite3 #20903
Merged
gh-84943: Add support for 'directonly' and 'innocuous' flags for user-defined functions #20398
Closed
@erlend-aasland

erlend-aasland commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

@corona10 Have you had time to look at this? Let me know if still think it's too large for a single review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 self-requested a review December 17, 2020 10:40
@corona10

corona10 commented Dec 17, 2020

Copy link
Copy Markdown
Member

@erlend-aasland I will take a look ;)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Dec 17, 2020

Copy link
Copy Markdown
Contributor Author

@corona10 Thank you :) 🙏🏻
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 added the skip news label Dec 18, 2020
corona10
corona10 requested changes Dec 18, 2020
View reviewed changes
Comment thread Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Dec 18, 2020
@bedevere-bot

bedevere-bot commented Dec 18, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland
Address review: set_authorizer() should also accept keyword arguments
feec909
@erlend-aasland

erlend-aasland commented Dec 18, 2020

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Dec 18, 2020
@bedevere-bot

bedevere-bot commented Dec 18, 2020

Copy link
Copy Markdown

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from corona10 December 18, 2020 13:26
corona10
corona10 reviewed Dec 18, 2020
View reviewed changes
Comment thread Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 approved these changes Dec 18, 2020
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for nit comment ;)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Dec 18, 2020
Erlend E. Aasland
Address review: restore trace comment
dc1fd83
@erlend-aasland

erlend-aasland commented Dec 18, 2020

Copy link
Copy Markdown
Contributor Author

LGTM except for nit comment ;)

I appreciate a thorough review! :) PTAL
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 merged commit 1ba82bb into python:master Dec 18, 2020
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 18, 2020
serhiy-storchaka
serhiy-storchaka reviewed Dec 18, 2020
View reviewed changes
Comment thread Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_sqlite/connection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 mentioned this pull request Dec 18, 2020
bpo-40956: Fix sqlite3 AC code #23837
Merged
@erlend-aasland
erlend-aasland deleted the bpo-40956/part2a-con branch December 18, 2020 15:36
@erlend-aasland erlend-aasland mentioned this pull request Dec 30, 2020
bpo-40956: Convert _sqlite3.Cursor to Argument Clinic #24007
Merged
@erlend-aasland erlend-aasland mentioned this pull request Feb 9, 2021
bpo-43094: Update sqlite3 docs to match implementation #24489
Closed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Erlend Egeberg Aasland @adorilson
bpo-40956: Convert _sqlite3.Connection to Argument Clinic (pythonGH-2…
7f94211 
…3341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@corona10 corona10 corona10 approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @corona10 @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.